From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Frank Rowand <frowand.list@gmail.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] dt-bindings: mtd: Add YAML schemas for the generic NAND options
Date: Tue, 2 Apr 2019 08:15:05 +0200 [thread overview]
Message-ID: <20190402061505.34r53q75spqtuqcv@flea> (raw)
In-Reply-To: <CAL_JsqLSfitzkb8P5xQ+cCmcSeL6fTjQ3rVPJ2qiNdSXyps-sw@mail.gmail.com>
Hi Rob,
On Mon, Apr 01, 2019 at 08:58:49PM -0500, Rob Herring wrote:
> On Mon, Apr 1, 2019 at 4:14 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The NAND chips in MTD have a bunch of generic options that are needed in a
> > device tree. Add a YAML schemas for those.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 131 +++++++-
> > 1 file changed, 131 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mtd/nand-controller.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> > new file mode 100644
> > index 000000000000..05b1afb34972
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> > @@ -0,0 +1,131 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NAND Chip and NAND Controller Generic Binding
> > +
> > +maintainers:
> > + - Boris Brezillon <bbrezillon@kernel.org>
> > + - Miquel Raynal <miquel.raynal@bootlin.com>
> > + - Richard Weinberger <richard@nod.at>
> > +
> > +description: |
> > + The NAND controller should be represented with its own DT node, and
> > + all NAND chips attached to this controller should be defined as
> > + children nodes of the NAND controller. This representation should be
> > + enforced even for simple controllers supporting only one chip.
> > +
> > + The ECC strength and ECC step size properties define the correction
> > + capability of a controller. Together, they say a controller can
> > + correct {strength} bit errors per {size} bytes.
> > +
> > + The interpretation of these parameters is implementation-defined, so
> > + not all implementations must support all possible
> > + combinations. However, implementations are encouraged to further
> > + specify the value(s) they support.
> > +
> > +properties:
> > + $nodename:
> > + pattern: "^nand-controller(@.*)?"
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + ranges: true
>
> 'ranges' should not be here as nand chip addresses are not translatable.
Apparently, some are. It was part of the original binding, hence why
it's there.
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mtd/nand.txt#L16
> > +
> > +patternProperties:
> > + "^nand@[a-z0-9]$":
> > + properties:
> > + reg:
> > + description:
> > + Contains the native Ready/Busy IDs.
> > +
> > + nand-ecc-mode:
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/string
> > + - enum: [ none, soft, hw, hw_syndrome, hw_oob_first, on-die ]
> > + description:
> > + Operation mode of the NAND ecc mode. soft_bch is deprecated
> > + and should be replaced by soft and nand-ecc-algo
> > +
> > + nand-ecc-algo:
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/string
> > + - enum: [ hamming, bch, rs ]
> > + description:
> > + Algorithm of NAND ECC.
> > +
> > + nand-bus-width:
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32
> > + - enum: [ 8, 16 ]
> > + - default: 8
> > + description:
> > + Bus width to the NAND chip
> > +
> > + nand-on-flash-bbt:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description:
> > + Enable the on-flash Bad Block Table
> > +
> > + nand-ecc-strength:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Number of bits to correct per ECC step.
>
> Is there a range we can define here? Certainly there's a minimum
> values of at least 1.
It doesn't look like there is from a quick grep. The DT seems to be in
the 4 - 32 range, but I'm not sure if it would make sense to have
something higher.
I'll let Miquel and Boris comment.
> > +
> > + nand-ecc-step-size:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Number of data bytes covered by a single ECC step.
>
> Same here.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-02 6:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 21:13 [PATCH 1/4] dt-bindings: mtd: Add YAML schemas for the generic NAND options Maxime Ripard
2019-04-01 21:13 ` [PATCH 2/4] dt-bindings: mtd: sunxi-nand: Add YAML schemas Maxime Ripard
2019-04-02 2:02 ` Rob Herring
2019-04-01 21:13 ` [PATCH 3/4] ARM: dts: sunxi: Conform to DT spec for NAND controller Maxime Ripard
2019-04-02 8:19 ` Miquel Raynal
2019-04-01 21:13 ` [PATCH 4/4] ARM: dts: sunxi: Remove useless address and size cells Maxime Ripard
2019-04-02 8:19 ` Miquel Raynal
2019-04-02 11:11 ` Maxime Ripard
2019-04-02 1:58 ` [PATCH 1/4] dt-bindings: mtd: Add YAML schemas for the generic NAND options Rob Herring
2019-04-02 6:15 ` Maxime Ripard [this message]
2019-04-02 7:59 ` Miquel Raynal
2019-04-02 8:19 ` Miquel Raynal
2019-04-02 8:49 ` Rob Herring
2019-04-02 8:56 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402061505.34r53q75spqtuqcv@flea \
--to=maxime.ripard@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).