From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd: rawnand: sunxi: Add DMA support for sun8i
Date: Fri, 5 Apr 2019 11:37:42 +0200 [thread overview]
Message-ID: <20190405113742.184234ca@xps13> (raw)
In-Reply-To: <20190405091607.2dzckvyqibs7xmew@flea>
[-- Attachment #1.1: Type: text/plain, Size: 3411 bytes --]
Hi Maxime,
Maxime Ripard <maxime.ripard@bootlin.com> wrote on Fri, 5 Apr 2019
11:16:07 +0200:
> On Thu, Apr 04, 2019 at 06:21:10PM +0200, Miquel Raynal wrote:
> > Allwinner NAND controllers can make use of DMA to enhance the I/O
> > throughput thanks to ECC pipelining. DMA handling with sun8i NAND IP
> > is a bit different than with the older SoCs, hence the introduction of
> > a new compatible to handle:
> > * the differences between register offsets,
> > * the burst length change from 4 to minimum 8,
> > * drive SRAM accesses through the AHB bus instead of the MBUS.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/nand/raw/sunxi_nand.c | 75 ++++++++++++++++++++++++++++---
> > 1 file changed, 68 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
> > index 4282bc477761..49cd5067adaa 100644
> > --- a/drivers/mtd/nand/raw/sunxi_nand.c
> > +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> > @@ -42,7 +42,8 @@
> > #define NFC_REG_CMD 0x0024
> > #define NFC_REG_RCMD_SET 0x0028
> > #define NFC_REG_WCMD_SET 0x002C
> > -#define NFC_REG_IO_DATA 0x0030
> > +#define NFC_REG_A10_IO_DATA 0x0030
> > +#define NFC_REG_A33_IO_DATA 0x0300
> > #define NFC_REG_ECC_CTL 0x0034
> > #define NFC_REG_ECC_ST 0x0038
> > #define NFC_REG_DEBUG 0x003C
> > @@ -200,6 +201,22 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand)
> > return container_of(nand, struct sunxi_nand_chip, nand);
> > }
> >
> > +/*
> > + * NAND Controller capabilities structure: stores NAND controller capabilities
> > + * for distinction between compatible strings.
> > + *
> > + * @sram_through_ahb: On A33, we choose to access the internal RAM through AHB
> > + * instead of MBUS (less configuration). A10+ use the MBUS
>
> What do you mean by A10+ ?
I meant A1x, A2x SoCs. Not sure it matches a product line for you, so
please suggest something to mean "SoCs which are not A33" (so far I
think all worked without this).
>
> > + * but no extra configuration is needed.
> > + * @reg_io_data: I/O data register
> > + * @dma_maxburst: DMA maxburst
> > + */
> > +struct sunxi_nfc_caps {
> > + bool sram_through_ahb;
> > + unsigned int reg_io_data;
> > + unsigned int dma_maxburst;
> > +};
>
> Ideally, the introduction of that structure and the introduction of
> the A33 support should be separate patches.
Sure, I can split it up.
>
> > /**
> > * struct sunxi_nfc - stores sunxi NAND controller information
> > *
> > @@ -228,6 +245,7 @@ struct sunxi_nfc {
> > struct list_head chips;
> > struct completion complete;
> > struct dma_chan *dmac;
> > + const struct sunxi_nfc_caps *caps;
> > };
> >
> > static inline struct sunxi_nfc *to_sunxi_nfc(struct nand_controller *ctrl)
> > @@ -350,10 +368,29 @@ static int sunxi_nfc_dma_op_prepare(struct sunxi_nfc *nfc, const void *buf,
> > goto err_unmap_buf;
> > }
> >
> > - writel(readl(nfc->regs + NFC_REG_CTL) | NFC_RAM_METHOD,
> > - nfc->regs + NFC_REG_CTL);
> > + /*
> > + * On A33, we suppose the "internal RAM" (p.12 of the user manual)
>
> Which user manual? It certainly isn't the A33 user manual :)
You are right it is the A33 NAND flash controller spec.
Thanks,
Miquèl
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-05 9:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 16:21 [PATCH 0/3] Sun8i NAND DMA support Miquel Raynal
2019-04-04 16:21 ` [PATCH 1/3] dt-bindings: mtd: sunxi: Add new compatible Miquel Raynal
2019-04-05 9:13 ` Maxime Ripard
2019-04-05 9:28 ` Miquel Raynal
2019-04-05 9:56 ` Maxime Ripard
2019-04-04 16:21 ` [PATCH 2/3] mtd: rawnand: sunxi: Add DMA support for sun8i Miquel Raynal
2019-04-05 9:16 ` Maxime Ripard
2019-04-05 9:37 ` Miquel Raynal [this message]
2019-04-05 10:55 ` Maxime Ripard
2019-04-05 12:25 ` Miquel Raynal
2019-04-05 12:47 ` Maxime Ripard
2019-04-14 9:05 ` Boris Brezillon
2019-04-15 6:58 ` Miquel Raynal
2019-04-15 7:14 ` Boris Brezillon
2019-04-16 16:53 ` Miquel Raynal
2019-04-04 16:21 ` [PATCH 3/3] ARM: dts: sunxi: Improve sun8i NAND transfers by using DMA Miquel Raynal
2019-04-05 9:18 ` Maxime Ripard
2019-04-05 9:38 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405113742.184234ca@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).