* [PATCH] mtd: rawnand: marvell: Fix helper name in comment
@ 2019-04-08 9:28 Miquel Raynal
2019-04-14 8:49 ` Boris Brezillon
2019-04-18 16:19 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Miquel Raynal @ 2019-04-08 9:28 UTC (permalink / raw)
To: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Tudor Ambarus, Vignesh Raghavendra, linux-mtd
Cc: Miquel Raynal
Since the migration of the driver to stop using the legacy
->select_chip() hook, the marvell_nfc_select_chip() helper has been
'renamed' to marvell_nfc_select_target(). Update a left-over reference
to this helper in a comment in the ->resume() path.
Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/mtd/nand/raw/marvell_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index d984538980e2..6796c7015d86 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
/*
* Reset nfc->selected_chip so the next command will cause the timing
- * registers to be restored in marvell_nfc_select_chip().
+ * registers to be restored in marvell_nfc_select_target().
*/
nfc->selected_chip = NULL;
--
2.19.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: rawnand: marvell: Fix helper name in comment
2019-04-08 9:28 [PATCH] mtd: rawnand: marvell: Fix helper name in comment Miquel Raynal
@ 2019-04-14 8:49 ` Boris Brezillon
2019-04-18 16:19 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2019-04-14 8:49 UTC (permalink / raw)
To: Miquel Raynal
Cc: Vignesh Raghavendra, Tudor Ambarus, Richard Weinberger,
Marek Vasut, linux-mtd, Brian Norris, David Woodhouse
On Mon, 8 Apr 2019 11:28:49 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Since the migration of the driver to stop using the legacy
> ->select_chip() hook, the marvell_nfc_select_chip() helper has been
> 'renamed' to marvell_nfc_select_target(). Update a left-over reference
> to this helper in a comment in the ->resume() path.
>
> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/nand/raw/marvell_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index d984538980e2..6796c7015d86 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
>
> /*
> * Reset nfc->selected_chip so the next command will cause the timing
> - * registers to be restored in marvell_nfc_select_chip().
> + * registers to be restored in marvell_nfc_select_target().
> */
> nfc->selected_chip = NULL;
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: rawnand: marvell: Fix helper name in comment
2019-04-08 9:28 [PATCH] mtd: rawnand: marvell: Fix helper name in comment Miquel Raynal
2019-04-14 8:49 ` Boris Brezillon
@ 2019-04-18 16:19 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2019-04-18 16:19 UTC (permalink / raw)
To: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Tudor Ambarus, Vignesh Raghavendra, linux-mtd
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 8 Apr 2019
11:28:49 +0200:
> Since the migration of the driver to stop using the legacy
> ->select_chip() hook, the marvell_nfc_select_chip() helper has been
> 'renamed' to marvell_nfc_select_target(). Update a left-over reference
> to this helper in a comment in the ->resume() path.
>
> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/nand/raw/marvell_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index d984538980e2..6796c7015d86 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
>
> /*
> * Reset nfc->selected_chip so the next command will cause the timing
> - * registers to be restored in marvell_nfc_select_chip().
> + * registers to be restored in marvell_nfc_select_target().
> */
> nfc->selected_chip = NULL;
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch nand/next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-18 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 9:28 [PATCH] mtd: rawnand: marvell: Fix helper name in comment Miquel Raynal
2019-04-14 8:49 ` Boris Brezillon
2019-04-18 16:19 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).