* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514212751.18684-1-lede@allycomm.com> @ 2019-05-14 21:27 ` Jeff Kletsky 0 siblings, 0 replies; 8+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:27 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <20190514212941.18794-1-lede@allycomm.com>]
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514212941.18794-1-lede@allycomm.com> @ 2019-05-14 21:29 ` Jeff Kletsky 0 siblings, 0 replies; 8+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:29 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <20190514215315.19228-1-lede@allycomm.com>]
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514215315.19228-1-lede@allycomm.com> @ 2019-05-14 21:53 ` Jeff Kletsky 2019-05-15 6:17 ` Marek Vasut 2019-05-15 6:51 ` Schrempf Frieder 0 siblings, 2 replies; 8+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-14 21:53 ` Jeff Kletsky @ 2019-05-15 6:17 ` Marek Vasut 2019-05-15 6:49 ` Schrempf Frieder 2019-05-15 6:51 ` Schrempf Frieder 1 sibling, 1 reply; 8+ messages in thread From: Marek Vasut @ 2019-05-15 6:17 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd, linux-kernel On 5/14/19 11:53 PM, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> That #define in $subject is called a macro. Seems this patch adds a lot of almost duplicate code, can it be somehow de-duplicated ? > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > -- Best regards, Marek Vasut ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-15 6:17 ` Marek Vasut @ 2019-05-15 6:49 ` Schrempf Frieder 2019-05-19 20:27 ` Jeff Kletsky 0 siblings, 1 reply; 8+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:49 UTC (permalink / raw) To: Marek Vasut, Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd, linux-kernel On 15.05.19 08:17, Marek Vasut wrote: > On 5/14/19 11:53 PM, Jeff Kletsky wrote: >> From: Jeff Kletsky <git-commits@allycomm.com> > > That #define in $subject is called a macro. > > Seems this patch adds a lot of almost duplicate code, can it be somehow > de-duplicated ? We could add another parameter naddr or addrlen to the SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. This would cause one more argument to each of the macro calls in all chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm not sure if this really would make things easier and also this is "only" preprocessor code. So anyways, I would be fine with both approaches, Jeff's current one or one with another parameter for the address length. By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will just reply again to add the tags. > >> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >> for its page-read ops. >> >> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >> >> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >> --- >> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index b92e2aa955b6..05fe98eebe27 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -68,30 +68,60 @@ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 1)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 2), \ >> SPI_MEM_OP_DUMMY(ndummy, 2), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 2), \ >> + SPI_MEM_OP_DUMMY(ndummy, 2), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 4), \ >> SPI_MEM_OP_DUMMY(ndummy, 4), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 4), \ >> + SPI_MEM_OP_DUMMY(ndummy, 4), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PROG_EXEC_OP(addr) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ >> SPI_MEM_OP_ADDR(3, addr, 1), \ >> > > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-15 6:49 ` Schrempf Frieder @ 2019-05-19 20:27 ` Jeff Kletsky 2019-05-20 12:16 ` Miquel Raynal 0 siblings, 1 reply; 8+ messages in thread From: Jeff Kletsky @ 2019-05-19 20:27 UTC (permalink / raw) To: Schrempf Frieder, Marek Vasut, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd, linux-kernel On 5/14/19 11:49 PM, Schrempf Frieder wrote: > On 15.05.19 08:17, Marek Vasut wrote: >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: >>> From: Jeff Kletsky <git-commits@allycomm.com> >> That #define in $subject is called a macro. >> >> Seems this patch adds a lot of almost duplicate code, can it be somehow >> de-duplicated ? > We could add another parameter naddr or addrlen to the > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > This would cause one more argument to each of the macro calls in all > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > not sure if this really would make things easier and also this is "only" > preprocessor code. > > So anyways, I would be fine with both approaches, Jeff's current one or > one with another parameter for the address length. > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > just reply again to add the tags. > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >>> for its page-read ops. >>> >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >>> >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >>> --- >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >>> index b92e2aa955b6..05fe98eebe27 100644 >>> --- a/include/linux/mtd/spinand.h >>> +++ b/include/linux/mtd/spinand.h >>> @@ -68,30 +68,60 @@ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> + >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >>> SPI_MEM_OP_ADDR(2, addr, 1), \ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) >>> >>> [ _3A addition repeated three more times for similar ops ... ] It's easy enough to change the wording, and will do so on the next revision. However, it's not clear to me that there is consensus on if the present set of macros is acceptable/preferred over definition of a set of ones that accept an additional parameter. At least from my perspective and as Schrempf Frieder has hinted at, these macros are syntactic sugar and all result in equivalent C code. Either should compile to the same run-time size and performance (assuming reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). Adding an additional parameter, at least for me, wouldn't improve readability of the code and is offset by the need to refactor four other files. Even though it should be a simple/trivial refactor, I do not have any examples of the four other manufacturers' chips to be able to confirm proper operation. I'll prepare a reworded set of patches with the present macro structure. If there is strong feeling for refactoring the macro set, please let me know. Jeff ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-19 20:27 ` Jeff Kletsky @ 2019-05-20 12:16 ` Miquel Raynal 0 siblings, 0 replies; 8+ messages in thread From: Miquel Raynal @ 2019-05-20 12:16 UTC (permalink / raw) To: Jeff Kletsky Cc: Boris Brezillon, Richard Weinberger, linux-kernel, Schrempf Frieder, Marek Vasut, linux-mtd, Brian Norris, David Woodhouse Hi Jeff, Jeff Kletsky <lede@allycomm.com> wrote on Sun, 19 May 2019 13:27:58 -0700: > On 5/14/19 11:49 PM, Schrempf Frieder wrote: > > > On 15.05.19 08:17, Marek Vasut wrote: > >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: > >>> From: Jeff Kletsky <git-commits@allycomm.com> > >> That #define in $subject is called a macro. > >> > >> Seems this patch adds a lot of almost duplicate code, can it be somehow > >> de-duplicated ? > > We could add another parameter naddr or addrlen to the > > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > > > This would cause one more argument to each of the macro calls in all > > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > > not sure if this really would make things easier and also this is "only" > > preprocessor code. > > > > So anyways, I would be fine with both approaches, Jeff's current one or > > one with another parameter for the address length. > > > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > > just reply again to add the tags. > > > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > >>> for its page-read ops. > >>> > >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > >>> > >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > >>> --- > >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > >>> 1 file changed, 30 insertions(+) > >>> > >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > >>> index b92e2aa955b6..05fe98eebe27 100644 > >>> --- a/include/linux/mtd/spinand.h > >>> +++ b/include/linux/mtd/spinand.h > >>> @@ -68,30 +68,60 @@ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ > >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> + > >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > >>> SPI_MEM_OP_ADDR(2, addr, 1), \ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) > >>> >>> [ _3A addition repeated three more times for similar ops ... ] > > It's easy enough to change the wording, and will do so on the next revision. > > However, it's not clear to me that there is consensus on if the present > set of macros is acceptable/preferred over definition of a set of ones > that accept an additional parameter. > > At least from my perspective and as Schrempf Frieder has hinted at, > these macros are syntactic sugar and all result in equivalent C code. > > Either should compile to the same run-time size and performance (assuming > reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). > > Adding an additional parameter, at least for me, wouldn't improve readability > of the code and is offset by the need to refactor four other files. Even > though it should be a simple/trivial refactor, I do not have any examples > of the four other manufacturers' chips to be able to confirm proper operation. > > I'll prepare a reworded set of patches with the present macro structure. > > If there is strong feeling for refactoring the macro set, please let me know. On my side I would rather not add this extra argument, I know it is not very conventional to add so much macros but once you've read one you read all of them and I think it improves the readability of the code using it. Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-14 21:53 ` Jeff Kletsky 2019-05-15 6:17 ` Marek Vasut @ 2019-05-15 6:51 ` Schrempf Frieder 1 sibling, 0 replies; 8+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:51 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-20 12:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190514212751.18684-1-lede@allycomm.com>
2019-05-14 21:27 ` [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses Jeff Kletsky
[not found] <20190514212941.18794-1-lede@allycomm.com>
2019-05-14 21:29 ` Jeff Kletsky
[not found] <20190514215315.19228-1-lede@allycomm.com>
2019-05-14 21:53 ` Jeff Kletsky
2019-05-15 6:17 ` Marek Vasut
2019-05-15 6:49 ` Schrempf Frieder
2019-05-19 20:27 ` Jeff Kletsky
2019-05-20 12:16 ` Miquel Raynal
2019-05-15 6:51 ` Schrempf Frieder
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).