* [PATCH] jffs2: do not use C++ style comments in uapi header
@ 2019-06-03 16:50 Masahiro Yamada
2019-06-17 8:14 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-06-03 16:50 UTC (permalink / raw)
To: linux-mtd, David Woodhouse, Richard Weinberger
Cc: Vignesh Raghavendra, Marek Vasut, linux-kernel, Masahiro Yamada,
Miquel Raynal, Brian Norris
Linux kernel tolerates C++ style comments these days. Actually, the
SPDX License Identifier for .c files uses C++ comment style.
On the other hand, uapi headers are strict, where the C++ comment
style is banned.
Looks like these lines are temporarily commented out, so I did not
use the block comment style.
Having said that, they have been commented out since the pre-git era.
(so, at least 14 years). 'Maybe later' may not happen. Alternative fix
might be to delete these lines entirely.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
include/uapi/linux/jffs2.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/jffs2.h b/include/uapi/linux/jffs2.h
index a18b719f49d4..5dee6d930d5b 100644
--- a/include/uapi/linux/jffs2.h
+++ b/include/uapi/linux/jffs2.h
@@ -77,10 +77,10 @@
#define JFFS2_ACL_VERSION 0x0001
-// Maybe later...
-//#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3)
-//#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4)
-
+/* Maybe later...
+#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3)
+#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4)
+*/
#define JFFS2_INO_FLAG_PREREAD 1 /* Do read_inode() for this one at
mount time, don't wait for it to
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jffs2: do not use C++ style comments in uapi header
2019-06-03 16:50 [PATCH] jffs2: do not use C++ style comments in uapi header Masahiro Yamada
@ 2019-06-17 8:14 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2019-06-17 8:14 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel,
Marek Vasut, linux-mtd, Brian Norris, David Woodhouse
Hi Masahiro,
Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Tue, 4 Jun
2019 01:50:27 +0900:
> Linux kernel tolerates C++ style comments these days. Actually, the
> SPDX License Identifier for .c files uses C++ comment style.
>
> On the other hand, uapi headers are strict, where the C++ comment
> style is banned.
>
> Looks like these lines are temporarily commented out, so I did not
> use the block comment style.
>
> Having said that, they have been commented out since the pre-git era.
> (so, at least 14 years). 'Maybe later' may not happen. Alternative fix
> might be to delete these lines entirely.
Richard's POV on the question would be interesting but mine would be to
simple drop these lines.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> include/uapi/linux/jffs2.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/uapi/linux/jffs2.h b/include/uapi/linux/jffs2.h
> index a18b719f49d4..5dee6d930d5b 100644
> --- a/include/uapi/linux/jffs2.h
> +++ b/include/uapi/linux/jffs2.h
> @@ -77,10 +77,10 @@
>
> #define JFFS2_ACL_VERSION 0x0001
>
> -// Maybe later...
> -//#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3)
> -//#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4)
> -
> +/* Maybe later...
> +#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3)
> +#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4)
> +*/
>
> #define JFFS2_INO_FLAG_PREREAD 1 /* Do read_inode() for this one at
> mount time, don't wait for it to
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-17 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 16:50 [PATCH] jffs2: do not use C++ style comments in uapi header Masahiro Yamada
2019-06-17 8:14 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).