Re: [PATCH 7/7] ubifs: Add quota support

From: kbuild test robot <lkp@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
	kbuild-all@lists.01.org, Richard Weinberger <richard@nod.at>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/7] ubifs: Add quota support
Date: Fri, 8 Nov 2019 22:47:37 +0800	[thread overview]
Message-ID: <201911082236.nb3ky0Pw%lkp@intel.com> (raw)
In-Reply-To: <20191106091537.32480-8-s.hauer@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

Hi Sascha,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20191108-215456
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/ubifs/quota.c: In function 'ubifs_enable_quotas':
>> fs/ubifs/quota.c:509:9: error: implicit declaration of function 'dquot_load_quota_sb'; did you mean 'dquot_quota_on'? [-Werror=implicit-function-declaration]
      ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
            ^~~~~~~~~~~~~~~~~~~
            dquot_quota_on
   cc1: some warnings being treated as errors

vim +509 fs/ubifs/quota.c

   487	
   488	/**
   489	 * ubifs_enable_quotas - enable quota
   490	 * @c: UBIFS file-system description object
   491	 *
   492	 * Enable usage tracking for all quota types.
   493	 */
   494	int ubifs_enable_quotas(struct ubifs_info *c)
   495	{
   496		struct super_block *sb = c->vfs_sb;
   497		struct quota_info *dqopt = sb_dqopt(sb);
   498		int type, ret;
   499	
   500		if (!c->quota_enable)
   501			return 0;
   502	
   503		dqopt->flags |= DQUOT_QUOTA_SYS_FILE | DQUOT_NOLIST_DIRTY;
   504	
   505		for (type = 0; type < UBIFS_MAXQUOTAS; type++) {
   506			if (!(c->quota_enable & (1 << type)))
   507				continue;
   508	
 > 509			ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
   510					   DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);
   511			if (ret)
   512				goto out_quota_off;
   513	
   514			c->dqblk_tree[type] = RB_ROOT;
   515		}
   516	
   517		return ubifs_quota_walk_index(c);
   518	
   519	out_quota_off:
   520		ubifs_disable_quotas(c);
   521	
   522		return ret;
   523	}
   524	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50147 bytes --]

[-- Attachment #3: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/