From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Han Xu <xhnjupt@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Esben Haabendal <esben@geanix.com>,
sean@geanix.com, Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
martin@geanix.com, Han Xu <han.xu@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 1/2] mtd: rawnand: gpmi: Fix suspend/resume problem
Date: Thu, 9 Jan 2020 16:15:12 +0100 [thread overview]
Message-ID: <20200109161512.2742730d@xps13> (raw)
In-Reply-To: <CA+EcR21F1u4dX6NEO9Zfur=ZA7btr51EthZurEjzPHSuWu-0PQ@mail.gmail.com>
Hi Han,
Han Xu <xhnjupt@gmail.com> wrote on Tue, 7 Jan 2020 13:31:27 -0600:
> On Thu, Jan 2, 2020 at 7:09 AM Esben Haabendal <esben@geanix.com> wrote:
> >
> > On system resume, the gpmi clock must be enabled before accessing gpmi
> > block. Without this, resume causes something like
> >
> > [ 661.348790] gpmi_reset_block(5cbb0f7e): module reset timeout
> > [ 661.348889] gpmi-nand 1806000.gpmi-nand: Error setting GPMI : -110
> > [ 661.348928] PM: dpm_run_callback(): platform_pm_resume+0x0/0x44 returns -110
> > [ 661.348961] PM: Device 1806000.gpmi-nand failed to resume: error -110
> >
> > Signed-off-by: Esben Haabendal <esben@geanix.com>
> > ---
> > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > index 334fe3130285..7ac8c8b95afc 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > @@ -148,6 +148,10 @@ static int gpmi_init(struct gpmi_nand_data *this)
> > struct resources *r = &this->resources;
> > int ret;
> >
> > + ret = pm_runtime_get_sync(this->dev);
> > + if (ret < 0)
> > + return ret;
> > +
> > ret = gpmi_reset_block(r->gpmi_regs, false);
> > if (ret)
> > goto err_out;
> > @@ -181,6 +185,8 @@ static int gpmi_init(struct gpmi_nand_data *this)
> >
> > return 0;
> > err_out:
> > + pm_runtime_mark_last_busy(this->dev);
> > + pm_runtime_put_autosuspend(this->dev);
> > return ret;
> > }
>
> I have a similar patch with more fixes, will send out tonight for review.
What should I do with this patch? It seems okay to me, what is your
plan? May I take this one for this release and you'll build above with
your series, is this fine for you?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-09 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:08 [PATCH 1/2] mtd: rawnand: gpmi: Fix suspend/resume problem Esben Haabendal
2020-01-02 13:08 ` [PATCH 2/2] mtd: rawnand: gpmi: Restore nfc timing setup after suspend/resume Esben Haabendal
2020-01-13 17:34 ` Han Xu
2020-01-14 17:03 ` Miquel Raynal
2020-01-07 19:31 ` [PATCH 1/2] mtd: rawnand: gpmi: Fix suspend/resume problem Han Xu
2020-01-09 15:15 ` Miquel Raynal [this message]
2020-01-09 17:11 ` Han Xu
2020-01-13 17:32 ` Han Xu
2020-01-14 17:03 ` Miquel Raynal
2020-01-14 17:09 ` Fabio Estevam
2020-01-14 17:25 ` Miquel Raynal
2020-01-14 17:29 ` Fabio Estevam
2020-01-15 7:46 ` Sascha Hauer
2020-01-15 8:46 ` Miquel Raynal
2020-01-17 19:48 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109161512.2742730d@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=esben@geanix.com \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=martin@geanix.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=sean@geanix.com \
--cc=vigneshr@ti.com \
--cc=xhnjupt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).