From: Rob Herring <robh@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: devicetree@vger.kernel.org,
Chris Brandt <chris.brandt@renesas.com>,
Mason Yang <masonccyang@mxic.com.tw>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: memory: document Renesas RPC-IF bindings
Date: Fri, 1 May 2020 16:25:48 -0500 [thread overview]
Message-ID: <20200501212547.GB15294@bogus> (raw)
In-Reply-To: <116683d1-d402-4d7f-3357-1c8cde807076@cogentembedded.com>
On Thu, Apr 30, 2020 at 11:47:25PM +0300, Sergei Shtylyov wrote:
> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
> HyperFlash connected to the SoC to be accessed via the external address
> space read mode or the manual mode.
>
> Document the device tree bindings for the Renesas RPC-IF found in the R-Car
> gen3 SoCs.
>
> Based on the original patch by Mason Yang <masonccyang@mxic.com.tw>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes in version 2:
> - rewrote the bindings in YAML.
>
> Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml | 88 ++++++++++
Not where we normally put SPI flash controllers...
> 1 file changed, 88 insertions(+)
>
> Index: linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> ===================================================================
> --- /dev/null
> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0)
Dual license new bindings:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/renesas,rpc-if.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas Reduced Pin Count Interface (RPC-IF)
> +
> +maintainers:
> + - Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> +
> +description: |
> + Renesas RPC-IF allows a SPI flash or HyperFlash connected to the SoC to
> + be accessed via the external address space read mode or the manual mode.
> +
> + The flash chip itself should be represented by a subnode of the RPC-IF node.
> + The flash interface is selected based on the "compatible" property of this
> + subnode:
> + - if it contains "jedec,spi-nor", then SPI is used;
> + - if it contains "cfi-flash", then HyperFlash is used.
> +
> +allOf:
> + - $ref: "/schemas/spi/spi-controller.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + renesas,r8a77980-rpc-if # device is a part of R8A77980 SoC
> + renesas,r8a77995-rpc-if # device is a part of R8A77995 SoC
Not valid yaml with tab and not valid json-schema as 'enum' is a list
(needs '-').
> + - enum:
> + renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
> +
> + reg:
> + items:
> + - description: RPC-IF registers
> + - description: direct mapping read mode area
> + - description: write buffer area
Wrong indentation.
> +
> + reg-names:
> + items:
> + - const: regs
> + - const: dirmap
> + - const: wbuf
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +patternProperties:
> + "^.*@[0-9a-f]+$":
^flash@... if you're that restrictive.
> + type: object
> + properties:
> + compatible:
> + oneOf:
> + - const: cfi-flash
> + - const: jedec,spi-nor
enum is better than oneOf+const.
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a77995-sysc.h>
> +
> + spi@ee200000 {
> + compatible = "renesas,r8a77995-rpc-if", "renesas,rcar-gen3-rpc-if";
> + reg = <0 0xee200000 0 0x200>,
> + <0 0x08000000 0 0x4000000>,
> + <0 0xee208000 0 0x100>;
> + reg-names = "regs", "dirmap", "wbuf";
> + clocks = <&cpg CPG_MOD 917>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 917>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + spi-tx-bus-width = <1>;
> + spi-rx-bus-width = <1>;
> + };
> + };
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-01 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:45 [PATCH v2 0/2] Add Renesas RPC-IF support Sergei Shtylyov
2020-04-30 20:47 ` [PATCH v2 1/2] dt-bindings: memory: document Renesas RPC-IF bindings Sergei Shtylyov
2020-05-01 21:19 ` Rob Herring
2020-05-15 20:16 ` Sergei Shtylyov
2020-05-01 21:25 ` Rob Herring [this message]
2020-05-20 14:38 ` Sergei Shtylyov
2020-06-01 19:18 ` Sergei Shtylyov
2020-04-30 20:50 ` [PATCH v2 2/2] memory: add Renesas RPC-IF driver Sergei Shtylyov
2020-05-01 9:36 ` [PATCH v2 0/2] Add Renesas RPC-IF support Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501212547.GB15294@bogus \
--to=robh@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).