From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Rickard Andersson <rickaran@axis.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH v5 21/28] mtd: rawnand: Introduce nand_choose_best_sdr_timings()
Date: Tue, 26 May 2020 23:50:03 +0200 [thread overview]
Message-ID: <20200526235003.5bb0ba91@collabora.com> (raw)
In-Reply-To: <20200526191725.7591-22-miquel.raynal@bootlin.com>
On Tue, 26 May 2020 21:17:18 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Extract the logic out of nand_choose_data_interface() to create a
> public helper that can be reused by manufacturer drivers. Add the
> possibility to provide a specific set of timings.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/nand/raw/internals.h | 3 +
> drivers/mtd/nand/raw/nand_base.c | 104 +++++++++++++++++++------------
> 2 files changed, 66 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
> index c7357ae86eeb..5c49c4d1e231 100644
> --- a/drivers/mtd/nand/raw/internals.h
> +++ b/drivers/mtd/nand/raw/internals.h
> @@ -90,6 +90,9 @@ int onfi_fill_data_interface(struct nand_chip *chip,
> int timing_mode);
> unsigned int
> onfi_find_closest_sdr_mode(const struct nand_sdr_timings *spec_timings);
> +int nand_choose_best_sdr_timings(struct nand_chip *chip,
> + struct nand_data_interface *iface,
> + struct nand_sdr_timings *spec_timings);
> int nand_get_features(struct nand_chip *chip, int addr, u8 *subfeature_param);
> int nand_set_features(struct nand_chip *chip, int addr, u8 *subfeature_param);
> int nand_read_page_raw_notsupp(struct nand_chip *chip, u8 *buf,
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 6a7edd2e1357..b2e833a8ab9d 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -1003,61 +1003,83 @@ static int nand_setup_data_interface(struct nand_chip *chip, int chipnr)
> return ret;
> }
>
> +/**
> + * nand_choose_best_sdr_timings - Pick up the best SDR timings that both the
> + * NAND controller and the NAND chip support
> + * @chip: the NAND chip
> + * @iface: the data interface (can eventually be updated)
> + * @spec_timings: specific timings, when not fitting the ONFI specification
> + *
> + * If specific timings are provided, use them. Otherwise, try to retrieve
> + * supported timing modes from ONFI information. Finally, if the NAND chip does
> + * not follow the ONFI specification, rely on the ->default_timing_mode
> + * specified in the nand_ids table.
> + */
> +int nand_choose_best_sdr_timings(struct nand_chip *chip,
> + struct nand_data_interface *iface,
> + struct nand_sdr_timings *spec_timings)
> +{
> + const struct nand_controller_ops *ops = chip->controller->ops;
> + int best_mode = 0, onfi_modes, mode, ret;
> +
> + iface->type = NAND_SDR_IFACE;
> +
> + if (spec_timings) {
> + iface->timings.sdr = *spec_timings;
> + iface->timings.mode = onfi_find_closest_sdr_mode(spec_timings);
> +
> + /* Verify the controller supports the requested interface */
> + ret = ops->setup_data_interface(chip,
> + NAND_DATA_IFACE_CHECK_ONLY,
> + iface);
> + if (!ret)
> + return ret;
> +
> + /* Fallback to slower modes */
> + best_mode = iface->timings.mode;
> + } else {
> + if (chip->parameters.onfi) {
onfi_modes var should be declared here.
> + onfi_modes = chip->parameters.onfi->async_timing_mode;
> + best_mode = fls(onfi_modes) - 1;
> + } else {
> + best_mode = chip->onfi_timing_mode_default;
> + }
> + }
> +
> +
> + for (mode = best_mode; mode >= 0; mode--) {
> + ret = onfi_fill_data_interface(chip, iface, NAND_SDR_IFACE,
> + mode);
> + if (ret)
> + continue;
In practice onfi_fill_data_interface() will only return an error if you
pass a type that's not SDR (not the case here, or a mode that's outside
the SDR mode bounds). Maybe we should just clamp the value/warn when
that happens and make onfi_fill_data_interface() a void function.
> +
> + ret = ops->setup_data_interface(chip,
> + NAND_DATA_IFACE_CHECK_ONLY,
> + iface);
> + if (!ret)
> + break;
return 0;
> + }
> +
> + return 0;
> +}
> +
> /**
> * nand_choose_data_interface - find the best data interface and timings
> * @chip: The NAND chip
> *
> * Find the best data interface and NAND timings supported by the chip
> * and the driver.
> - * First tries to retrieve supported timing modes from ONFI information,
> - * and if the NAND chip does not support ONFI, relies on the
> - * ->onfi_timing_mode_default specified in the nand_ids table. After this
> - * function nand_chip->data_interface is initialized with the best timing mode
> - * available.
> + * After this function nand_chip->data_interface is initialized with the best
> + * timing mode available.
> *
> * Returns 0 for success or negative error code otherwise.
> */
> static int nand_choose_data_interface(struct nand_chip *chip)
> {
> - int modes, mode, ret;
> -
> if (!nand_controller_has_setup_data_iface(chip))
> return 0;
>
> - /*
> - * First try to identify the best timings from ONFI parameters and
> - * if the NAND does not support ONFI, fallback to the default ONFI
> - * timing mode.
> - */
> - if (chip->parameters.onfi) {
> - modes = chip->parameters.onfi->async_timing_mode;
> - } else {
> - if (!chip->onfi_timing_mode_default)
> - return 0;
> -
> - modes = GENMASK(chip->onfi_timing_mode_default, 0);
> - }
> -
> - for (mode = fls(modes) - 1; mode >= 0; mode--) {
> - ret = onfi_fill_data_interface(chip, &chip->data_interface,
> - NAND_SDR_IFACE, mode);
> - if (ret)
> - continue;
> -
> - /*
> - * Pass NAND_DATA_IFACE_CHECK_ONLY to only check if the
> - * controller supports the requested timings.
> - */
> - ret = chip->controller->ops->setup_data_interface(chip,
> - NAND_DATA_IFACE_CHECK_ONLY,
> - &chip->data_interface);
> - if (!ret) {
> - chip->onfi_timing_mode_default = mode;
> - break;
> - }
> - }
> -
> - return 0;
> + return nand_choose_best_sdr_timings(chip, &chip->data_interface, NULL);
> }
>
> /**
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-26 21:50 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 19:16 [PATCH v5 00/28] Allow vendor drivers to propose their own timings Miquel Raynal
2020-05-26 19:16 ` [PATCH v5 01/28] mtd: rawnand: Use unsigned types for nand_chip unsigned values Miquel Raynal
2020-05-26 19:16 ` [PATCH v5 02/28] mtd: rawnand: Only use u8 instead of uint8_t in nand_chip structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 03/28] mtd: rawnand: Create a nand_chip operations structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 04/28] mtd: rawnand: Rename the manufacturer structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 05/28] mtd: rawnand: Declare the nand_manufacturer structure out of nand_chip Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 06/28] mtd: rawnand: Reorganize the nand_chip structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 07/28] mtd: rawnand: Compare the actual timing values Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 08/28] mtd: rawnand: Use the data interface mode entry when relevant Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 09/28] mtd: rawnand: Rename nand_has_setup_data_interface() Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 10/28] mtd: rawnand: Fix nand_setup_data_interface() description Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 11/28] mtd: rawnand: Rename nand_init_data_interface() Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 12/28] mtd: rawnand: timings: Update onfi_fill_data_interface() kernel doc Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 13/28] mtd: rawnand: timings: Provide onfi_fill_data_interface() with a data interface Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 14/28] mtd: rawnand: timings: Add a helper to find the closest ONFI mode Miquel Raynal
2020-05-26 21:42 ` Boris Brezillon
2020-05-27 7:42 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 15/28] mtd: rawnand: timings: Avoid redefining tR_max and tCCS_min Miquel Raynal
2020-05-26 20:33 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 16/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max Miquel Raynal
2020-05-26 20:32 ` Boris Brezillon
2020-05-26 21:25 ` Boris Brezillon
2020-05-27 7:17 ` Miquel Raynal
2020-05-27 7:22 ` Miquel Raynal
2020-05-27 7:28 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 17/28] mtd: rawnand: Define a unique reset data interface Miquel Raynal
2020-05-26 21:23 ` Boris Brezillon
2020-05-27 7:20 ` Miquel Raynal
2020-05-27 8:10 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 18/28] mtd: rawnand: marvell: Use a helper to access the timings Miquel Raynal
2020-05-26 21:26 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 19/28] mtd: rawnand: legacy: " Miquel Raynal
2020-05-26 21:28 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 20/28] mtd: rawnand: Hide the chip->data_interface indirection Miquel Raynal
2020-05-26 21:36 ` Boris Brezillon
2020-05-27 7:36 ` Miquel Raynal
2020-05-27 8:14 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 21/28] mtd: rawnand: Introduce nand_choose_best_sdr_timings() Miquel Raynal
2020-05-26 21:50 ` Boris Brezillon [this message]
2020-05-27 7:45 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 22/28] mtd: rawnand: Add the ->choose_data_interface() hook Miquel Raynal
2020-05-26 21:52 ` Boris Brezillon
2020-05-27 7:46 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 23/28] mtd: rawnand: toshiba: Implement ->choose_data_interface() for TC58TEG5DCLTA00 Miquel Raynal
2020-05-26 21:54 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 24/28] mtd: rawnand: toshiba: Implement ->choose_data_interface() for TC58NVG0S3E Miquel Raynal
2020-05-26 22:02 ` Boris Brezillon
2020-05-27 7:47 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 25/28] mtd: rawnand: hynix: Implement ->choose_data_interface() for H27UCG8T2ATR-BC Miquel Raynal
2020-05-26 22:06 ` Boris Brezillon
2020-05-27 7:50 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 26/28] mtd: rawnand: toshiba: Choose the data interface for TH58NVG2S3HBAI4 Miquel Raynal
2020-05-26 22:10 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 27/28] mtd: rawnand: Get rid of the default ONFI timing mode Miquel Raynal
2020-05-26 22:13 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 28/28] mtd: rawnand: Allocate the best data interface structure dynamically Miquel Raynal
2020-05-26 22:28 ` Boris Brezillon
2020-05-27 7:57 ` Miquel Raynal
2020-05-27 8:35 ` Boris Brezillon
2020-05-27 8:49 ` Miquel Raynal
2020-05-27 8:57 ` Boris Brezillon
2020-05-27 9:34 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526235003.5bb0ba91@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rickaran@axis.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).