[PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

[PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

[Matthias Schiffer]

From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>

Set SPI_NOR_4B_OPCODES, as the flash supports 4-byte opcodes.

Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 drivers/mtd/spi-nor/micron-st.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c
index 3dca5b9af3b6..8edfde053f31 100644
--- a/drivers/mtd/spi-nor/micron-st.c
+++ b/drivers/mtd/spi-nor/micron-st.c
@@ -58,7 +58,8 @@ static const struct flash_info st_parts[] = {
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024,
 			      SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
 			      SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
-			      SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6) },
+			      SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6 |
+			      SPI_NOR_4B_OPCODES) },
 	{ "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048,
 			      SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
 			      SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

[Tudor.Ambarus]

Hi, Matthias,

On 6/10/20 12:16 PM, Matthias Schiffer wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> 
> Set SPI_NOR_4B_OPCODES, as the flash supports 4-byte opcodes.

I remember that we stripped SPI_NOR_4B_OPCODES intentionally for the n25q
flashes, check  https://lkml.org/lkml/2019/12/5/50.

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: (EXT) Re: [PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a

[Matthias Schiffer]

On Mon, 2020-06-29 at 13:02 +0000, Tudor.Ambarus@microchip.com wrote:
> Hi, Matthias,
> 
> On 6/10/20 12:16 PM, Matthias Schiffer wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> > 
> > From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> > 
> > Set SPI_NOR_4B_OPCODES, as the flash supports 4-byte opcodes.
> 
> I remember that we stripped SPI_NOR_4B_OPCODES intentionally for the
> n25q
> flashes, check  https://lkml.org/lkml/2019/12/5/50.
> 
> Cheers,
> ta

Ah, thank you for the pointer. Looking at a boot log of a more recent
kernel again, the SPI-NOR flash on our hardware is actually detected as
mt25qu512a and not n25q512a now, so everything should work as expected
without this patch.



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/