* [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static
@ 2020-07-21 15:16 Wei Yongjun
2020-09-07 7:22 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-21 15:16 UTC (permalink / raw)
To: Hulk Robot, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, Wei Yongjun, linux-kernel
The sparse tool complains as follows:
drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning:
symbol 'pasemi_device_ready' was not declared. Should it be static?
This function is not used outside of pasemi_nand.c, so this commit
marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/nand/raw/pasemi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c
index d8eca8c3fdcd..81e2e667037e 100644
--- a/drivers/mtd/nand/raw/pasemi_nand.c
+++ b/drivers/mtd/nand/raw/pasemi_nand.c
@@ -68,7 +68,7 @@ static void pasemi_hwcontrol(struct nand_chip *chip, int cmd,
inl(lpcctl);
}
-int pasemi_device_ready(struct nand_chip *chip)
+static int pasemi_device_ready(struct nand_chip *chip)
{
return !!(inl(lpcctl) & LBICTRL_LPCCTL_NR);
}
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static
2020-07-21 15:16 [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static Wei Yongjun
@ 2020-09-07 7:22 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2020-09-07 7:22 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Cc: linux-mtd, linux-kernel
On Tue, 2020-07-21 at 15:16:57 UTC, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning:
> symbol 'pasemi_device_ready' was not declared. Should it be static?
>
> This function is not used outside of pasemi_nand.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 15:16 [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static Wei Yongjun
2020-09-07 7:22 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).