From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, entwicklung@pengutronix.de
Subject: Re: [PATCH mtd-utils RFC] Add an ubifs mount helper
Date: Mon, 16 Nov 2020 10:39:35 +0100 [thread overview]
Message-ID: <20201116093935.zhf4bgiwggwrnnl2@pengutronix.de> (raw)
In-Reply-To: <20201006091912.1139071-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1847 bytes --]
Hello,
On Tue, Oct 06, 2020 at 11:19:13AM +0200, Uwe Kleine-König wrote:
> This abstracts away attaching of the right ubi and then selecting the right
> ubi device and volume to mount.
>
> As described in the comment at the top this allows to mount ubifs volumes
> directly from /etc/fstab without having to use hardcoded numbers (which
> depend on mount order and so are unreliable) and extra magic to care for
> attaching.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this is a nice script that helps attaching ubis and mounting ubifs'. I
> already discussed this a bit with Richard on irc and the idea was
> welcome in principle.
>
> A concern was that the entry in /etc/fstab is too magic and there should
> be an indication that this relies on the mount helper. Something like
> using ubifs.autoattach as file system type (fs_vfstype) or requiring
> "autoattach" in the fourth field (fs_mntops).
>
> Having thought a bit I'm not convinced we need this indication. Yes
> there is magic but nothing out of the ordinary as mount helpers are a
> known concept and the fs_spec already looks interesting enough to make
> it obvious there is something going on. And once people are used to the
> magic it is annoying to have to always write this indication in your
> fstab. Additionally it complicates the implementation.
>
> Also "autoattach" doesn't completely cover the script as it does a
> translation from mtd name to mtd number, too. "autoattach,mtdtranslate"
> seems a bit excessive.
I didn't hear any feedback here. Is reviewing this patch still on
somebody's todo list?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-11-16 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 9:19 [PATCH mtd-utils RFC] Add an ubifs mount helper Uwe Kleine-König
2020-11-16 9:39 ` Uwe Kleine-König [this message]
2020-11-18 14:43 ` David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116093935.zhf4bgiwggwrnnl2@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=david.oberhollenzer@sigma-star.at \
--cc=entwicklung@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).