* [PATCH] mtd: rawnand: r852: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2021-03-15 1:08 Tian Tao
2021-03-28 17:14 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-03-15 1:08 UTC (permalink / raw)
To: maximlevitsky, miquel.raynal, vigneshr; +Cc: linux-mtd
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/mtd/nand/raw/r852.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/r852.c b/drivers/mtd/nand/raw/r852.c
index c742354..ebe859c 100644
--- a/drivers/mtd/nand/raw/r852.c
+++ b/drivers/mtd/nand/raw/r852.c
@@ -724,10 +724,9 @@ static irqreturn_t r852_irq(int irq, void *data)
struct r852_device *dev = (struct r852_device *)data;
uint8_t card_status, dma_status;
- unsigned long flags;
irqreturn_t ret = IRQ_NONE;
- spin_lock_irqsave(&dev->irqlock, flags);
+ spin_lock(&dev->irqlock);
/* handle card detection interrupts first */
card_status = r852_read_reg(dev, R852_CARD_IRQ_STA);
@@ -813,7 +812,7 @@ static irqreturn_t r852_irq(int irq, void *data)
dbg("strange card status = %x", card_status);
out:
- spin_unlock_irqrestore(&dev->irqlock, flags);
+ spin_unlock(&dev->irqlock);
return ret;
}
--
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: r852: replace spin_lock_irqsave by spin_lock in hard IRQ
2021-03-15 1:08 [PATCH] mtd: rawnand: r852: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
@ 2021-03-28 17:14 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2021-03-28 17:14 UTC (permalink / raw)
To: Tian Tao, maximlevitsky, miquel.raynal, vigneshr; +Cc: linux-mtd
On Mon, 2021-03-15 at 01:08:15 UTC, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 1:08 [PATCH] mtd: rawnand: r852: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2021-03-28 17:14 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).