* [PATCH RESEND -next] mtd: rawnand: Remove redundant dev_err call in hisi_nfc_probe()
@ 2021-04-07 10:05 Wei Li
2021-05-10 9:10 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Wei Li @ 2021-04-07 10:05 UTC (permalink / raw)
To: huawei.libin, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Boris Brezillon
Cc: linux-mtd, linux-kernel, kernel-janitors, Hulk Robot, Wei Li
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
---
drivers/mtd/nand/raw/hisi504_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/hisi504_nand.c b/drivers/mtd/nand/raw/hisi504_nand.c
index 8b2122ce6ec3..78c4e05434e2 100644
--- a/drivers/mtd/nand/raw/hisi504_nand.c
+++ b/drivers/mtd/nand/raw/hisi504_nand.c
@@ -761,10 +761,8 @@ static int hisi_nfc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
host->mmio = devm_ioremap_resource(dev, res);
- if (IS_ERR(host->mmio)) {
- dev_err(dev, "devm_ioremap_resource[1] fail\n");
+ if (IS_ERR(host->mmio))
return PTR_ERR(host->mmio);
- }
mtd->name = "hisi_nand";
mtd->dev.parent = &pdev->dev;
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND -next] mtd: rawnand: Remove redundant dev_err call in hisi_nfc_probe()
2021-04-07 10:05 [PATCH RESEND -next] mtd: rawnand: Remove redundant dev_err call in hisi_nfc_probe() Wei Li
@ 2021-05-10 9:10 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2021-05-10 9:10 UTC (permalink / raw)
To: Wei Li, huawei.libin, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Boris Brezillon
Cc: linux-mtd, linux-kernel, kernel-janitors, Hulk Robot
On Wed, 2021-04-07 at 10:05:26 UTC, Wei Li wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Li <liwei391@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 10:05 [PATCH RESEND -next] mtd: rawnand: Remove redundant dev_err call in hisi_nfc_probe() Wei Li
2021-05-10 9:10 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).