[PATCH] Revert "mtd: rawnand: bbt: Skip bad blocks when searching for the BBT in NAND"

[PATCH] Revert "mtd: rawnand: bbt: Skip bad blocks when searching for the BBT in NAND"

[Fabio Estevam]

This reverts commit bd9c9fe2ad04546940f4a9979d679e62cae6aa51.

Since commit bd9c9fe2ad04 ("mtd: rawnand: bbt: Skip bad blocks when
searching for  the BBT in NAND") the bad block table cannot be found
on a imx27-phytec-phycard-s-rdk board:

Bad block table not found for chip 0
Bad block table not found for chip 0

Revert it for now, until a better solution can be found.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/mtd/nand/raw/nand_bbt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_bbt.c b/drivers/mtd/nand/raw/nand_bbt.c
index 6e25a5ce5ba9..dced32a126d9 100644
--- a/drivers/mtd/nand/raw/nand_bbt.c
+++ b/drivers/mtd/nand/raw/nand_bbt.c
@@ -525,7 +525,6 @@ static int search_bbt(struct nand_chip *this, uint8_t *buf,
 {
 	u64 targetsize = nanddev_target_size(&this->base);
 	struct mtd_info *mtd = nand_to_mtd(this);
-	struct nand_bbt_descr *bd = this->badblock_pattern;
 	int i, chips;
 	int startblock, block, dir;
 	int scanlen = mtd->writesize + mtd->oobsize;
@@ -561,10 +560,6 @@ static int search_bbt(struct nand_chip *this, uint8_t *buf,
 			int actblock = startblock + dir * block;
 			loff_t offs = (loff_t)actblock << this->bbt_erase_shift;
 
-			/* Check if block is marked bad */
-			if (scan_block_fast(this, bd, offs, buf))
-				continue;
-
 			/* Read first page */
 			scan_read(this, buf, offs, mtd->writesize, td);
 			if (!check_pattern(buf, scanlen, mtd->writesize, td)) {
-- 
2.25.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] Revert "mtd: rawnand: bbt: Skip bad blocks when searching for the BBT in NAND"

[Miquel Raynal]

On Mon, 2021-04-19 at 14:03:50 UTC, Fabio Estevam wrote:
> This reverts commit bd9c9fe2ad04546940f4a9979d679e62cae6aa51.
> 
> Since commit bd9c9fe2ad04 ("mtd: rawnand: bbt: Skip bad blocks when
> searching for  the BBT in NAND") the bad block table cannot be found
> on a imx27-phytec-phycard-s-rdk board:
> 
> Bad block table not found for chip 0
> Bad block table not found for chip 0
> 
> Revert it for now, until a better solution can be found.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/