From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
<linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
helmut.grohne@intenta.de, Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v22 11/18] memory: pl353-smc: Rename goto labels
Date: Wed, 9 Jun 2021 10:01:05 +0200 [thread overview]
Message-ID: <20210609080112.1753221-12-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20210609080112.1753221-1-miquel.raynal@bootlin.com>
A goto label is better named
do_something:
than
out_something_to_do:
Use the former wording and really describe what the jump involves.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/memory/pl353-smc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index 2d20b1b2c0e3..14720430bf9e 100644
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -388,7 +388,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
err = clk_prepare_enable(pl353_smc->memclk);
if (err) {
dev_err(&adev->dev, "Unable to enable memory clock.\n");
- goto out_clk_dis_aper;
+ goto disable_axi_clk;
}
amba_set_drvdata(adev, pl353_smc);
@@ -408,7 +408,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
}
if (!match) {
dev_err(&adev->dev, "no matching children\n");
- goto out_clk_disable;
+ goto disable_mem_clk;
}
init = match->data;
@@ -418,9 +418,9 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
return 0;
-out_clk_disable:
+disable_mem_clk:
clk_disable_unprepare(pl353_smc->memclk);
-out_clk_dis_aper:
+disable_axi_clk:
clk_disable_unprepare(pl353_smc->aclk);
return err;
--
2.27.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-09 8:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 8:00 [PATCH v22 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-09 12:12 ` Krzysztof Kozlowski
2021-06-09 13:34 ` Miquel Raynal
2021-06-09 13:54 ` Krzysztof Kozlowski
2021-06-09 14:11 ` Miquel Raynal
2021-06-09 15:26 ` Krzysztof Kozlowski
2021-06-09 19:26 ` Rob Herring
2021-06-09 19:35 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-09 8:01 ` Miquel Raynal [this message]
2021-06-09 8:01 ` [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-09 11:54 ` Krzysztof Kozlowski
2021-06-09 11:57 ` Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-09 13:23 ` Krzysztof Kozlowski
2021-06-09 13:41 ` Miquel Raynal
2021-06-10 7:04 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-10 7:05 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-09 12:01 ` Krzysztof Kozlowski
2021-06-09 13:36 ` Miquel Raynal
2021-06-09 13:57 ` Krzysztof Kozlowski
2021-06-10 2:32 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 19:36 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609080112.1753221-12-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=akumarma@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=helmut.grohne@intenta.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=sivadur@xilinx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).