From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits
Date: Wed, 9 Jun 2021 13:54:24 +0200 [thread overview]
Message-ID: <b9be2ca0-7d62-c5fd-6aa8-e04c57b0f75c@canonical.com> (raw)
In-Reply-To: <20210609080112.1753221-13-miquel.raynal@bootlin.com>
On 09/06/2021 10:01, Miquel Raynal wrote:
> There is no point in having all these definitions at the SMC bus level,
> these are extremely tight to the NAND controller driver implementation,
> are not particularly generic, imply more boilerplate than needed, do
> not really follow the device model by receiving no argument and some of
> them are actually buggy.
>
> Let's get rid of these right now as there is no current user and keep
> this driver at a simple level: only the SMC bare initializations.
>
> The NAND controller driver which I am going to introduce will take care
> of redefining properly all these helpers and using them directly.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/memory/pl353-smc.c | 294 -------------------------------------
> include/linux/pl353-smc.h | 30 ----
> 2 files changed, 324 deletions(-)
> delete mode 100644 include/linux/pl353-smc.h
>
I see you remove here a bunch of code. Are the series still fully
bisectable?
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-09 12:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 8:00 [PATCH v22 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-09 12:12 ` Krzysztof Kozlowski
2021-06-09 13:34 ` Miquel Raynal
2021-06-09 13:54 ` Krzysztof Kozlowski
2021-06-09 14:11 ` Miquel Raynal
2021-06-09 15:26 ` Krzysztof Kozlowski
2021-06-09 19:26 ` Rob Herring
2021-06-09 19:35 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 11/18] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-09 11:54 ` Krzysztof Kozlowski [this message]
2021-06-09 11:57 ` Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-09 13:23 ` Krzysztof Kozlowski
2021-06-09 13:41 ` Miquel Raynal
2021-06-10 7:04 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-10 7:05 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-09 12:01 ` Krzysztof Kozlowski
2021-06-09 13:36 ` Miquel Raynal
2021-06-09 13:57 ` Krzysztof Kozlowski
2021-06-10 2:32 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 19:36 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9be2ca0-7d62-c5fd-6aa8-e04c57b0f75c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=akumarma@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=helmut.grohne@intenta.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=sivadur@xilinx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).