* [PATCH] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare()
@ 2021-07-09 9:35 Evgeny Novikov
2021-07-09 10:19 ` Pratyush Yadav
0 siblings, 1 reply; 2+ messages in thread
From: Evgeny Novikov @ 2021-07-09 9:35 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Evgeny Novikov, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Lee Jones, Pan Bian,
linux-mtd, linux-kernel, ldv-project
hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after
successful call of clk_prepare_enable(), so, there is no need in one
more clk_disable_unprepare() in hisi_spi_nor_remove(). The patch fixes
that.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/controllers/hisi-sfc.c b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
index 47fbf1d1e557..516e50269478 100644
--- a/drivers/mtd/spi-nor/controllers/hisi-sfc.c
+++ b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
@@ -477,7 +477,6 @@ static int hisi_spi_nor_remove(struct platform_device *pdev)
hisi_spi_nor_unregister_all(host);
mutex_destroy(&host->lock);
- clk_disable_unprepare(host->clk);
return 0;
}
--
2.26.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare()
2021-07-09 9:35 [PATCH] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare() Evgeny Novikov
@ 2021-07-09 10:19 ` Pratyush Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Pratyush Yadav @ 2021-07-09 10:19 UTC (permalink / raw)
To: Evgeny Novikov
Cc: Tudor Ambarus, Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Lee Jones, Pan Bian, linux-mtd,
linux-kernel, ldv-project
On 09/07/21 12:35PM, Evgeny Novikov wrote:
> hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after
> successful call of clk_prepare_enable(), so, there is no need in one
> more clk_disable_unprepare() in hisi_spi_nor_remove(). The patch fixes
> that.
This is true, but I think the patch should also mention that the clock
is enabled by hispi_spi_nor_prep() and disabled by
hispi_spi_nor_unprep(). So at remove time it is not possible to have the
clock enabled.
The big point is not that the probe disabled the clock, but that every
path would make sure to disable the clock, so it will already be
disabled when remove is called.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
Fixes tag?
With these comments addressed,
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> ---
> drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/hisi-sfc.c b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> index 47fbf1d1e557..516e50269478 100644
> --- a/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> +++ b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> @@ -477,7 +477,6 @@ static int hisi_spi_nor_remove(struct platform_device *pdev)
>
> hisi_spi_nor_unregister_all(host);
> mutex_destroy(&host->lock);
> - clk_disable_unprepare(host->clk);
> return 0;
> }
>
> --
> 2.26.2
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-09 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 9:35 [PATCH] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare() Evgeny Novikov
2021-07-09 10:19 ` Pratyush Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).