From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Wolfram Sang <wsa@kernel.org>,
dri-devel@lists.freedesktop.org, linux-serial@vger.kernel.org,
linux-pm@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-crypto@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-watchdog@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-iio@vger.kernel.org,
linux-rtc@vger.kernel.org, netdev@vger.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
chrome-platform@lists.linux.dev, linux-input@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
linux-hwmon@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
linux-fbdev@vger.kernel.org, patches@opensource.cirrus.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pwm@vger.kernel.org, linux-mediatek@lists.infradead.org,
kasan-dev@googlegroups.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void
Date: Wed, 29 Jun 2022 09:23:04 +0200 [thread overview]
Message-ID: <20220629072304.qazmloqdi5h5kdre@pengutronix.de> (raw)
In-Reply-To: <60cc6796236f23c028a9ae76dbe00d1917df82a5.camel@codeconstruct.com.au>
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
Hello,
[I dropped nearly all individuals from the Cc: list because various
bounces reported to be unhappy about the long (logical) line.]
On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote:
> Looks good - just one minor change for the mctp-i2c driver, but only
> worthwhile if you end up re-rolling this series for other reasons:
>
> > -static int mctp_i2c_remove(struct i2c_client *client)
> > +static void mctp_i2c_remove(struct i2c_client *client)
> > {
> > struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
> > struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> > @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
> > mctp_i2c_free_client(mcli);
> > mutex_unlock(&driver_clients_lock);
> > /* Callers ignore return code */
> > - return 0;
> > }
>
> The comment there no longer makes much sense, I'd suggest removing that
> too.
Yeah, that was already pointed out to me in a private reply. It's
already fixed in
https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-void
> Either way:
>
> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Added to my tree, too.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-06-29 7:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:03 [PATCH 0/6] i2c: Make remove callback return void Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 6/6] " Uwe Kleine-König
2022-06-29 6:56 ` Peter Senna Tschudin
2022-06-29 7:03 ` Jeremy Kerr
2022-06-29 7:23 ` Uwe Kleine-König [this message]
2022-06-29 7:37 ` Javier Martinez Canillas
2022-06-29 7:55 ` Christophe Leroy
2022-06-29 8:09 ` Javier Martinez Canillas
2022-06-29 7:21 ` Benjamin Mugnier
2022-06-29 7:24 ` Crt Mori
2022-06-29 7:43 ` Uwe Kleine-König
2022-06-29 7:27 ` Benjamin Mugnier
2022-06-29 9:05 ` Greg Kroah-Hartman
2022-06-29 9:20 ` Marek Behún
2022-06-29 10:40 ` Andy Shevchenko
2022-06-29 13:11 ` Andrey Ryabinin
2022-06-29 13:35 ` Uwe Kleine-König
2022-06-29 14:25 ` Maximilian Luz
2022-06-29 14:31 ` srinivas pandruvada
2022-06-29 14:41 ` Hans Verkuil
2022-06-29 14:50 ` Miguel Ojeda
2022-06-29 21:20 ` Luca Ceresoli
2022-07-01 17:00 ` Jonathan Cameron
2022-07-01 18:18 ` Peter Rosin
2022-07-05 10:08 ` Jean Delvare
2022-07-05 10:36 ` Uwe Kleine-König
2022-07-05 20:11 ` Corey Minyard
2022-07-06 9:13 ` Vladimir Oltean
2022-07-06 9:31 ` Uwe Kleine-König
2022-07-17 12:35 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629072304.qazmloqdi5h5kdre@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chrome-platform@lists.linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=kasan-dev@googlegroups.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).