From: Luca Ceresoli <luca@lucaceresoli.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wolfram Sang" <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
openipmi-developer@lists.sourceforge.net,
linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org,
dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-staging@lists.linux.dev, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void
Date: Wed, 29 Jun 2022 23:20:04 +0200 [thread overview]
Message-ID: <d682fb60-c254-f89e-5d6d-cdf7aa752939@lucaceresoli.net> (raw)
In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>
Hi,
[keeping only individuals and lists in Cc to avoid bounces]
On 28/06/22 16:03, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <uwe@kleine-koenig.org>
>
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
For versaclock:
> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> index e7be3e54b9be..657493ecce4c 100644
> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -1138,7 +1138,7 @@ static int vc5_probe(struct i2c_client *client)
> return ret;
> }
>
> -static int vc5_remove(struct i2c_client *client)
> +static void vc5_remove(struct i2c_client *client)
> {
> struct vc5_driver_data *vc5 = i2c_get_clientdata(client);
>
> @@ -1146,8 +1146,6 @@ static int vc5_remove(struct i2c_client *client)
>
> if (vc5->chip_info->flags & VC5_HAS_INTERNAL_XTAL)
> clk_unregister_fixed_rate(vc5->pin_xin);
> -
> - return 0;
> }
>
> static int __maybe_unused vc5_suspend(struct device *dev)
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-06-29 21:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:03 [PATCH 0/6] i2c: Make remove callback return void Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 6/6] " Uwe Kleine-König
2022-06-29 6:56 ` Peter Senna Tschudin
2022-06-29 7:03 ` Jeremy Kerr
2022-06-29 7:23 ` Uwe Kleine-König
2022-06-29 7:37 ` Javier Martinez Canillas
2022-06-29 7:55 ` Christophe Leroy
2022-06-29 8:09 ` Javier Martinez Canillas
2022-06-29 7:21 ` Benjamin Mugnier
2022-06-29 7:24 ` Crt Mori
2022-06-29 7:43 ` Uwe Kleine-König
2022-06-29 7:27 ` Benjamin Mugnier
2022-06-29 9:05 ` Greg Kroah-Hartman
2022-06-29 9:20 ` Marek Behún
2022-06-29 10:40 ` Andy Shevchenko
2022-06-29 13:11 ` Andrey Ryabinin
2022-06-29 13:35 ` Uwe Kleine-König
2022-06-29 14:25 ` Maximilian Luz
2022-06-29 14:31 ` srinivas pandruvada
2022-06-29 14:41 ` Hans Verkuil
2022-06-29 14:50 ` Miguel Ojeda
2022-06-29 21:20 ` Luca Ceresoli [this message]
2022-07-01 17:00 ` Jonathan Cameron
2022-07-01 18:18 ` Peter Rosin
2022-07-05 10:08 ` Jean Delvare
2022-07-05 10:36 ` Uwe Kleine-König
2022-07-05 20:11 ` Corey Minyard
2022-07-06 9:13 ` Vladimir Oltean
2022-07-06 9:31 ` Uwe Kleine-König
2022-07-17 12:35 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d682fb60-c254-f89e-5d6d-cdf7aa752939@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).