* [PATCH -next] mtd: rawnand: Fix PM disable depth imbalance in tegra_nand_probe
@ 2022-09-26 8:44 Zhang Qilong
2022-10-18 9:02 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Qilong @ 2022-09-26 8:44 UTC (permalink / raw)
To: stefan, dev, miquel.raynal, vigneshr; +Cc: richard, linux-tegra, linux-mtd
The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context.
Fixes:d7d9f8ec77fe9 ("mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/mtd/nand/raw/tegra_nand.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/tegra_nand.c b/drivers/mtd/nand/raw/tegra_nand.c
index e12f9f580a15..a9b9031ce616 100644
--- a/drivers/mtd/nand/raw/tegra_nand.c
+++ b/drivers/mtd/nand/raw/tegra_nand.c
@@ -1181,7 +1181,7 @@ static int tegra_nand_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
err = pm_runtime_resume_and_get(&pdev->dev);
if (err)
- return err;
+ goto err_dis_pm;
err = reset_control_reset(rst);
if (err) {
@@ -1215,6 +1215,8 @@ static int tegra_nand_probe(struct platform_device *pdev)
err_put_pm:
pm_runtime_put_sync_suspend(ctrl->dev);
pm_runtime_force_suspend(ctrl->dev);
+err_dis_pm:
+ pm_runtime_disable(&pdev->dev);
return err;
}
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: rawnand: Fix PM disable depth imbalance in tegra_nand_probe
2022-09-26 8:44 [PATCH -next] mtd: rawnand: Fix PM disable depth imbalance in tegra_nand_probe Zhang Qilong
@ 2022-10-18 9:02 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2022-10-18 9:02 UTC (permalink / raw)
To: Zhang Qilong, stefan, dev, miquel.raynal, vigneshr
Cc: richard, linux-tegra, linux-mtd
On Mon, 2022-09-26 at 08:44:56 UTC, Zhang Qilong wrote:
> The pm_runtime_enable will increase power disable depth. Thus
> a pairing decrement is needed on the error handling path to
> keep it balanced according to context.
>
> Fixes:d7d9f8ec77fe9 ("mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver")
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 8:44 [PATCH -next] mtd: rawnand: Fix PM disable depth imbalance in tegra_nand_probe Zhang Qilong
2022-10-18 9:02 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).