linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: parsers: refer to ARCH_BCMBCA instead of ARCH_BCM4908
@ 2022-11-16 12:49 Lukas Bulwahn
  2022-11-17 21:14 ` Miquel Raynal
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2022-11-16 12:49 UTC (permalink / raw)
  To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
	Rafał Miłecki, linux-mtd
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.

Probably due to concurrent development, commit 002181f5b150 ("mtd: parsers:
add Broadcom's U-Boot parser") introduces 'Broadcom's U-Boot partition
parser' that depends on ARCH_BCM4908, but this use was not visible during
the config refactoring from the commit above. Hence, these two changes
create a reference to a non-existing config symbol.

Adjust the MTD_BRCM_U_BOOT definition to refer to ARCH_BCMBCA instead of
ARCH_BCM4908 to remove the reference to the non-existing config symbol
ARCH_BCM4908.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/mtd/parsers/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
index c258ba2a3a6f..daeae79e64f9 100644
--- a/drivers/mtd/parsers/Kconfig
+++ b/drivers/mtd/parsers/Kconfig
@@ -22,7 +22,7 @@ config MTD_BCM63XX_PARTS
 
 config MTD_BRCM_U_BOOT
 	tristate "Broadcom's U-Boot partition parser"
-	depends on ARCH_BCM4908 || COMPILE_TEST
+	depends on ARCH_BCMBCA || COMPILE_TEST
 	help
 	  Broadcom uses a custom way of storing U-Boot environment variables.
 	  They are placed inside U-Boot partition itself at unspecified offset.
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: parsers: refer to ARCH_BCMBCA instead of ARCH_BCM4908
  2022-11-16 12:49 [PATCH] mtd: parsers: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
@ 2022-11-17 21:14 ` Miquel Raynal
  0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2022-11-17 21:14 UTC (permalink / raw)
  To: Lukas Bulwahn, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Rafał Miłecki, linux-mtd
  Cc: kernel-janitors, linux-kernel

On Wed, 2022-11-16 at 12:49:32 UTC, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
> 
> Probably due to concurrent development, commit 002181f5b150 ("mtd: parsers:
> add Broadcom's U-Boot parser") introduces 'Broadcom's U-Boot partition
> parser' that depends on ARCH_BCM4908, but this use was not visible during
> the config refactoring from the commit above. Hence, these two changes
> create a reference to a non-existing config symbol.
> 
> Adjust the MTD_BRCM_U_BOOT definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-17 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 12:49 [PATCH] mtd: parsers: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
2022-11-17 21:14 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).