* [PATCH v1 0/3] fdt: Fix mtparts fixup @ 2023-01-13 18:45 Francesco Dolcini 2023-01-13 18:45 ` [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Francesco Dolcini 2023-01-13 19:34 ` [PATCH v1 0/3] fdt: Fix mtparts fixup Tom Rini 0 siblings, 2 replies; 16+ messages in thread From: Francesco Dolcini @ 2023-01-13 18:45 UTC (permalink / raw) To: Simon Glass, u-boot, Marcel Ziswiler Cc: Francesco Dolcini, Marek Vasut, Miquel Raynal, linux-mtd From: Francesco Dolcini <francesco.dolcini@toradex.com> Recently we had a boot regression on colibri-imx7 because of a cleanup change on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. Because of that Linux partition parser was no longer able to properly parse the OF partitions leading to a boot failure, the above change was reverted in the meantime as an immediate workaround, but some improvement is required on both Linux and U-Boot. This change improve the U-Boot part of it, #size-cell is set to 1 when it has an invalid value. This has the limitation to work only with devices smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would be to just deprecate using this U-Boot function and pass the MTD partitions from the command line, unless they are statically defined in the DTS file in the first place. This series therefore convert colibri-imx6ull and colibri-imx7 to pass the partition list from the command line instead of fixing up the DT. Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ Francesco Dolcini (3): fdt: validate/fix cells count on mtdpart fixup colibri-imx7: specify MTD partitions on command line colibri-imx6ull: specify MTD partitions on command line common/fdt_support.c | 45 ++++++++++++++++++++++++------- configs/colibri-imx6ull_defconfig | 1 - configs/colibri_imx7_defconfig | 1 - include/configs/colibri-imx6ull.h | 2 +- include/configs/colibri_imx7.h | 2 +- 5 files changed, 37 insertions(+), 14 deletions(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-13 18:45 [PATCH v1 0/3] fdt: Fix mtparts fixup Francesco Dolcini @ 2023-01-13 18:45 ` Francesco Dolcini 2023-01-15 14:35 ` Marek Vasut 2023-01-13 19:34 ` [PATCH v1 0/3] fdt: Fix mtparts fixup Tom Rini 1 sibling, 1 reply; 16+ messages in thread From: Francesco Dolcini @ 2023-01-13 18:45 UTC (permalink / raw) To: Simon Glass, u-boot, Marcel Ziswiler Cc: Francesco Dolcini, Marek Vasut, Miquel Raynal, linux-mtd From: Francesco Dolcini <francesco.dolcini@toradex.com> Fixup #size-cells value when updating the MTD partitions, this is required to prevent issues in case the MTD parent set #size-cells to zero. This could happen for example in the legacy case in which the partitions are created as direct child of the mtd node and that specific node has no children. Recent clean-up on Linux device tree files created a boot regression on colibri-imx7. This fixup has the limitation to assume 32-bit (#size-cells=1) addressing, therefore it will not work with device bigger than 4GiB. This change also enforce #address-cells to be the same as #size-cells, this was already silently enforced by fdt_node_set_part_info(), now this is checked explicitly and partition fixup will just fail in such case. In general board should not generally need nor use this functionality and should be just deprecated, passing mtdparts= in the kernel command line is the preferred way according to Linux MTD subsystem maintainer. Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ Cc: Marek Vasut <marex@denx.de> Cc: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/common/fdt_support.c b/common/fdt_support.c index dbceec6f2dcc..3aee826e60cf 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) return 0; } -static int fdt_node_set_part_info(void *blob, int parent_offset, +/* This expects #address-cells and #size-cells to have same value */ +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, struct mtd_device *dev) { struct list_head *pentry; struct part_info *part; int off, ndepth = 0; int part_num, ret; - int sizecell; char buf[64]; ret = fdt_del_partitions(blob, parent_offset); if (ret < 0) return ret; - /* - * Check if size/address is 1 or 2 cells. - * We assume #address-cells and #size-cells have same value. - */ - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, - 0, "#size-cells", 1); - /* * Check if it is nand {}; subnode, adjust * the offset in this case @@ -992,6 +985,31 @@ err_prop: return ret; } +static int fdt_mtdparts_cell_cnt(void *fdt, int off) +{ + int sizecell, addrcell; + + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); + if (sizecell != 1 && sizecell != 2) { + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", + __func__, sizecell); + + sizecell = 1; + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) + return -1; + } + + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, + "#address-cells", 0); + if (addrcell != sizecell) { + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", + __func__, addrcell, sizecell); + return -1; + } + + return sizecell; +} + /* * Update partitions in nor/nand nodes using info from * mtdparts environment variable. The nodes to update are @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, dev = device_find(node_info[i].type, idx++); if (dev) { + int cell; + parts = fdt_subnode_offset(blob, noff, "partitions"); if (parts < 0) parts = noff; - if (fdt_node_set_part_info(blob, parts, dev)) + cell = fdt_mtdparts_cell_cnt(blob, parts); + if (cell < 0) + return; + + if (fdt_node_set_part_info(blob, parts, + cell, dev)) return; /* return on error */ } } -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-13 18:45 ` [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Francesco Dolcini @ 2023-01-15 14:35 ` Marek Vasut 2023-01-16 14:20 ` Francesco Dolcini 0 siblings, 1 reply; 16+ messages in thread From: Marek Vasut @ 2023-01-15 14:35 UTC (permalink / raw) To: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler Cc: Francesco Dolcini, Miquel Raynal, linux-mtd On 1/13/23 19:45, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Fixup #size-cells value when updating the MTD partitions, this is > required to prevent issues in case the MTD parent set #size-cells to > zero. > This could happen for example in the legacy case in which the partitions > are created as direct child of the mtd node and that specific node has > no children. Recent clean-up on Linux device tree files created a boot > regression on colibri-imx7. > > This fixup has the limitation to assume 32-bit (#size-cells=1) > addressing, therefore it will not work with device bigger than 4GiB. > > This change also enforce #address-cells to be the same as #size-cells, > this was already silently enforced by fdt_node_set_part_info(), now this > is checked explicitly and partition fixup will just fail in such case. > > In general board should not generally need nor use this functionality > and should be just deprecated, passing mtdparts= in the kernel command > line is the preferred way according to Linux MTD subsystem maintainer. > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > Cc: Marek Vasut <marex@denx.de> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- > 1 file changed, 35 insertions(+), 10 deletions(-) > > diff --git a/common/fdt_support.c b/common/fdt_support.c > index dbceec6f2dcc..3aee826e60cf 100644 > --- a/common/fdt_support.c > +++ b/common/fdt_support.c > @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) > return 0; > } > > -static int fdt_node_set_part_info(void *blob, int parent_offset, > +/* This expects #address-cells and #size-cells to have same value */ > +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, > struct mtd_device *dev) > { > struct list_head *pentry; > struct part_info *part; > int off, ndepth = 0; > int part_num, ret; > - int sizecell; > char buf[64]; > > ret = fdt_del_partitions(blob, parent_offset); > if (ret < 0) > return ret; > > - /* > - * Check if size/address is 1 or 2 cells. > - * We assume #address-cells and #size-cells have same value. > - */ > - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, > - 0, "#size-cells", 1); > - > /* > * Check if it is nand {}; subnode, adjust > * the offset in this case > @@ -992,6 +985,31 @@ err_prop: > return ret; > } > > +static int fdt_mtdparts_cell_cnt(void *fdt, int off) > +{ > + int sizecell, addrcell; > + > + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); > + if (sizecell != 1 && sizecell != 2) { > + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", > + __func__, sizecell); > + > + sizecell = 1; > + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) > + return -1; > + } > + > + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, > + "#address-cells", 0); > + if (addrcell != sizecell) { > + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", > + __func__, addrcell, sizecell); > + return -1; > + } > + > + return sizecell; > +} > + > /* > * Update partitions in nor/nand nodes using info from > * mtdparts environment variable. The nodes to update are > @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, > > dev = device_find(node_info[i].type, idx++); > if (dev) { > + int cell; > + > parts = fdt_subnode_offset(blob, noff, > "partitions"); > if (parts < 0) > parts = noff; > > - if (fdt_node_set_part_info(blob, parts, dev)) > + cell = fdt_mtdparts_cell_cnt(blob, parts); > + if (cell < 0) > + return; > + > + if (fdt_node_set_part_info(blob, parts, > + cell, dev)) > return; /* return on error */ > } > } Can you please include the resulting gpmi node content with this fixup applied in the commit message , so it can be validated ? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-15 14:35 ` Marek Vasut @ 2023-01-16 14:20 ` Francesco Dolcini 2023-01-16 17:54 ` Marek Vasut 0 siblings, 1 reply; 16+ messages in thread From: Francesco Dolcini @ 2023-01-16 14:20 UTC (permalink / raw) To: Marek Vasut Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Miquel Raynal, linux-mtd On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > On 1/13/23 19:45, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Fixup #size-cells value when updating the MTD partitions, this is > > required to prevent issues in case the MTD parent set #size-cells to > > zero. > > This could happen for example in the legacy case in which the partitions > > are created as direct child of the mtd node and that specific node has > > no children. Recent clean-up on Linux device tree files created a boot > > regression on colibri-imx7. > > > > This fixup has the limitation to assume 32-bit (#size-cells=1) > > addressing, therefore it will not work with device bigger than 4GiB. > > > > This change also enforce #address-cells to be the same as #size-cells, > > this was already silently enforced by fdt_node_set_part_info(), now this > > is checked explicitly and partition fixup will just fail in such case. > > > > In general board should not generally need nor use this functionality > > and should be just deprecated, passing mtdparts= in the kernel command > > line is the preferred way according to Linux MTD subsystem maintainer. > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > > Cc: Marek Vasut <marex@denx.de> > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- > > 1 file changed, 35 insertions(+), 10 deletions(-) > > > > diff --git a/common/fdt_support.c b/common/fdt_support.c > > index dbceec6f2dcc..3aee826e60cf 100644 > > --- a/common/fdt_support.c > > +++ b/common/fdt_support.c > > @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) > > return 0; > > } > > -static int fdt_node_set_part_info(void *blob, int parent_offset, > > +/* This expects #address-cells and #size-cells to have same value */ > > +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, > > struct mtd_device *dev) > > { > > struct list_head *pentry; > > struct part_info *part; > > int off, ndepth = 0; > > int part_num, ret; > > - int sizecell; > > char buf[64]; > > ret = fdt_del_partitions(blob, parent_offset); > > if (ret < 0) > > return ret; > > - /* > > - * Check if size/address is 1 or 2 cells. > > - * We assume #address-cells and #size-cells have same value. > > - */ > > - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, > > - 0, "#size-cells", 1); > > - > > /* > > * Check if it is nand {}; subnode, adjust > > * the offset in this case > > @@ -992,6 +985,31 @@ err_prop: > > return ret; > > } > > +static int fdt_mtdparts_cell_cnt(void *fdt, int off) > > +{ > > + int sizecell, addrcell; > > + > > + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); > > + if (sizecell != 1 && sizecell != 2) { > > + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", > > + __func__, sizecell); > > + > > + sizecell = 1; > > + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) > > + return -1; > > + } > > + > > + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, > > + "#address-cells", 0); > > + if (addrcell != sizecell) { > > + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", > > + __func__, addrcell, sizecell); > > + return -1; > > + } > > + > > + return sizecell; > > +} > > + > > /* > > * Update partitions in nor/nand nodes using info from > > * mtdparts environment variable. The nodes to update are > > @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, > > dev = device_find(node_info[i].type, idx++); > > if (dev) { > > + int cell; > > + > > parts = fdt_subnode_offset(blob, noff, > > "partitions"); > > if (parts < 0) > > parts = noff; > > - if (fdt_node_set_part_info(blob, parts, dev)) > > + cell = fdt_mtdparts_cell_cnt(blob, parts); > > + if (cell < 0) > > + return; > > + > > + if (fdt_node_set_part_info(blob, parts, > > + cell, dev)) > > return; /* return on error */ > > } > > } > > Can you please include the resulting gpmi node content with this fixup > applied in the commit message , so it can be validated ? I will add it to v2, I would wait a little bit more time to get additional feedback sending it however. In the meantime here the output, but nothing really changed! What this change is doing is just - setting #size-cells to <1> when it is invalid - skip generation at all when #size-cells != #address-cells. Former code was just generating a broken table without any error message. Here what is generated for colibri-imx7 nand-controller@33002000 { compatible = "fsl,imx7d-gpmi-nand"; #address-cells = <0x01>; #size-cells = <0x01>; [...snip...] partition@0 { label = "mx7-bcb"; reg = <0x00 0x80000>; }; partition@400000 { label = "ubi"; reg = <0x400000 0x1fc00000>; }; partition@80000 { read_only; label = "u-boot1"; reg = <0x80000 0x180000>; }; partition@380000 { label = "u-boot-env"; reg = <0x380000 0x80000>; }; partition@200000 { read_only; label = "u-boot2"; reg = <0x200000 0x180000>; }; }; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-16 14:20 ` Francesco Dolcini @ 2023-01-16 17:54 ` Marek Vasut 2023-01-16 18:00 ` Francesco Dolcini 0 siblings, 1 reply; 16+ messages in thread From: Marek Vasut @ 2023-01-16 17:54 UTC (permalink / raw) To: Francesco Dolcini Cc: Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Miquel Raynal, linux-mtd On 1/16/23 15:20, Francesco Dolcini wrote: > On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: >> On 1/13/23 19:45, Francesco Dolcini wrote: >>> From: Francesco Dolcini <francesco.dolcini@toradex.com> >>> >>> Fixup #size-cells value when updating the MTD partitions, this is >>> required to prevent issues in case the MTD parent set #size-cells to >>> zero. >>> This could happen for example in the legacy case in which the partitions >>> are created as direct child of the mtd node and that specific node has >>> no children. Recent clean-up on Linux device tree files created a boot >>> regression on colibri-imx7. >>> >>> This fixup has the limitation to assume 32-bit (#size-cells=1) >>> addressing, therefore it will not work with device bigger than 4GiB. >>> >>> This change also enforce #address-cells to be the same as #size-cells, >>> this was already silently enforced by fdt_node_set_part_info(), now this >>> is checked explicitly and partition fixup will just fail in such case. >>> >>> In general board should not generally need nor use this functionality >>> and should be just deprecated, passing mtdparts= in the kernel command >>> line is the preferred way according to Linux MTD subsystem maintainer. >>> >>> Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ >>> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ >>> Cc: Marek Vasut <marex@denx.de> >>> Cc: Miquel Raynal <miquel.raynal@bootlin.com> >>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> >>> --- >>> common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- >>> 1 file changed, 35 insertions(+), 10 deletions(-) >>> >>> diff --git a/common/fdt_support.c b/common/fdt_support.c >>> index dbceec6f2dcc..3aee826e60cf 100644 >>> --- a/common/fdt_support.c >>> +++ b/common/fdt_support.c >>> @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) >>> return 0; >>> } >>> -static int fdt_node_set_part_info(void *blob, int parent_offset, >>> +/* This expects #address-cells and #size-cells to have same value */ >>> +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, >>> struct mtd_device *dev) >>> { >>> struct list_head *pentry; >>> struct part_info *part; >>> int off, ndepth = 0; >>> int part_num, ret; >>> - int sizecell; >>> char buf[64]; >>> ret = fdt_del_partitions(blob, parent_offset); >>> if (ret < 0) >>> return ret; >>> - /* >>> - * Check if size/address is 1 or 2 cells. >>> - * We assume #address-cells and #size-cells have same value. >>> - */ >>> - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, >>> - 0, "#size-cells", 1); >>> - >>> /* >>> * Check if it is nand {}; subnode, adjust >>> * the offset in this case >>> @@ -992,6 +985,31 @@ err_prop: >>> return ret; >>> } >>> +static int fdt_mtdparts_cell_cnt(void *fdt, int off) >>> +{ >>> + int sizecell, addrcell; >>> + >>> + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); >>> + if (sizecell != 1 && sizecell != 2) { >>> + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", >>> + __func__, sizecell); >>> + >>> + sizecell = 1; >>> + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) >>> + return -1; >>> + } >>> + >>> + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, >>> + "#address-cells", 0); >>> + if (addrcell != sizecell) { >>> + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", >>> + __func__, addrcell, sizecell); >>> + return -1; >>> + } >>> + >>> + return sizecell; >>> +} >>> + >>> /* >>> * Update partitions in nor/nand nodes using info from >>> * mtdparts environment variable. The nodes to update are >>> @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, >>> dev = device_find(node_info[i].type, idx++); >>> if (dev) { >>> + int cell; >>> + >>> parts = fdt_subnode_offset(blob, noff, >>> "partitions"); >>> if (parts < 0) >>> parts = noff; >>> - if (fdt_node_set_part_info(blob, parts, dev)) >>> + cell = fdt_mtdparts_cell_cnt(blob, parts); >>> + if (cell < 0) >>> + return; >>> + >>> + if (fdt_node_set_part_info(blob, parts, >>> + cell, dev)) >>> return; /* return on error */ >>> } >>> } >> >> Can you please include the resulting gpmi node content with this fixup >> applied in the commit message , so it can be validated ? > > I will add it to v2, I would wait a little bit more time to get > additional feedback sending it however. > > In the meantime here the output, but nothing really changed! > What this change is doing is just > - setting #size-cells to <1> when it is invalid > - skip generation at all when #size-cells != #address-cells. Former > code was just generating a broken table without any error > message. > > Here what is generated for colibri-imx7 > > nand-controller@33002000 { > compatible = "fsl,imx7d-gpmi-nand"; > > #address-cells = <0x01>; > #size-cells = <0x01>; > > [...snip...] > > partition@0 { > label = "mx7-bcb"; > reg = <0x00 0x80000>; > }; > > partition@400000 { > label = "ubi"; > reg = <0x400000 0x1fc00000>; > }; > > partition@80000 { > read_only; > label = "u-boot1"; > reg = <0x80000 0x180000>; > }; > > partition@380000 { > label = "u-boot-env"; > reg = <0x380000 0x80000>; > }; > > partition@200000 { > read_only; > label = "u-boot2"; > reg = <0x200000 0x180000>; > }; > }; This is what I was afraid of, shouldn't this contain the partitions in per-chipselect sub-node instead of directly in the GPMI node ? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-16 17:54 ` Marek Vasut @ 2023-01-16 18:00 ` Francesco Dolcini 2023-01-17 0:59 ` Marek Vasut 0 siblings, 1 reply; 16+ messages in thread From: Francesco Dolcini @ 2023-01-16 18:00 UTC (permalink / raw) To: Marek Vasut Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Miquel Raynal, linux-mtd On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > On 1/16/23 15:20, Francesco Dolcini wrote: > > On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > > > On 1/13/23 19:45, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Fixup #size-cells value when updating the MTD partitions, this is > > > > required to prevent issues in case the MTD parent set #size-cells to > > > > zero. > > > > This could happen for example in the legacy case in which the partitions > > > > are created as direct child of the mtd node and that specific node has > > > > no children. Recent clean-up on Linux device tree files created a boot > > > > regression on colibri-imx7. > > > > > > > > This fixup has the limitation to assume 32-bit (#size-cells=1) > > > > addressing, therefore it will not work with device bigger than 4GiB. > > > > > > > > This change also enforce #address-cells to be the same as #size-cells, > > > > this was already silently enforced by fdt_node_set_part_info(), now this > > > > is checked explicitly and partition fixup will just fail in such case. > > > > > > > > In general board should not generally need nor use this functionality > > > > and should be just deprecated, passing mtdparts= in the kernel command > > > > line is the preferred way according to Linux MTD subsystem maintainer. > > > > > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > > > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > --- > > > > common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- > > > > 1 file changed, 35 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/common/fdt_support.c b/common/fdt_support.c > > > > index dbceec6f2dcc..3aee826e60cf 100644 > > > > --- a/common/fdt_support.c > > > > +++ b/common/fdt_support.c > > > > @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) > > > > return 0; > > > > } > > > > -static int fdt_node_set_part_info(void *blob, int parent_offset, > > > > +/* This expects #address-cells and #size-cells to have same value */ > > > > +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, > > > > struct mtd_device *dev) > > > > { > > > > struct list_head *pentry; > > > > struct part_info *part; > > > > int off, ndepth = 0; > > > > int part_num, ret; > > > > - int sizecell; > > > > char buf[64]; > > > > ret = fdt_del_partitions(blob, parent_offset); > > > > if (ret < 0) > > > > return ret; > > > > - /* > > > > - * Check if size/address is 1 or 2 cells. > > > > - * We assume #address-cells and #size-cells have same value. > > > > - */ > > > > - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, > > > > - 0, "#size-cells", 1); > > > > - > > > > /* > > > > * Check if it is nand {}; subnode, adjust > > > > * the offset in this case > > > > @@ -992,6 +985,31 @@ err_prop: > > > > return ret; > > > > } > > > > +static int fdt_mtdparts_cell_cnt(void *fdt, int off) > > > > +{ > > > > + int sizecell, addrcell; > > > > + > > > > + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); > > > > + if (sizecell != 1 && sizecell != 2) { > > > > + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", > > > > + __func__, sizecell); > > > > + > > > > + sizecell = 1; > > > > + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) > > > > + return -1; > > > > + } > > > > + > > > > + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, > > > > + "#address-cells", 0); > > > > + if (addrcell != sizecell) { > > > > + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", > > > > + __func__, addrcell, sizecell); > > > > + return -1; > > > > + } > > > > + > > > > + return sizecell; > > > > +} > > > > + > > > > /* > > > > * Update partitions in nor/nand nodes using info from > > > > * mtdparts environment variable. The nodes to update are > > > > @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, > > > > dev = device_find(node_info[i].type, idx++); > > > > if (dev) { > > > > + int cell; > > > > + > > > > parts = fdt_subnode_offset(blob, noff, > > > > "partitions"); > > > > if (parts < 0) > > > > parts = noff; > > > > - if (fdt_node_set_part_info(blob, parts, dev)) > > > > + cell = fdt_mtdparts_cell_cnt(blob, parts); > > > > + if (cell < 0) > > > > + return; > > > > + > > > > + if (fdt_node_set_part_info(blob, parts, > > > > + cell, dev)) > > > > return; /* return on error */ > > > > } > > > > } > > > > > > Can you please include the resulting gpmi node content with this fixup > > > applied in the commit message , so it can be validated ? > > > > I will add it to v2, I would wait a little bit more time to get > > additional feedback sending it however. > > > > In the meantime here the output, but nothing really changed! > > What this change is doing is just > > - setting #size-cells to <1> when it is invalid > > - skip generation at all when #size-cells != #address-cells. Former > > code was just generating a broken table without any error > > message. > > > > Here what is generated for colibri-imx7 > > > > nand-controller@33002000 { > > compatible = "fsl,imx7d-gpmi-nand"; > > > > #address-cells = <0x01>; > > #size-cells = <0x01>; > > > > [...snip...] > > > > partition@0 { > > label = "mx7-bcb"; > > reg = <0x00 0x80000>; > > }; > > > > partition@400000 { > > label = "ubi"; > > reg = <0x400000 0x1fc00000>; > > }; > > > > partition@80000 { > > read_only; > > label = "u-boot1"; > > reg = <0x80000 0x180000>; > > }; > > > > partition@380000 { > > label = "u-boot-env"; > > reg = <0x380000 0x80000>; > > }; > > > > partition@200000 { > > read_only; > > label = "u-boot2"; > > reg = <0x200000 0x180000>; > > }; > > }; > > This is what I was afraid of, shouldn't this contain the partitions in > per-chipselect sub-node instead of directly in the GPMI node ? That does not exists in my source DTS, this function just look for a partitions node and update it when it exists. I do not have a nand chip, and I do not want to add. The reason is what I wrote in my other email, if I would do something like older U-Boot's would ignore it and just generate the partitions as direct children of the nand-controller. Commit 36fee2f7621e ("common: fdt_support: add support for "partitions" subnode to fdt_fixup_mtdparts()") was introduced only in v2022.04. Francesco ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-16 18:00 ` Francesco Dolcini @ 2023-01-17 0:59 ` Marek Vasut 2023-01-23 9:56 ` Miquel Raynal 0 siblings, 1 reply; 16+ messages in thread From: Marek Vasut @ 2023-01-17 0:59 UTC (permalink / raw) To: Francesco Dolcini Cc: Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Miquel Raynal, linux-mtd On 1/16/23 19:00, Francesco Dolcini wrote: > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: >> On 1/16/23 15:20, Francesco Dolcini wrote: >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: >>>> On 1/13/23 19:45, Francesco Dolcini wrote: >>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> >>>>> >>>>> Fixup #size-cells value when updating the MTD partitions, this is >>>>> required to prevent issues in case the MTD parent set #size-cells to >>>>> zero. >>>>> This could happen for example in the legacy case in which the partitions >>>>> are created as direct child of the mtd node and that specific node has >>>>> no children. Recent clean-up on Linux device tree files created a boot >>>>> regression on colibri-imx7. >>>>> >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) >>>>> addressing, therefore it will not work with device bigger than 4GiB. >>>>> >>>>> This change also enforce #address-cells to be the same as #size-cells, >>>>> this was already silently enforced by fdt_node_set_part_info(), now this >>>>> is checked explicitly and partition fixup will just fail in such case. >>>>> >>>>> In general board should not generally need nor use this functionality >>>>> and should be just deprecated, passing mtdparts= in the kernel command >>>>> line is the preferred way according to Linux MTD subsystem maintainer. >>>>> >>>>> Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ >>>>> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ >>>>> Cc: Marek Vasut <marex@denx.de> >>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com> >>>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> >>>>> --- >>>>> common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- >>>>> 1 file changed, 35 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/common/fdt_support.c b/common/fdt_support.c >>>>> index dbceec6f2dcc..3aee826e60cf 100644 >>>>> --- a/common/fdt_support.c >>>>> +++ b/common/fdt_support.c >>>>> @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) >>>>> return 0; >>>>> } >>>>> -static int fdt_node_set_part_info(void *blob, int parent_offset, >>>>> +/* This expects #address-cells and #size-cells to have same value */ >>>>> +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, >>>>> struct mtd_device *dev) >>>>> { >>>>> struct list_head *pentry; >>>>> struct part_info *part; >>>>> int off, ndepth = 0; >>>>> int part_num, ret; >>>>> - int sizecell; >>>>> char buf[64]; >>>>> ret = fdt_del_partitions(blob, parent_offset); >>>>> if (ret < 0) >>>>> return ret; >>>>> - /* >>>>> - * Check if size/address is 1 or 2 cells. >>>>> - * We assume #address-cells and #size-cells have same value. >>>>> - */ >>>>> - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, >>>>> - 0, "#size-cells", 1); >>>>> - >>>>> /* >>>>> * Check if it is nand {}; subnode, adjust >>>>> * the offset in this case >>>>> @@ -992,6 +985,31 @@ err_prop: >>>>> return ret; >>>>> } >>>>> +static int fdt_mtdparts_cell_cnt(void *fdt, int off) >>>>> +{ >>>>> + int sizecell, addrcell; >>>>> + >>>>> + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); >>>>> + if (sizecell != 1 && sizecell != 2) { >>>>> + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", >>>>> + __func__, sizecell); >>>>> + >>>>> + sizecell = 1; >>>>> + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) >>>>> + return -1; >>>>> + } >>>>> + >>>>> + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, >>>>> + "#address-cells", 0); >>>>> + if (addrcell != sizecell) { >>>>> + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", >>>>> + __func__, addrcell, sizecell); >>>>> + return -1; >>>>> + } >>>>> + >>>>> + return sizecell; >>>>> +} >>>>> + >>>>> /* >>>>> * Update partitions in nor/nand nodes using info from >>>>> * mtdparts environment variable. The nodes to update are >>>>> @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, >>>>> dev = device_find(node_info[i].type, idx++); >>>>> if (dev) { >>>>> + int cell; >>>>> + >>>>> parts = fdt_subnode_offset(blob, noff, >>>>> "partitions"); >>>>> if (parts < 0) >>>>> parts = noff; >>>>> - if (fdt_node_set_part_info(blob, parts, dev)) >>>>> + cell = fdt_mtdparts_cell_cnt(blob, parts); >>>>> + if (cell < 0) >>>>> + return; >>>>> + >>>>> + if (fdt_node_set_part_info(blob, parts, >>>>> + cell, dev)) >>>>> return; /* return on error */ >>>>> } >>>>> } >>>> >>>> Can you please include the resulting gpmi node content with this fixup >>>> applied in the commit message , so it can be validated ? >>> >>> I will add it to v2, I would wait a little bit more time to get >>> additional feedback sending it however. >>> >>> In the meantime here the output, but nothing really changed! >>> What this change is doing is just >>> - setting #size-cells to <1> when it is invalid >>> - skip generation at all when #size-cells != #address-cells. Former >>> code was just generating a broken table without any error >>> message. >>> >>> Here what is generated for colibri-imx7 >>> >>> nand-controller@33002000 { >>> compatible = "fsl,imx7d-gpmi-nand"; >>> >>> #address-cells = <0x01>; >>> #size-cells = <0x01>; >>> >>> [...snip...] >>> >>> partition@0 { >>> label = "mx7-bcb"; >>> reg = <0x00 0x80000>; >>> }; >>> >>> partition@400000 { >>> label = "ubi"; >>> reg = <0x400000 0x1fc00000>; >>> }; >>> >>> partition@80000 { >>> read_only; >>> label = "u-boot1"; >>> reg = <0x80000 0x180000>; >>> }; >>> >>> partition@380000 { >>> label = "u-boot-env"; >>> reg = <0x380000 0x80000>; >>> }; >>> >>> partition@200000 { >>> read_only; >>> label = "u-boot2"; >>> reg = <0x200000 0x180000>; >>> }; >>> }; >> >> This is what I was afraid of, shouldn't this contain the partitions in >> per-chipselect sub-node instead of directly in the GPMI node ? > > That does not exists in my source DTS, this function just look for a > partitions node and update it when it exists. > I do not have a nand chip, and I do not want to add. I know. I wonder if the function should convert the bindings to latest greatest, but I am starting to feel like hard-coding this kind of complex logic into bootloader is not a great idea . > The reason is what I wrote in my other email, if I would do something > like older U-Boot's would ignore it and just generate the partitions > as direct children of the nand-controller. > > Commit 36fee2f7621e ("common: fdt_support: add support for "partitions" > subnode to fdt_fixup_mtdparts()") was introduced only in v2022.04. There is the Linux BOOT_CONFIG , that might be some sort of alternative to complex kernel command line, but that's a bit more work. I figured I'd mention it here. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-17 0:59 ` Marek Vasut @ 2023-01-23 9:56 ` Miquel Raynal 2023-01-24 8:41 ` Francesco Dolcini 0 siblings, 1 reply; 16+ messages in thread From: Miquel Raynal @ 2023-01-23 9:56 UTC (permalink / raw) To: Marek Vasut Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, linux-mtd Hi Francesco, Thanks for your work. marex@denx.de wrote on Tue, 17 Jan 2023 01:59:54 +0100: > On 1/16/23 19:00, Francesco Dolcini wrote: > > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > >> On 1/16/23 15:20, Francesco Dolcini wrote: > >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > >>>> On 1/13/23 19:45, Francesco Dolcini wrote: > >>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> > >>>>> > >>>>> Fixup #size-cells value when updating the MTD partitions, this is > >>>>> required to prevent issues in case the MTD parent set #size-cells to > >>>>> zero. > >>>>> This could happen for example in the legacy case in which the partitions > >>>>> are created as direct child of the mtd node and that specific node has > >>>>> no children. Recent clean-up on Linux device tree files created a boot > >>>>> regression on colibri-imx7. > >>>>> > >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) > >>>>> addressing, therefore it will not work with device bigger than 4GiB. > >>>>> > >>>>> This change also enforce #address-cells to be the same as #size-cells, > >>>>> this was already silently enforced by fdt_node_set_part_info(), now this > >>>>> is checked explicitly and partition fixup will just fail in such case. > >>>>> > >>>>> In general board should not generally need nor use this functionality > >>>>> and should be just deprecated, passing mtdparts= in the kernel command > >>>>> line is the preferred way according to Linux MTD subsystem maintainer. Just to be clear, I'm perfectly fine with the partitions being either on the cmdline or in the DT without preference (well, the cmdline only works with the simple generic parser, but whatever). What I really meant is that tweaking the DT from U-Boot should be rare and in no case the "right thing to add partitions". > >>>>> > >>>>> Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > >>>>> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > >>>>> Cc: Marek Vasut <marex@denx.de> > >>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com> > >>>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > >>>>> --- > >>>>> common/fdt_support.c | 45 ++++++++++++++++++++++++++++++++++---------- > >>>>> 1 file changed, 35 insertions(+), 10 deletions(-) > >>>>> > >>>>> diff --git a/common/fdt_support.c b/common/fdt_support.c > >>>>> index dbceec6f2dcc..3aee826e60cf 100644 > >>>>> --- a/common/fdt_support.c > >>>>> +++ b/common/fdt_support.c > >>>>> @@ -877,27 +877,20 @@ static int fdt_del_partitions(void *blob, int parent_offset) > >>>>> return 0; > >>>>> } > >>>>> -static int fdt_node_set_part_info(void *blob, int parent_offset, > >>>>> +/* This expects #address-cells and #size-cells to have same value */ > >>>>> +static int fdt_node_set_part_info(void *blob, int parent_offset, int sizecell, > >>>>> struct mtd_device *dev) > >>>>> { > >>>>> struct list_head *pentry; > >>>>> struct part_info *part; > >>>>> int off, ndepth = 0; > >>>>> int part_num, ret; > >>>>> - int sizecell; > >>>>> char buf[64]; > >>>>> ret = fdt_del_partitions(blob, parent_offset); > >>>>> if (ret < 0) > >>>>> return ret; > >>>>> - /* > >>>>> - * Check if size/address is 1 or 2 cells. > >>>>> - * We assume #address-cells and #size-cells have same value. > >>>>> - */ > >>>>> - sizecell = fdt_getprop_u32_default_node(blob, parent_offset, > >>>>> - 0, "#size-cells", 1); > >>>>> - > >>>>> /* > >>>>> * Check if it is nand {}; subnode, adjust > >>>>> * the offset in this case > >>>>> @@ -992,6 +985,31 @@ err_prop: > >>>>> return ret; > >>>>> } > >>>>> +static int fdt_mtdparts_cell_cnt(void *fdt, int off) > >>>>> +{ > >>>>> + int sizecell, addrcell; > >>>>> + > >>>>> + sizecell = fdt_getprop_u32_default_node(fdt, off, 0, "#size-cells", 0); > >>>>> + if (sizecell != 1 && sizecell != 2) { > >>>>> + printf("%s: Invalid or missing #size-cells %d value, assuming 1\n", > >>>>> + __func__, sizecell); > >>>>> + > >>>>> + sizecell = 1; > >>>>> + if (fdt_setprop_u32(fdt, off, "#size-cells", sizecell)) > >>>>> + return -1; > >>>>> + } > >>>>> + > >>>>> + addrcell = fdt_getprop_u32_default_node(fdt, off, 0, > >>>>> + "#address-cells", 0); > >>>>> + if (addrcell != sizecell) { > >>>>> + printf("%s: Invalid #address-cells %d != #size-cells %d, aborting\n", > >>>>> + __func__, addrcell, sizecell); > >>>>> + return -1; > >>>>> + } > >>>>> + > >>>>> + return sizecell; > >>>>> +} > >>>>> + > >>>>> /* > >>>>> * Update partitions in nor/nand nodes using info from > >>>>> * mtdparts environment variable. The nodes to update are > >>>>> @@ -1037,12 +1055,19 @@ void fdt_fixup_mtdparts(void *blob, const struct node_info *node_info, > >>>>> dev = device_find(node_info[i].type, idx++); > >>>>> if (dev) { > >>>>> + int cell; > >>>>> + > >>>>> parts = fdt_subnode_offset(blob, noff, > >>>>> "partitions"); > >>>>> if (parts < 0) > >>>>> parts = noff; > >>>>> - if (fdt_node_set_part_info(blob, parts, dev)) > >>>>> + cell = fdt_mtdparts_cell_cnt(blob, parts); > >>>>> + if (cell < 0) > >>>>> + return; > >>>>> + > >>>>> + if (fdt_node_set_part_info(blob, parts, > >>>>> + cell, dev)) > >>>>> return; /* return on error */ > >>>>> } > >>>>> } > >>>> > >>>> Can you please include the resulting gpmi node content with this fixup > >>>> applied in the commit message , so it can be validated ? > >>> > >>> I will add it to v2, I would wait a little bit more time to get > >>> additional feedback sending it however. > >>> > >>> In the meantime here the output, but nothing really changed! > >>> What this change is doing is just > >>> - setting #size-cells to <1> when it is invalid > >>> - skip generation at all when #size-cells != #address-cells. Former > >>> code was just generating a broken table without any error > >>> message. > >>> > >>> Here what is generated for colibri-imx7 > >>> > >>> nand-controller@33002000 { > >>> compatible = "fsl,imx7d-gpmi-nand"; > >>> > >>> #address-cells = <0x01>; > >>> #size-cells = <0x01>; > >>> > >>> [...snip...] > >>> > >>> partition@0 { > >>> label = "mx7-bcb"; > >>> reg = <0x00 0x80000>; > >>> }; > >>> > >>> partition@400000 { > >>> label = "ubi"; > >>> reg = <0x400000 0x1fc00000>; > >>> }; > >>> > >>> partition@80000 { > >>> read_only; > >>> label = "u-boot1"; > >>> reg = <0x80000 0x180000>; > >>> }; > >>> > >>> partition@380000 { > >>> label = "u-boot-env"; > >>> reg = <0x380000 0x80000>; > >>> }; > >>> > >>> partition@200000 { > >>> read_only; > >>> label = "u-boot2"; > >>> reg = <0x200000 0x180000>; > >>> }; > >>> }; > >> > >> This is what I was afraid of, shouldn't this contain the partitions in > >> per-chipselect sub-node instead of directly in the GPMI node ? > > > > That does not exists in my source DTS, this function just look for a > > partitions node and update it when it exists. > > I do not have a nand chip, and I do not want to add. > > I know. I wonder if the function should convert the bindings to latest greatest, but I am starting to feel like hard-coding this kind of complex logic into bootloader is not a great idea . As long as the function is deprecated (because that is not a pertinent way of declaring partitions on the long run) I'm fine with keeping the partitions in the root controller node, there is little we can do about it now anyway. > > The reason is what I wrote in my other email, if I would do something > > like older U-Boot's would ignore it and just generate the partitions > > as direct children of the nand-controller. > > > > Commit 36fee2f7621e ("common: fdt_support: add support for "partitions" > > subnode to fdt_fixup_mtdparts()") was introduced only in v2022.04. > > There is the Linux BOOT_CONFIG , that might be some sort of alternative to complex kernel command line, but that's a bit more work. I figured I'd mention it here. Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-23 9:56 ` Miquel Raynal @ 2023-01-24 8:41 ` Francesco Dolcini 2023-01-24 8:58 ` Miquel Raynal 0 siblings, 1 reply; 16+ messages in thread From: Francesco Dolcini @ 2023-01-24 8:41 UTC (permalink / raw) To: Miquel Raynal Cc: Marek Vasut, Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, linux-mtd Hello Miquel, On Mon, Jan 23, 2023 at 10:56:10AM +0100, Miquel Raynal wrote: > marex@denx.de wrote on Tue, 17 Jan 2023 01:59:54 +0100: > > > On 1/16/23 19:00, Francesco Dolcini wrote: > > > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > > >> On 1/16/23 15:20, Francesco Dolcini wrote: > > >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > > >>>> On 1/13/23 19:45, Francesco Dolcini wrote: > > >>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> > > >>>>> > > >>>>> Fixup #size-cells value when updating the MTD partitions, this is > > >>>>> required to prevent issues in case the MTD parent set #size-cells to > > >>>>> zero. > > >>>>> This could happen for example in the legacy case in which the partitions > > >>>>> are created as direct child of the mtd node and that specific node has > > >>>>> no children. Recent clean-up on Linux device tree files created a boot > > >>>>> regression on colibri-imx7. > > >>>>> > > >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) > > >>>>> addressing, therefore it will not work with device bigger than 4GiB. > > >>>>> > > >>>>> This change also enforce #address-cells to be the same as #size-cells, > > >>>>> this was already silently enforced by fdt_node_set_part_info(), now this > > >>>>> is checked explicitly and partition fixup will just fail in such case. > > >>>>> > > >>>>> In general board should not generally need nor use this functionality > > >>>>> and should be just deprecated, passing mtdparts= in the kernel command > > >>>>> line is the preferred way according to Linux MTD subsystem maintainer. > > Just to be clear, I'm perfectly fine with the partitions being either > on the cmdline or in the DT without preference (well, the cmdline only > works with the simple generic parser, but whatever). What I really > meant is that tweaking the DT from U-Boot should be rare and in no case > the "right thing to add partitions". Miquel, should I send a v2 to clarify the commit message or you do not mind keeping it as it is? Francesco ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-24 8:41 ` Francesco Dolcini @ 2023-01-24 8:58 ` Miquel Raynal 2023-01-24 10:24 ` Francesco Dolcini 0 siblings, 1 reply; 16+ messages in thread From: Miquel Raynal @ 2023-01-24 8:58 UTC (permalink / raw) To: Francesco Dolcini Cc: Marek Vasut, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, linux-mtd Hi Francesco, francesco@dolcini.it wrote on Tue, 24 Jan 2023 09:41:41 +0100: > Hello Miquel, > > On Mon, Jan 23, 2023 at 10:56:10AM +0100, Miquel Raynal wrote: > > marex@denx.de wrote on Tue, 17 Jan 2023 01:59:54 +0100: > > > > > On 1/16/23 19:00, Francesco Dolcini wrote: > > > > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > > > >> On 1/16/23 15:20, Francesco Dolcini wrote: > > > >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > > > >>>> On 1/13/23 19:45, Francesco Dolcini wrote: > > > >>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > >>>>> > > > >>>>> Fixup #size-cells value when updating the MTD partitions, this is > > > >>>>> required to prevent issues in case the MTD parent set #size-cells to > > > >>>>> zero. > > > >>>>> This could happen for example in the legacy case in which the partitions > > > >>>>> are created as direct child of the mtd node and that specific node has > > > >>>>> no children. Recent clean-up on Linux device tree files created a boot > > > >>>>> regression on colibri-imx7. > > > >>>>> > > > >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) > > > >>>>> addressing, therefore it will not work with device bigger than 4GiB. > > > >>>>> > > > >>>>> This change also enforce #address-cells to be the same as #size-cells, > > > >>>>> this was already silently enforced by fdt_node_set_part_info(), now this > > > >>>>> is checked explicitly and partition fixup will just fail in such case. > > > >>>>> > > > >>>>> In general board should not generally need nor use this functionality > > > >>>>> and should be just deprecated, passing mtdparts= in the kernel command > > > >>>>> line is the preferred way according to Linux MTD subsystem maintainer. > > > > Just to be clear, I'm perfectly fine with the partitions being either > > on the cmdline or in the DT without preference (well, the cmdline only > > works with the simple generic parser, but whatever). What I really > > meant is that tweaking the DT from U-Boot should be rare and in no case > > the "right thing to add partitions". > > Miquel, should I send a v2 to clarify the commit message or you do not > mind keeping it as it is? I think it is worth mentioning, also adding Tom's remark: - Describing the partitions on the cmdline or in the DT is the right thing to do. - Tweaking the DT to add static partitions should be forbidden. - In some rare legacy cases, dynamic changes to the partitions might be tolerated. Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup 2023-01-24 8:58 ` Miquel Raynal @ 2023-01-24 10:24 ` Francesco Dolcini 0 siblings, 0 replies; 16+ messages in thread From: Francesco Dolcini @ 2023-01-24 10:24 UTC (permalink / raw) To: Miquel Raynal, Simon Glass, u-boot, Tom Rini Cc: Francesco Dolcini, Marek Vasut, Marcel Ziswiler, Francesco Dolcini, linux-mtd On Tue, Jan 24, 2023 at 09:58:15AM +0100, Miquel Raynal wrote: > francesco@dolcini.it wrote on Tue, 24 Jan 2023 09:41:41 +0100: > > On Mon, Jan 23, 2023 at 10:56:10AM +0100, Miquel Raynal wrote: > > > marex@denx.de wrote on Tue, 17 Jan 2023 01:59:54 +0100: > > > > > > > On 1/16/23 19:00, Francesco Dolcini wrote: > > > > > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > > > > >> On 1/16/23 15:20, Francesco Dolcini wrote: > > > > >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > > > > >>>> On 1/13/23 19:45, Francesco Dolcini wrote: > > > > >>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > >>>>> > > > > >>>>> Fixup #size-cells value when updating the MTD partitions, this is > > > > >>>>> required to prevent issues in case the MTD parent set #size-cells to > > > > >>>>> zero. > > > > >>>>> This could happen for example in the legacy case in which the partitions > > > > >>>>> are created as direct child of the mtd node and that specific node has > > > > >>>>> no children. Recent clean-up on Linux device tree files created a boot > > > > >>>>> regression on colibri-imx7. > > > > >>>>> > > > > >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) > > > > >>>>> addressing, therefore it will not work with device bigger than 4GiB. > > > > >>>>> > > > > >>>>> This change also enforce #address-cells to be the same as #size-cells, > > > > >>>>> this was already silently enforced by fdt_node_set_part_info(), now this > > > > >>>>> is checked explicitly and partition fixup will just fail in such case. > > > > >>>>> > > > > >>>>> In general board should not generally need nor use this functionality > > > > >>>>> and should be just deprecated, passing mtdparts= in the kernel command > > > > >>>>> line is the preferred way according to Linux MTD subsystem maintainer. > > > > > > Just to be clear, I'm perfectly fine with the partitions being either > > > on the cmdline or in the DT without preference (well, the cmdline only > > > works with the simple generic parser, but whatever). What I really > > > meant is that tweaking the DT from U-Boot should be rare and in no case > > > the "right thing to add partitions". > > > > Miquel, should I send a v2 to clarify the commit message or you do not > > mind keeping it as it is? > > I think it is worth mentioning, also adding Tom's remark: > - Describing the partitions on the cmdline or in the DT is the right > thing to do. > - Tweaking the DT to add static partitions should be forbidden. > - In some rare legacy cases, dynamic changes to the partitions might be > tolerated. Agreed, I'll wait a little bit sending a v2 to see how the discussion progresses and to see if there are concerns on the actual code change. Francesco ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 0/3] fdt: Fix mtparts fixup 2023-01-13 18:45 [PATCH v1 0/3] fdt: Fix mtparts fixup Francesco Dolcini 2023-01-13 18:45 ` [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Francesco Dolcini @ 2023-01-13 19:34 ` Tom Rini 2023-01-23 10:06 ` Miquel Raynal 1 sibling, 1 reply; 16+ messages in thread From: Tom Rini @ 2023-01-13 19:34 UTC (permalink / raw) To: Francesco Dolcini, Miquel Raynal Cc: Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Marek Vasut, linux-mtd [-- Attachment #1.1: Type: text/plain, Size: 1609 bytes --] On Fri, Jan 13, 2023 at 07:45:44PM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Recently we had a boot regression on colibri-imx7 because of a cleanup change > on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. > > Because of that Linux partition parser was no longer able to properly > parse the OF partitions leading to a boot failure, the above change was > reverted in the meantime as an immediate workaround, but some improvement > is required on both Linux and U-Boot. > > This change improve the U-Boot part of it, #size-cell is set to 1 when > it has an invalid value. This has the limitation to work only with devices > smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would > be to just deprecate using this U-Boot function and pass the MTD partitions > from the command line, unless they are statically defined in the DTS file > in the first place. > > This series therefore convert colibri-imx6ull and colibri-imx7 to pass the > partition list from the command line instead of fixing up the DT. > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ My higher level question / concern here is, is using one of the dts partition schemes still valid / preferred, or should everyone now have reverted to passing via the kernel command line? If device tree still, is mtd/partitions/fixed-partitions.yaml the one to follow or something else? -- Tom [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 0/3] fdt: Fix mtparts fixup 2023-01-13 19:34 ` [PATCH v1 0/3] fdt: Fix mtparts fixup Tom Rini @ 2023-01-23 10:06 ` Miquel Raynal 2023-01-23 20:01 ` Tom Rini 0 siblings, 1 reply; 16+ messages in thread From: Miquel Raynal @ 2023-01-23 10:06 UTC (permalink / raw) To: Tom Rini Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Marek Vasut, linux-mtd Hi Tom, trini@konsulko.com wrote on Fri, 13 Jan 2023 14:34:11 -0500: > On Fri, Jan 13, 2023 at 07:45:44PM +0100, Francesco Dolcini wrote: > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Recently we had a boot regression on colibri-imx7 because of a cleanup change > > on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. > > > > Because of that Linux partition parser was no longer able to properly > > parse the OF partitions leading to a boot failure, the above change was > > reverted in the meantime as an immediate workaround, but some improvement > > is required on both Linux and U-Boot. > > > > This change improve the U-Boot part of it, #size-cell is set to 1 when > > it has an invalid value. This has the limitation to work only with devices > > smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would > > be to just deprecate using this U-Boot function and pass the MTD partitions > > from the command line, unless they are statically defined in the DTS file > > in the first place. > > > > This series therefore convert colibri-imx6ull and colibri-imx7 to pass the > > partition list from the command line instead of fixing up the DT. > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > > My higher level question / concern here is, is using one of the dts > partition schemes still valid / preferred, or should everyone now have > reverted to passing via the kernel command line? If device tree still, > is mtd/partitions/fixed-partitions.yaml the one to follow or something > else? I don't think we can "prefer" one mode over the other between cmdline and DTS. Both should work pretty well. Of course on the cmdline you can only define fixed partitions and many devices require more advanced parsers, which are only available through DTS, but for simple partitions, it works totally okay. The only thing that I would like to avoid is the need to write code in the bootloaders to tweak the FDT in order to add partitions. That is clearly not needed, error prone, and do not follow evolution of the "standard", as we just discovered. Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 0/3] fdt: Fix mtparts fixup 2023-01-23 10:06 ` Miquel Raynal @ 2023-01-23 20:01 ` Tom Rini 2023-02-23 10:23 ` Patrick DELAUNAY 0 siblings, 1 reply; 16+ messages in thread From: Tom Rini @ 2023-01-23 20:01 UTC (permalink / raw) To: Miquel Raynal Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Marek Vasut, linux-mtd, Patrick Delaunay, Patrice Chotard [-- Attachment #1.1: Type: text/plain, Size: 3368 bytes --] On Mon, Jan 23, 2023 at 11:06:06AM +0100, Miquel Raynal wrote: > Hi Tom, > > trini@konsulko.com wrote on Fri, 13 Jan 2023 14:34:11 -0500: > > > On Fri, Jan 13, 2023 at 07:45:44PM +0100, Francesco Dolcini wrote: > > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > Recently we had a boot regression on colibri-imx7 because of a cleanup change > > > on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. > > > > > > Because of that Linux partition parser was no longer able to properly > > > parse the OF partitions leading to a boot failure, the above change was > > > reverted in the meantime as an immediate workaround, but some improvement > > > is required on both Linux and U-Boot. > > > > > > This change improve the U-Boot part of it, #size-cell is set to 1 when > > > it has an invalid value. This has the limitation to work only with devices > > > smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would > > > be to just deprecate using this U-Boot function and pass the MTD partitions > > > from the command line, unless they are statically defined in the DTS file > > > in the first place. > > > > > > This series therefore convert colibri-imx6ull and colibri-imx7 to pass the > > > partition list from the command line instead of fixing up the DT. > > > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > > > > My higher level question / concern here is, is using one of the dts > > partition schemes still valid / preferred, or should everyone now have > > reverted to passing via the kernel command line? If device tree still, > > is mtd/partitions/fixed-partitions.yaml the one to follow or something > > else? > > I don't think we can "prefer" one mode over the other between cmdline > and DTS. Both should work pretty well. Of course on the cmdline you can > only define fixed partitions and many devices require more advanced > parsers, which are only available through DTS, but for simple > partitions, it works totally okay. When both are present, which one is used? > The only thing that I would like to avoid is the need to write code in > the bootloaders to tweak the FDT in order to add partitions. That is > clearly not needed, error prone, and do not follow evolution of the > "standard", as we just discovered. I'm not sure about this. Looking around in U-Boot today, I see two types of cases. One of which, the colibri case, can clearly be not done and either passed on the command line, or put in to the device tree as there's nothing run-time related being tweaked here. That's a fine path to take on those platforms and Francesco's patches should be updated to remove the unused C code too from the board code. But the other cases are doing something dynamic and run-time related. There's the omap3 igep00x0 family (which yes, legacy) that is doing NAND or oneNAND and adjusting things at run time. I don't know how much anyone has interest in those platforms at this point, nor exactly who to contact (for Linux or U-Boot). There's also the stm32mp1 family doing something that's very not obvious at first glance, so I've cc'd the maintainers there. -- Tom [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 0/3] fdt: Fix mtparts fixup 2023-01-23 20:01 ` Tom Rini @ 2023-02-23 10:23 ` Patrick DELAUNAY 2023-02-23 22:35 ` Tom Rini 0 siblings, 1 reply; 16+ messages in thread From: Patrick DELAUNAY @ 2023-02-23 10:23 UTC (permalink / raw) To: Tom Rini, Miquel Raynal, Patrice Chotard Cc: Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Marek Vasut, linux-mtd Hi, On 1/23/23 21:01, Tom Rini wrote: > On Mon, Jan 23, 2023 at 11:06:06AM +0100, Miquel Raynal wrote: >> Hi Tom, >> >> trini@konsulko.com wrote on Fri, 13 Jan 2023 14:34:11 -0500: >> >>> On Fri, Jan 13, 2023 at 07:45:44PM +0100, Francesco Dolcini wrote: >>> >>>> From: Francesco Dolcini <francesco.dolcini@toradex.com> >>>> >>>> Recently we had a boot regression on colibri-imx7 because of a cleanup change >>>> on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. >>>> >>>> Because of that Linux partition parser was no longer able to properly >>>> parse the OF partitions leading to a boot failure, the above change was >>>> reverted in the meantime as an immediate workaround, but some improvement >>>> is required on both Linux and U-Boot. >>>> >>>> This change improve the U-Boot part of it, #size-cell is set to 1 when >>>> it has an invalid value. This has the limitation to work only with devices >>>> smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would >>>> be to just deprecate using this U-Boot function and pass the MTD partitions >>>> from the command line, unless they are statically defined in the DTS file >>>> in the first place. >>>> >>>> This series therefore convert colibri-imx6ull and colibri-imx7 to pass the >>>> partition list from the command line instead of fixing up the DT. >>>> >>>> Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ >>>> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ >>> My higher level question / concern here is, is using one of the dts >>> partition schemes still valid / preferred, or should everyone now have >>> reverted to passing via the kernel command line? If device tree still, >>> is mtd/partitions/fixed-partitions.yaml the one to follow or something >>> else? >> I don't think we can "prefer" one mode over the other between cmdline >> and DTS. Both should work pretty well. Of course on the cmdline you can >> only define fixed partitions and many devices require more advanced >> parsers, which are only available through DTS, but for simple >> partitions, it works totally okay. > When both are present, which one is used? > >> The only thing that I would like to avoid is the need to write code in >> the bootloaders to tweak the FDT in order to add partitions. That is >> clearly not needed, error prone, and do not follow evolution of the >> "standard", as we just discovered. > I'm not sure about this. Looking around in U-Boot today, I see two types > of cases. One of which, the colibri case, can clearly be not done and > either passed on the command line, or put in to the device tree as > there's nothing run-time related being tweaked here. That's a fine path > to take on those platforms and Francesco's patches should be updated to > remove the unused C code too from the board code. > > But the other cases are doing something dynamic and run-time related. > There's the omap3 igep00x0 family (which yes, legacy) that is doing NAND > or oneNAND and adjusting things at run time. I don't know how much > anyone has interest in those platforms at this point, nor exactly who to > contact (for Linux or U-Boot). There's also the stm32mp1 family doing > something that's very not obvious at first glance, so I've cc'd the > maintainers there. > For information, today for stm32mp1 family we are using the build of MTDPARTS and fdt fixup, only for backward compatibility issue (the MTD partitions change for boot with or without OP-TEE, with or wihtout FIP, with SPL). Today we are already plan to remove this dynamic management and to switch to static MTD partition defined in device tree, as already proposed by Tom in the serie "mtd: spi: nor: force mtd name to "nor%d"" http://patchwork.ozlabs.org/project/uboot/patch/20210916155040.v3.2.Ia461e670c7438478aa8f8939209d45c818ccd284@changeid/ This patchset is already ready, we are currently testing it internally and it should be pushed when it will be validated in our donwstream. Regards Patrick ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v1 0/3] fdt: Fix mtparts fixup 2023-02-23 10:23 ` Patrick DELAUNAY @ 2023-02-23 22:35 ` Tom Rini 0 siblings, 0 replies; 16+ messages in thread From: Tom Rini @ 2023-02-23 22:35 UTC (permalink / raw) To: Patrick DELAUNAY Cc: Miquel Raynal, Patrice Chotard, Francesco Dolcini, Simon Glass, u-boot, Marcel Ziswiler, Francesco Dolcini, Marek Vasut, linux-mtd [-- Attachment #1.1: Type: text/plain, Size: 4502 bytes --] On Thu, Feb 23, 2023 at 11:23:41AM +0100, Patrick DELAUNAY wrote: > Hi, > > On 1/23/23 21:01, Tom Rini wrote: > > On Mon, Jan 23, 2023 at 11:06:06AM +0100, Miquel Raynal wrote: > > > Hi Tom, > > > > > > trini@konsulko.com wrote on Fri, 13 Jan 2023 14:34:11 -0500: > > > > > > > On Fri, Jan 13, 2023 at 07:45:44PM +0100, Francesco Dolcini wrote: > > > > > > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > > > Recently we had a boot regression on colibri-imx7 because of a cleanup change > > > > > on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. > > > > > > > > > > Because of that Linux partition parser was no longer able to properly > > > > > parse the OF partitions leading to a boot failure, the above change was > > > > > reverted in the meantime as an immediate workaround, but some improvement > > > > > is required on both Linux and U-Boot. > > > > > > > > > > This change improve the U-Boot part of it, #size-cell is set to 1 when > > > > > it has an invalid value. This has the limitation to work only with devices > > > > > smaller than 4GiB. In general the suggestion from the Linux MTD maintainer would > > > > > be to just deprecate using this U-Boot function and pass the MTD partitions > > > > > from the command line, unless they are statically defined in the DTS file > > > > > in the first place. > > > > > > > > > > This series therefore convert colibri-imx6ull and colibri-imx7 to pass the > > > > > partition list from the command line instead of fixing up the DT. > > > > > > > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolcini.it/ > > > > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/ > > > > My higher level question / concern here is, is using one of the dts > > > > partition schemes still valid / preferred, or should everyone now have > > > > reverted to passing via the kernel command line? If device tree still, > > > > is mtd/partitions/fixed-partitions.yaml the one to follow or something > > > > else? > > > I don't think we can "prefer" one mode over the other between cmdline > > > and DTS. Both should work pretty well. Of course on the cmdline you can > > > only define fixed partitions and many devices require more advanced > > > parsers, which are only available through DTS, but for simple > > > partitions, it works totally okay. > > When both are present, which one is used? > > > > > The only thing that I would like to avoid is the need to write code in > > > the bootloaders to tweak the FDT in order to add partitions. That is > > > clearly not needed, error prone, and do not follow evolution of the > > > "standard", as we just discovered. > > I'm not sure about this. Looking around in U-Boot today, I see two types > > of cases. One of which, the colibri case, can clearly be not done and > > either passed on the command line, or put in to the device tree as > > there's nothing run-time related being tweaked here. That's a fine path > > to take on those platforms and Francesco's patches should be updated to > > remove the unused C code too from the board code. > > > > But the other cases are doing something dynamic and run-time related. > > There's the omap3 igep00x0 family (which yes, legacy) that is doing NAND > > or oneNAND and adjusting things at run time. I don't know how much > > anyone has interest in those platforms at this point, nor exactly who to > > contact (for Linux or U-Boot). There's also the stm32mp1 family doing > > something that's very not obvious at first glance, so I've cc'd the > > maintainers there. > > > > For information, today for stm32mp1 family we are using the build > > of MTDPARTS and fdt fixup, only for backward compatibility issue > > (the MTD partitions change for boot with or without OP-TEE, > > with or wihtout FIP, with SPL). > > > Today we are already plan to remove this dynamic management > > and to switch to static MTD partition defined in device tree, > > as already proposed by Tom in the serie > > "mtd: spi: nor: force mtd name to "nor%d"" > > http://patchwork.ozlabs.org/project/uboot/patch/20210916155040.v3.2.Ia461e670c7438478aa8f8939209d45c818ccd284@changeid/ > > > This patchset is already ready, we are currently testing it internally > > and it should be pushed when it will be validated in our donwstream. Great, thanks. -- Tom [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2023-02-23 22:35 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-01-13 18:45 [PATCH v1 0/3] fdt: Fix mtparts fixup Francesco Dolcini 2023-01-13 18:45 ` [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Francesco Dolcini 2023-01-15 14:35 ` Marek Vasut 2023-01-16 14:20 ` Francesco Dolcini 2023-01-16 17:54 ` Marek Vasut 2023-01-16 18:00 ` Francesco Dolcini 2023-01-17 0:59 ` Marek Vasut 2023-01-23 9:56 ` Miquel Raynal 2023-01-24 8:41 ` Francesco Dolcini 2023-01-24 8:58 ` Miquel Raynal 2023-01-24 10:24 ` Francesco Dolcini 2023-01-13 19:34 ` [PATCH v1 0/3] fdt: Fix mtparts fixup Tom Rini 2023-01-23 10:06 ` Miquel Raynal 2023-01-23 20:01 ` Tom Rini 2023-02-23 10:23 ` Patrick DELAUNAY 2023-02-23 22:35 ` Tom Rini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).