From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Yixun Lan <yixun.lan@amlogic.com>, <oxffffaa@gmail.com>,
<kernel@sberdevices.ru>, <linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read
Date: Wed, 12 Apr 2023 09:47:02 +0200 [thread overview]
Message-ID: <20230412094651.39f4dbf6@xps-13> (raw)
In-Reply-To: <20230412094400.3c82f631@xps-13>
Hi again,
miquel.raynal@bootlin.com wrote on Wed, 12 Apr 2023 09:44:00 +0200:
> Hi Arseniy,
>
> AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +0300:
>
> > This NAND reads only few user's bytes in ECC mode (not full OOB), so
>
> "This NAND reads" does not look right, do you mean "Subpage reads do
> not retrieve all the OOB bytes,"?
>
> > fill OOB buffer with zeroes to not return garbage from previous reads
> > to user.
> > Otherwise 'nanddump' utility prints something like this for just erased
> > page:
> >
> > ...
> > 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> > OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be
> > OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e
> > OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff
> > OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e
> >
> > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> > ---
> > drivers/mtd/nand/raw/meson_nand.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> > index f84a10238e4d..f2f2472cb511 100644
> > --- a/drivers/mtd/nand/raw/meson_nand.c
> > +++ b/drivers/mtd/nand/raw/meson_nand.c
> > @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct nand_chip *nand,
> > static int meson_nfc_read_page_raw(struct nand_chip *nand, u8 *buf,
> > int oob_required, int page)
> > {
> > + struct mtd_info *mtd = nand_to_mtd(nand);
> > u8 *oob_buf = nand->oob_poi;
> > int ret;
> >
> > + memset(oob_buf, 0, mtd->oobsize);
Should use 0xff instead of 0x00, that's the default state of a NAND
cell.
And also this memset should be conditioned to 'oob_required' I
guess?
>
> I'm surprised raw reads do not read the entire OOB?
>
> > +
> > ret = meson_nfc_read_page_sub(nand, page, 1);
> > if (ret)
> > return ret;
> > @@ -881,6 +884,8 @@ static int meson_nfc_read_page_hwecc(struct nand_chip *nand, u8 *buf,
> > u8 *oob_buf = nand->oob_poi;
> > int ret, i;
> >
> > + memset(oob_buf, 0, mtd->oobsize);
> > +
> > ret = meson_nfc_read_page_sub(nand, page, 0);
> > if (ret)
> > return ret;
>
>
> Thanks,
> Miquèl
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-04-12 7:47 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 6:16 [PATCH v1 0/5] refactoring and fix for Meson NAND Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 1/5] mtd: rawnand: meson: fix NAND access for read/write Arseniy Krasnov
2023-04-12 9:37 ` Liang Yang
2023-04-12 10:24 ` Arseniy Krasnov
2023-04-12 12:03 ` Arseniy Krasnov
2023-04-12 13:30 ` Liang Yang
2023-04-13 5:10 ` Arseniy Krasnov
2023-04-13 5:57 ` Liang Yang
2023-04-17 6:47 ` Arseniy Krasnov
2023-04-17 13:54 ` Liang Yang
2023-04-17 14:10 ` Arseniy Krasnov
2023-04-19 19:43 ` Arseniy Krasnov
2023-04-20 14:22 ` Liang Yang
2023-04-21 5:57 ` Arseniy Krasnov
2023-04-26 7:53 ` Arseniy Krasnov
2023-04-26 12:17 ` Liang Yang
2023-04-26 14:47 ` Arseniy Krasnov
2023-05-04 6:16 ` Arseniy Krasnov
2023-05-10 11:34 ` Arseniy Krasnov
2023-05-11 10:43 ` Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define Arseniy Krasnov
2023-04-12 7:37 ` Neil Armstrong
2023-04-12 10:06 ` David Laight
2023-04-12 10:11 ` Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Arseniy Krasnov
2023-04-12 7:39 ` Miquel Raynal
2023-04-12 6:16 ` [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Arseniy Krasnov
2023-04-12 7:44 ` Miquel Raynal
2023-04-12 7:47 ` Miquel Raynal [this message]
2023-04-12 9:20 ` Arseniy Krasnov
2023-04-12 9:36 ` Miquel Raynal
2023-04-12 10:14 ` Arseniy Krasnov
2023-04-12 10:51 ` Liang Yang
2023-04-12 11:36 ` Liang Yang
2023-04-12 11:43 ` Dmitry Rokosov
2023-04-12 11:47 ` Arseniy Krasnov
2023-04-12 12:28 ` Liang Yang
2023-04-12 12:18 ` Miquel Raynal
2023-04-12 12:22 ` Arseniy Krasnov
2023-04-12 12:57 ` Miquel Raynal
2023-04-12 14:04 ` Liang Yang
2023-04-12 14:32 ` Miquel Raynal
2023-04-13 5:32 ` Liang Yang
2023-04-13 6:11 ` Liang Yang
2023-04-13 7:00 ` Arseniy Krasnov
2023-04-13 8:22 ` Miquel Raynal
2023-04-13 9:36 ` Arseniy Krasnov
2023-04-13 10:22 ` Miquel Raynal
2023-04-13 10:35 ` Arseniy Krasnov
2023-04-18 5:12 ` Arseniy Krasnov
2023-04-18 12:24 ` Liang Yang
2023-04-18 12:44 ` Arseniy Krasnov
2023-04-18 13:25 ` Miquel Raynal
2023-04-18 14:57 ` Arseniy Krasnov
2023-04-18 15:07 ` Arseniy Krasnov
2023-04-19 3:05 ` Liang Yang
2023-04-19 6:41 ` Arseniy Krasnov
2023-04-20 9:37 ` Arseniy Krasnov
2023-04-26 13:51 ` Liang Yang
2023-04-26 14:46 ` Arseniy Krasnov
2023-05-02 9:59 ` Miquel Raynal
2023-05-02 10:11 ` Arseniy Krasnov
2023-05-02 11:27 ` Miquel Raynal
2023-05-02 11:32 ` Arseniy Krasnov
2023-05-02 12:17 ` Miquel Raynal
2023-05-02 12:24 ` Arseniy Krasnov
2023-05-02 13:05 ` Miquel Raynal
2023-05-02 16:13 ` Arseniy Krasnov
2023-05-03 8:03 ` Miquel Raynal
2023-05-03 10:23 ` Arseniy Krasnov
2023-05-04 11:37 ` Arseniy Krasnov
2023-05-04 12:17 ` Miquel Raynal
2023-05-04 12:31 ` Arseniy Krasnov
2023-05-03 19:48 ` Richard Weinberger
2023-05-04 11:40 ` Arseniy Krasnov
2023-04-13 8:22 ` Miquel Raynal
2023-04-12 19:15 ` Dmitry Rokosov
2023-04-12 20:56 ` Miquel Raynal
2023-04-13 9:27 ` Dmitry Rokosov
2023-04-13 10:29 ` Miquel Raynal
2023-04-13 14:03 ` Dmitry Rokosov
2023-04-12 6:16 ` [PATCH v1 5/5] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
2023-04-12 7:45 ` [PATCH v1 0/5] refactoring and fix for Meson NAND Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412094651.39f4dbf6@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=AVKrasnov@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).