From: Arseniy Krasnov <avkrasnov@sberdevices.ru>
To: David Laight <David.Laight@ACULAB.COM>,
Liang Yang <liang.yang@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Yixun Lan <yixun.lan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>
Cc: "oxffffaa@gmail.com" <oxffffaa@gmail.com>,
"kernel@sberdevices.ru" <kernel@sberdevices.ru>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define
Date: Wed, 12 Apr 2023 13:11:04 +0300 [thread overview]
Message-ID: <8f8d4a22-11ea-3b30-9b95-f27c5209fe5f@sberdevices.ru> (raw)
In-Reply-To: <2f89000bdbbb4e2bb7f1dd96c1b498f9@AcuMS.aculab.com>
On 12.04.2023 13:06, David Laight wrote:
> From: Arseniy Krasnov
>> Sent: 12 April 2023 07:17
>> Subject: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define
>>
> ...
>> len = mtd->writesize + mtd->oobsize;
>> - cmd = (len & GENMASK(13, 0)) | scrambler | DMA_DIR(dir);
>> + cmd = (len & NFC_CMD_RAW_LEN) | scrambler | DMA_DIR(dir);
>> writel(cmd, nfc->reg_base + NFC_REG_CMD);
>
> What is the point of the mask?
> If the length is too big it just generates a different
> 'hard to debug' error.
> If the length can't be too bit there is no point masking it.
Exactly, thanks for pointing!
Thanks, Arseniy
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-04-12 10:15 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 6:16 [PATCH v1 0/5] refactoring and fix for Meson NAND Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 1/5] mtd: rawnand: meson: fix NAND access for read/write Arseniy Krasnov
2023-04-12 9:37 ` Liang Yang
2023-04-12 10:24 ` Arseniy Krasnov
2023-04-12 12:03 ` Arseniy Krasnov
2023-04-12 13:30 ` Liang Yang
2023-04-13 5:10 ` Arseniy Krasnov
2023-04-13 5:57 ` Liang Yang
2023-04-17 6:47 ` Arseniy Krasnov
2023-04-17 13:54 ` Liang Yang
2023-04-17 14:10 ` Arseniy Krasnov
2023-04-19 19:43 ` Arseniy Krasnov
2023-04-20 14:22 ` Liang Yang
2023-04-21 5:57 ` Arseniy Krasnov
2023-04-26 7:53 ` Arseniy Krasnov
2023-04-26 12:17 ` Liang Yang
2023-04-26 14:47 ` Arseniy Krasnov
2023-05-04 6:16 ` Arseniy Krasnov
2023-05-10 11:34 ` Arseniy Krasnov
2023-05-11 10:43 ` Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define Arseniy Krasnov
2023-04-12 7:37 ` Neil Armstrong
2023-04-12 10:06 ` David Laight
2023-04-12 10:11 ` Arseniy Krasnov [this message]
2023-04-12 6:16 ` [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Arseniy Krasnov
2023-04-12 7:39 ` Miquel Raynal
2023-04-12 6:16 ` [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Arseniy Krasnov
2023-04-12 7:44 ` Miquel Raynal
2023-04-12 7:47 ` Miquel Raynal
2023-04-12 9:20 ` Arseniy Krasnov
2023-04-12 9:36 ` Miquel Raynal
2023-04-12 10:14 ` Arseniy Krasnov
2023-04-12 10:51 ` Liang Yang
2023-04-12 11:36 ` Liang Yang
2023-04-12 11:43 ` Dmitry Rokosov
2023-04-12 11:47 ` Arseniy Krasnov
2023-04-12 12:28 ` Liang Yang
2023-04-12 12:18 ` Miquel Raynal
2023-04-12 12:22 ` Arseniy Krasnov
2023-04-12 12:57 ` Miquel Raynal
2023-04-12 14:04 ` Liang Yang
2023-04-12 14:32 ` Miquel Raynal
2023-04-13 5:32 ` Liang Yang
2023-04-13 6:11 ` Liang Yang
2023-04-13 7:00 ` Arseniy Krasnov
2023-04-13 8:22 ` Miquel Raynal
2023-04-13 9:36 ` Arseniy Krasnov
2023-04-13 10:22 ` Miquel Raynal
2023-04-13 10:35 ` Arseniy Krasnov
2023-04-18 5:12 ` Arseniy Krasnov
2023-04-18 12:24 ` Liang Yang
2023-04-18 12:44 ` Arseniy Krasnov
2023-04-18 13:25 ` Miquel Raynal
2023-04-18 14:57 ` Arseniy Krasnov
2023-04-18 15:07 ` Arseniy Krasnov
2023-04-19 3:05 ` Liang Yang
2023-04-19 6:41 ` Arseniy Krasnov
2023-04-20 9:37 ` Arseniy Krasnov
2023-04-26 13:51 ` Liang Yang
2023-04-26 14:46 ` Arseniy Krasnov
2023-05-02 9:59 ` Miquel Raynal
2023-05-02 10:11 ` Arseniy Krasnov
2023-05-02 11:27 ` Miquel Raynal
2023-05-02 11:32 ` Arseniy Krasnov
2023-05-02 12:17 ` Miquel Raynal
2023-05-02 12:24 ` Arseniy Krasnov
2023-05-02 13:05 ` Miquel Raynal
2023-05-02 16:13 ` Arseniy Krasnov
2023-05-03 8:03 ` Miquel Raynal
2023-05-03 10:23 ` Arseniy Krasnov
2023-05-04 11:37 ` Arseniy Krasnov
2023-05-04 12:17 ` Miquel Raynal
2023-05-04 12:31 ` Arseniy Krasnov
2023-05-03 19:48 ` Richard Weinberger
2023-05-04 11:40 ` Arseniy Krasnov
2023-04-13 8:22 ` Miquel Raynal
2023-04-12 19:15 ` Dmitry Rokosov
2023-04-12 20:56 ` Miquel Raynal
2023-04-13 9:27 ` Dmitry Rokosov
2023-04-13 10:29 ` Miquel Raynal
2023-04-13 14:03 ` Dmitry Rokosov
2023-04-12 6:16 ` [PATCH v1 5/5] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
2023-04-12 7:45 ` [PATCH v1 0/5] refactoring and fix for Meson NAND Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f8d4a22-11ea-3b30-9b95-f27c5209fe5f@sberdevices.ru \
--to=avkrasnov@sberdevices.ru \
--cc=David.Laight@ACULAB.COM \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).