From: "Roger Pueyo Centelles | Guifi.net" <roger.pueyo@guifi.net>
To: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org
Cc: marek.vasut@gmail.com
Subject: Re: [PATCH] mtd: spi-nor: Add support for en25qh64
Date: Wed, 30 Jan 2019 15:36:26 +0100 [thread overview]
Message-ID: <3fae6459-66d2-363d-adc5-d3f3758dd82d@guifi.net> (raw)
In-Reply-To: <2ecd524a-9ba7-aef0-0846-5db9ed2cef01@microchip.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1910 bytes --]
Hi Tudor,
El 10/1/19 a les 18:21, Tudor.Ambarus@microchip.com ha escrit:
> Hi, Roger,
>
> On 12/27/2018 05:03 PM, Roger Pueyo Centelles wrote:
>> The Eon EN25QH64 is a 64 Mbit SPI NOR flash memory chip found
>> on recent wireless routers. Its 32, 128 and 256 Mbit siblings
>> are alredy supported.
> s/alredy/already
>
>> Tested on a COMFAST CF-E120A v3 board.
>>
>> Signed-off-by: Roger Pueyo Centelles <roger.pueyo@guifi.net>
>> ---
>> drivers/mtd/spi-nor/spi-nor.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 6e13bbd1aaa5..4bb6f4d203dc 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1741,6 +1741,7 @@ static const struct flash_info spi_nor_ids[] = {
>> { "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
>> { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
>> { "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) },
>> + { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128, 0) },
> The flash supports 4KiB erase type, so you'll have to set SECT_4K. One can use
> larger sectors, when available, by disabling CONFIG_MTD_SPI_NOR_USE_4K_SECTORS.
You're right, I'm setting it.
>
> Also, the flash supports SPINOR_OP_READ_1_1_2, so it's better to set
> SPI_NOR_DUAL_READ in order to trigger the bfpt parsing. Note that at bfpt
> parsing, SPINOR_OP_PP_1_4_4 will be enabled and the reads should be done with
> the ebh command. Please test if these assumptions are valid, and if correct,
> submit a new patch.
Do you mean that I just have to add SPI_NOR_DUAL_READ, and not
SPI_NOR_QUAD_READ also? The chip's datasheet [1] says it supports both
DUAL and QUAD modes; I tried setting both flags, and it works fine.
Cheers,
Roger
[1] http://www.bdtic.com/datasheet/EON/EN25QH64.pdf
>
> Cheers,
> ta
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-01-30 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 15:03 [PATCH] mtd: spi-nor: Add support for en25qh64 Roger Pueyo Centelles
2019-01-10 17:21 ` Tudor.Ambarus
2019-01-30 14:36 ` Roger Pueyo Centelles | Guifi.net [this message]
2019-01-30 16:09 ` Tudor.Ambarus
2019-02-07 19:09 ` [PATCH v1] " Roger Pueyo Centelles
2019-02-08 9:39 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fae6459-66d2-363d-adc5-d3f3758dd82d@guifi.net \
--to=roger.pueyo@guifi.net \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).