linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jungseung Lee <js07.lee@samsung.com>
To: "chenxiang (M)" <chenxiang66@hisilicon.com>,
	michael@walle.cc, vigneshr@ti.com
Cc: john.garry@huawei.com, linux-mtd@lists.infradead.org,
	linuxarm@huawei.com, Tudor.Ambarus@microchip.com
Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q128a11
Date: Thu, 16 Apr 2020 19:43:12 +0900	[thread overview]
Message-ID: <6183ebde31712ed29d0422ad8c34de99cb030f42.camel@samsung.com> (raw)
In-Reply-To: <6d329b9b-153f-74fa-f94d-1f223b3ee767@hisilicon.com>

Hi, chenxiang

On Tue, 2020-04-14 at 09:16 +0800, chenxiang (M) wrote:
> Ping...
> 
> 在 2020/3/25 11:07, chenxiang 写道:
> > From: Xiang Chen <chenxiang66@hisilicon.com>
> > 
> > As 4bit block protection pathset for some micron models are merged,

you mean patchset?

> > n25q128a11 also uses 4 bit Block Protection scheme, so enable
> > locking
> > for it. Tested it on n25q128a11, the locking functions work well.
> > 
> > Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
> > ---
> >   drivers/mtd/spi-nor/micron-st.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-
> > nor/micron-st.c
> > index 6c034b9..02c0b53 100644
> > --- a/drivers/mtd/spi-nor/micron-st.c
> > +++ b/drivers/mtd/spi-nor/micron-st.c
> > @@ -29,7 +29,9 @@ static const struct flash_info st_parts[] = {
> >   	{ "n25q064a",    INFO(0x20bb17, 0, 64 * 1024,  128,
> >   			      SECT_4K | SPI_NOR_QUAD_READ) },
> >   	{ "n25q128a11",  INFO(0x20bb18, 0, 64 * 1024,  256,
> > -			      SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
> > +			      SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
> > +			      SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
> > +			      SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6) },
> >   	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256,
> >   			      SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
> >   	{ "mt25ql256a",  INFO6(0x20ba19, 0x104400, 64 * 1024,  512,

I've checked the flags according to it's datasheet. It seems good.
You can add my review tag after update the typo.

Reviewed-by: Jungseung Lee <js07.lee@samsung.com>

Thanks,

> 
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-16 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  3:07 [PATCH] mtd: spi-nor: Enable locking for n25q128a11 chenxiang
2020-04-14  1:16 ` chenxiang (M)
2020-04-16 10:43   ` Jungseung Lee [this message]
2020-04-17  1:06     ` chenxiang (M)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6183ebde31712ed29d0422ad8c34de99cb030f42.camel@samsung.com \
    --to=js07.lee@samsung.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=john.garry@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxarm@huawei.com \
    --cc=michael@walle.cc \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).