* [PATCH v2] mtd: spinand: read return badly if the last page has bitflips
@ 2019-06-20 1:00 liaoweixiong
2019-06-20 7:13 ` Boris Brezillon
2019-06-24 7:37 ` Schrempf Frieder
0 siblings, 2 replies; 4+ messages in thread
From: liaoweixiong @ 2019-06-20 1:00 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Vignesh Raghavendra, Boris Brezillon,
Frieder Schrempf, Peter Pan, Jeff Kletsky, Schrempf Frieder
Cc: liaoweixiong, linux-mtd, linux-kernel
In case of the last page containing bitflips (ret > 0),
spinand_mtd_read() will return that number of bitflips for the last
page. But to me it looks like it should instead return max_bitflips like
it does when the last page read returns with 0.
Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
---
drivers/mtd/nand/spi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index 556bfdb..6b9388d 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
if (ret == -EBADMSG) {
ecc_failed = true;
mtd->ecc_stats.failed++;
- ret = 0;
} else {
mtd->ecc_stats.corrected += ret;
max_bitflips = max_t(unsigned int, max_bitflips, ret);
}
+ ret = 0;
ops->retlen += iter.req.datalen;
ops->oobretlen += iter.req.ooblen;
}
--
1.9.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips
2019-06-20 1:00 [PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
@ 2019-06-20 7:13 ` Boris Brezillon
2019-06-24 7:37 ` Schrempf Frieder
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2019-06-20 7:13 UTC (permalink / raw)
To: liaoweixiong
Cc: Vignesh Raghavendra, Boris Brezillon, Richard Weinberger,
linux-kernel, Schrempf Frieder, Marek Vasut, Frieder Schrempf,
linux-mtd, Jeff Kletsky, Miquel Raynal, Brian Norris,
David Woodhouse, Peter Pan
On Thu, 20 Jun 2019 09:00:16 +0800
liaoweixiong <liaoweixiong@allwinnertech.com> wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
>
> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/nand/spi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 556bfdb..6b9388d 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
> if (ret == -EBADMSG) {
> ecc_failed = true;
> mtd->ecc_stats.failed++;
> - ret = 0;
> } else {
> mtd->ecc_stats.corrected += ret;
> max_bitflips = max_t(unsigned int, max_bitflips, ret);
> }
>
> + ret = 0;
> ops->retlen += iter.req.datalen;
> ops->oobretlen += iter.req.ooblen;
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips
2019-06-20 1:00 [PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
2019-06-20 7:13 ` Boris Brezillon
@ 2019-06-24 7:37 ` Schrempf Frieder
2019-06-24 12:10 ` liaoweixiong
1 sibling, 1 reply; 4+ messages in thread
From: Schrempf Frieder @ 2019-06-24 7:37 UTC (permalink / raw)
To: liaoweixiong, Miquel Raynal, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Vignesh Raghavendra, Boris Brezillon,
Frieder Schrempf, Peter Pan, Jeff Kletsky
Cc: linux-mtd, linux-kernel
On 20.06.19 03:00, liaoweixiong wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
>
> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
This should probably be resent with the following tags:
Cc: stable@vger.kernel.org
Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI
NANDs")
> ---
> drivers/mtd/nand/spi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 556bfdb..6b9388d 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
> if (ret == -EBADMSG) {
> ecc_failed = true;
> mtd->ecc_stats.failed++;
> - ret = 0;
> } else {
> mtd->ecc_stats.corrected += ret;
> max_bitflips = max_t(unsigned int, max_bitflips, ret);
> }
>
> + ret = 0;
> ops->retlen += iter.req.datalen;
> ops->oobretlen += iter.req.ooblen;
> }
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips
2019-06-24 7:37 ` Schrempf Frieder
@ 2019-06-24 12:10 ` liaoweixiong
0 siblings, 0 replies; 4+ messages in thread
From: liaoweixiong @ 2019-06-24 12:10 UTC (permalink / raw)
To: Schrempf Frieder, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Vignesh Raghavendra,
Boris Brezillon, Frieder Schrempf, Peter Pan, Jeff Kletsky
Cc: linux-mtd, linux-kernel
OK, thanks for your reviewing. I will resend right now.
On 2019/6/24 PM3:37, Schrempf Frieder wrote:
> On 20.06.19 03:00, liaoweixiong wrote:
>> In case of the last page containing bitflips (ret > 0),
>> spinand_mtd_read() will return that number of bitflips for the last
>> page. But to me it looks like it should instead return max_bitflips like
>> it does when the last page read returns with 0.
>>
>> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> This should probably be resent with the following tags:
>
> Cc: stable@vger.kernel.org
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI
> NANDs")
>
>> ---
>> drivers/mtd/nand/spi/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index 556bfdb..6b9388d 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
>> if (ret == -EBADMSG) {
>> ecc_failed = true;
>> mtd->ecc_stats.failed++;
>> - ret = 0;
>> } else {
>> mtd->ecc_stats.corrected += ret;
>> max_bitflips = max_t(unsigned int, max_bitflips, ret);
>> }
>>
>> + ret = 0;
>> ops->retlen += iter.req.datalen;
>> ops->oobretlen += iter.req.ooblen;
>> }
--
liaoweixiong
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-24 12:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-20 1:00 [PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
2019-06-20 7:13 ` Boris Brezillon
2019-06-24 7:37 ` Schrempf Frieder
2019-06-24 12:10 ` liaoweixiong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).