From: Randy Dunlap <rdunlap@infradead.org>
To: Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Mao Wenan <maowenan@huawei.com>
Subject: Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies
Date: Sat, 20 Jul 2019 06:45:40 -0700 [thread overview]
Message-ID: <83175738-a41e-04e6-7be2-85213dfdc416@infradead.org> (raw)
In-Reply-To: <20190719082912.10316-1-vigneshr@ti.com>
On 7/19/19 1:29 AM, Vignesh Raghavendra wrote:
> On x86_64, when CONFIG_OF is not disabled:
>
> WARNING: unmet direct dependencies detected for MUX_MMIO
> Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]
>
> due to
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> select MUX_MMIO
>
> Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so
> that dependencies are taken care of. MUX_MMIO is optional for
> functioning of driver.
>
> Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/mtd/hyperbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
> index cff6bbd226f5..1c691df8eff7 100644
> --- a/drivers/mtd/hyperbus/Kconfig
> +++ b/drivers/mtd/hyperbus/Kconfig
> @@ -15,7 +15,7 @@ if MTD_HYPERBUS
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> - select MUX_MMIO
> + imply MUX_MMIO
> help
> This is the driver for HyperBus controller on TI's AM65x and
> other SoCs
>
--
~Randy
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-20 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:29 [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies Vignesh Raghavendra
2019-07-20 13:45 ` Randy Dunlap [this message]
2019-08-05 7:27 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83175738-a41e-04e6-7be2-85213dfdc416@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maowenan@huawei.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).