* [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies
@ 2019-07-19 8:29 Vignesh Raghavendra
2019-07-20 13:45 ` Randy Dunlap
2019-08-05 7:27 ` Vignesh Raghavendra
0 siblings, 2 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2019-07-19 8:29 UTC (permalink / raw)
To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger
Cc: Randy Dunlap, linux-mtd, linux-kernel, Mao Wenan
On x86_64, when CONFIG_OF is not disabled:
WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n])
Selected by [y]:
- HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]
due to
config HBMC_AM654
tristate "HyperBus controller driver for AM65x SoC"
select MULTIPLEXER
select MUX_MMIO
Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so
that dependencies are taken care of. MUX_MMIO is optional for
functioning of driver.
Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/mtd/hyperbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
index cff6bbd226f5..1c691df8eff7 100644
--- a/drivers/mtd/hyperbus/Kconfig
+++ b/drivers/mtd/hyperbus/Kconfig
@@ -15,7 +15,7 @@ if MTD_HYPERBUS
config HBMC_AM654
tristate "HyperBus controller driver for AM65x SoC"
select MULTIPLEXER
- select MUX_MMIO
+ imply MUX_MMIO
help
This is the driver for HyperBus controller on TI's AM65x and
other SoCs
--
2.22.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies
2019-07-19 8:29 [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies Vignesh Raghavendra
@ 2019-07-20 13:45 ` Randy Dunlap
2019-08-05 7:27 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2019-07-20 13:45 UTC (permalink / raw)
To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger
Cc: linux-mtd, linux-kernel, Mao Wenan
On 7/19/19 1:29 AM, Vignesh Raghavendra wrote:
> On x86_64, when CONFIG_OF is not disabled:
>
> WARNING: unmet direct dependencies detected for MUX_MMIO
> Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]
>
> due to
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> select MUX_MMIO
>
> Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so
> that dependencies are taken care of. MUX_MMIO is optional for
> functioning of driver.
>
> Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/mtd/hyperbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
> index cff6bbd226f5..1c691df8eff7 100644
> --- a/drivers/mtd/hyperbus/Kconfig
> +++ b/drivers/mtd/hyperbus/Kconfig
> @@ -15,7 +15,7 @@ if MTD_HYPERBUS
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> - select MUX_MMIO
> + imply MUX_MMIO
> help
> This is the driver for HyperBus controller on TI's AM65x and
> other SoCs
>
--
~Randy
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies
2019-07-19 8:29 [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies Vignesh Raghavendra
2019-07-20 13:45 ` Randy Dunlap
@ 2019-08-05 7:27 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2019-08-05 7:27 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger
Cc: Randy Dunlap, linux-mtd, linux-kernel, Mao Wenan
On 19/07/19 1:59 PM, Vignesh Raghavendra wrote:
> On x86_64, when CONFIG_OF is not disabled:
>
> WARNING: unmet direct dependencies detected for MUX_MMIO
> Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]
>
> due to
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> select MUX_MMIO
>
> Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so
> that dependencies are taken care of. MUX_MMIO is optional for
> functioning of driver.
>
> Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>> ---
Applied to mtd/fixes.
> drivers/mtd/hyperbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
> index cff6bbd226f5..1c691df8eff7 100644
> --- a/drivers/mtd/hyperbus/Kconfig
> +++ b/drivers/mtd/hyperbus/Kconfig
> @@ -15,7 +15,7 @@ if MTD_HYPERBUS
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> - select MUX_MMIO
> + imply MUX_MMIO
> help
> This is the driver for HyperBus controller on TI's AM65x and
> other SoCs
>
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-19 8:29 [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies Vignesh Raghavendra
2019-07-20 13:45 ` Randy Dunlap
2019-08-05 7:27 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).