From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] mtd: spi-nor: introduce SNOR_ID3()
Date: Tue, 10 May 2022 16:03:46 +0200 [thread overview]
Message-ID: <966de7ad5f563f9a29db91c5309a71c6@walle.cc> (raw)
In-Reply-To: <20220510140232.3519184-1-michael@walle.cc>
[proper subject]
Am 2022-05-10 16:02, schrieb Michael Walle:
> For support which rely solely on the SFDP data, all we need to know is
> its
> JEDEC ID. All further information should be fetched from SFDP. For
> this,
> introduce a SNOR_ID3() macro which should be used for all new flashes
> with
> SFDP.
>
> The dropped information are page size, number of sectors and sector
> size.
> The number of sectors (together with sector size) is only used to
> calculate
> the total flash size. In case of SFDP, this is read from there. The
> sector
> size is also used to select a proper erase opcode. We can just keep
> that
> one zero and the selection algorithm will select the same erase opcode;
> that is the opcode for the largest erase size (which is btw rather
> odd..).
> The page size is also taken from SFDP. There is one exception: older
> SFDP
> tables. These doesn't contain this data. So if there will be flashes
> with
> that, we should assume some sane value.
>
> Shaik, could you please re-test your w25q512nwm support with this
> patch. I
> read through the SFDP data and it should behave exactly the same as
> before.
>
> Michael Walle (2):
> mtd: spi-nor: introduce SNOR_ID3()
> mtd: spi-nor: winbond: use SNOR_ID3() for w25q512nwm
>
> drivers/mtd/spi-nor/core.c | 7 +++++--
> drivers/mtd/spi-nor/core.h | 9 +++++++++
> drivers/mtd/spi-nor/winbond.c | 3 +--
> 3 files changed, 15 insertions(+), 4 deletions(-)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-05-10 14:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:02 [PATCH 0/2] introduce SNOR_ID3() Michael Walle
2022-05-10 14:02 ` [PATCH 1/2] mtd: spi-nor: " Michael Walle
2022-06-05 15:00 ` Tom Fitzhenry
2022-07-12 7:23 ` Pratyush Yadav
2022-07-15 12:19 ` Biju Das
2022-07-19 5:57 ` Tudor.Ambarus
2022-07-19 7:07 ` Michael Walle
2022-07-19 7:33 ` Tudor.Ambarus
2022-07-19 7:57 ` Michael Walle
2022-07-19 8:30 ` Tudor.Ambarus
2022-07-28 3:24 ` Tudor.Ambarus
2022-07-28 13:12 ` Michael Walle
2022-07-28 13:31 ` Tudor.Ambarus
2022-07-28 13:56 ` Michael Walle
2022-05-10 14:02 ` [PATCH 2/2] mtd: spi-nor: winbond: use SNOR_ID3() for w25q512nwm Michael Walle
2022-07-12 8:40 ` Tudor.Ambarus
2022-07-18 7:21 ` Michael Walle
2022-07-18 7:25 ` Michael Walle
2022-07-19 6:00 ` Tudor.Ambarus
2022-07-19 7:02 ` Michael Walle
2022-07-19 7:24 ` Tudor.Ambarus
2022-05-10 14:03 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966de7ad5f563f9a29db91c5309a71c6@walle.cc \
--to=michael@walle.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=quic_c_sbhanu@quicinc.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).