From: Michael Walle <michael@walle.cc>
To: Yaliang Wang <Yaliang.Wang@windriver.com>
Cc: tudor.ambarus@microchip.com, pratyush@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: gigadevice: gd25q256: replace gd25q256_default_init with gd25q256_post_bfpt
Date: Wed, 14 Sep 2022 09:27:19 +0200 [thread overview]
Message-ID: <9b87331960933687145688308e2ab97a@walle.cc> (raw)
In-Reply-To: <948d4846-dd7e-04a3-51e7-588d266cc28e@windriver.com>
Am 2022-09-14 05:05, schrieb Yaliang Wang:
> In case the mail list can't receive the email, I'd like to send the
> email again.
>
> Sorry, I didn't make it clear.
> I'm doing this because the flash info member parse_sfdp is initialized
> to "true" by PARSE_SFDP macro, as you can see below
> { "gd25q256", INFO(0xc84019, 0, 64 * 1024, 512)
> PARSE_SFDP
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
> SPI_NOR_TB_SR_BIT6)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> .fixups = &gd25q256_fixups },
>
> And when parse_sfdp is true, the function spi_nor_init_params() will
> call spi_nor_parse_sfdp() to initialize the parameters, and I can't
> see any other place to call the original default_init() hook in the
> fixups other than in spi_nor_init_params_deprecated() ->
> spi_nor_manufacturer_init_params().
>
> After checking the history of why we are adding this, that is to say
> the commit 48e4d973aefe ("mtd: spi-nor: Add a default_init() fixup
> hook for gd25q256") and the corresponding disscusions, I believe it
> was added for some reason, and we need to add back this function.
>
> On 9/13/22 18:46, Vanessa Page wrote:
>> **[Please note: This e-mail is from an EXTERNAL e-mail address]
>>
>> Why are you doing this?
Vanessa Page is a bot/troll.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-09-14 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 8:40 [PATCH] mtd: spi-nor: gigadevice: gd25q256: replace gd25q256_default_init with gd25q256_post_bfpt yaliang.wang
[not found] ` <MN2PR17MB3375BC0E5878B19651475413B8479@MN2PR17MB3375.namprd17.prod.outlook.com>
2022-09-14 3:05 ` Yaliang Wang
2022-09-14 7:27 ` Michael Walle [this message]
2022-10-03 5:35 ` Tudor.Ambarus
2022-10-16 8:37 ` Yaliang Wang
2022-10-16 17:19 ` [PATCH v2 0/1] " yaliang.wang
2022-10-16 17:19 ` [PATCH] " yaliang.wang
2022-11-21 14:32 ` [PATCH v2 0/1] " Tudor Ambarus
-- strict thread matches above, loose matches on Subject: below --
2022-09-12 14:28 [PATCH] " yaliang.wang
2022-09-12 23:18 ` kernel test robot
2022-09-13 1:43 ` Yaliang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b87331960933687145688308e2ab97a@walle.cc \
--to=michael@walle.cc \
--cc=Yaliang.Wang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).