Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [BUG]: spi-nor: spi_nor_init() fails when SR locked
@ 2020-07-20 18:13 David Clear
  2020-07-21  9:37 ` Tudor.Ambarus
  0 siblings, 1 reply; 3+ messages in thread
From: David Clear @ 2020-07-20 18:13 UTC (permalink / raw)
  To: tudor.ambarus, linux-mtd

Hi Tudor,

I'm seeing a change of behavior in spi-nor/next vs. my older 4.14
kernel w.r.t. how SR lock is working.

In my system with a Micron mt25qu02g, I'm using the hardware WP# to
lock the SR.  When hardware write-protect is on, at the next reboot
the kernel rejects the flash as it cannot unlock the whole device.

I traced the problem to spi_nor_write_sr1_and_check(), which is
writing to the SR and reading back a different value (as the locked SR
bits are immutable).

Call trace:
 spi_nor_write_sr1_and_check+0x68/0x70
 spi_nor_write_sr_and_check+0x34/0xd0
 spi_nor_sr_unlock+0x108/0x230
 spi_nor_unlock+0x54/0x80  (via spi_nor_unlock_all())
 spi_nor_init+0x94/0x100

spi_nor_write_sr1_and_check() is returning -EIO here:
        if (nor->bouncebuf[0] != sr1) {
                dev_dbg(nor->dev, "SR1: read back test failed\n");
                BUG();
                return -EIO;
        }

In my specific case Linux doesn't have (and cannot be given, for
product security reasons) control over the WP#.  In any case, I don't
think a write-protected flash should be rejected here.

Can you suggest how we might proceed?  The way WP# is used is
board-specific so perhaps a device-tree property of some sort in the
flash device node can inform the code to do or not do the
spi_nor_unlock_all()?

I can take a look at putting a patch together if you suggest an
acceptable mechanism.

Regards,
David.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 18:13 [BUG]: spi-nor: spi_nor_init() fails when SR locked David Clear
2020-07-21  9:37 ` Tudor.Ambarus
2020-07-21 17:02   ` David Clear

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git