* [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation
@ 2019-03-13 21:18 Arnd Bergmann
2019-03-13 21:22 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-03-13 21:18 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger
Cc: Ricardo Ribalda Delgado, Linus Walleij, linux-mtd, linux-kernel,
Arnd Bergmann
Marking a local variable as __xipram causes a warning because of the
noinline attribute:
drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only applies to functions [-Werror,-Wignored-attributes]
map_word __xipram ret;
^
include/linux/mtd/xip.h:34:18: note: expanded from macro '__xipram'
#define __xipram noinline __attribute__ ((__section__ (".xiptext")))
I can't see any reason for the anotation anyway, so just remove it here.
Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/maps/physmap-gemini.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps/physmap-gemini.c b/drivers/mtd/maps/physmap-gemini.c
index 60775b208fc9..a289c8b5cabf 100644
--- a/drivers/mtd/maps/physmap-gemini.c
+++ b/drivers/mtd/maps/physmap-gemini.c
@@ -86,7 +86,7 @@ static void gemini_flash_disable_pins(void)
static map_word __xipram gemini_flash_map_read(struct map_info *map,
unsigned long ofs)
{
- map_word __xipram ret;
+ map_word ret;
gemini_flash_enable_pins();
ret = inline_map_read(map, ofs);
--
2.20.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation
2019-03-13 21:18 [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation Arnd Bergmann
@ 2019-03-13 21:22 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-03-13 21:22 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Boris Brezillon, Richard Weinberger, linux-kernel, Marek Vasut,
linux-mtd, Ricardo Ribalda Delgado, Brian Norris,
David Woodhouse
On Wed, Mar 13, 2019 at 10:19 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Marking a local variable as __xipram causes a warning because of the
> noinline attribute:
>
> drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only applies to functions [-Werror,-Wignored-attributes]
> map_word __xipram ret;
> ^
> include/linux/mtd/xip.h:34:18: note: expanded from macro '__xipram'
> #define __xipram noinline __attribute__ ((__section__ (".xiptext")))
>
> I can't see any reason for the anotation anyway, so just remove it here.
>
> Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-13 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 21:18 [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation Arnd Bergmann
2019-03-13 21:22 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).