* [Patch] mtd:rawnand: brcmnand: Fix PM resume crash
@ 2020-05-02 20:41 Kamal Dasu
2020-05-02 20:52 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Kamal Dasu @ 2020-05-02 20:41 UTC (permalink / raw)
To: Brian Norris, Kamal Dasu, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Cc: bcm-kernel-feedback-list, linux-mtd, linux-kernel
This change fixes crash observed on PM resume. This bug
was introduced in the change made for flash-edu support.
Fixes: a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers")
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index e4e3ceeac38f..8f9ffb46a09f 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -2728,9 +2728,8 @@ static int brcmnand_resume(struct device *dev)
flash_dma_writel(ctrl, FLASH_DMA_ERROR_STATUS, 0);
}
- if (has_edu(ctrl))
+ if (has_edu(ctrl)) {
ctrl->edu_config = edu_readl(ctrl, EDU_CONFIG);
- else {
edu_writel(ctrl, EDU_CONFIG, ctrl->edu_config);
edu_readl(ctrl, EDU_CONFIG);
brcmnand_edu_init(ctrl);
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] mtd:rawnand: brcmnand: Fix PM resume crash
2020-05-02 20:41 [Patch] mtd:rawnand: brcmnand: Fix PM resume crash Kamal Dasu
@ 2020-05-02 20:52 ` Florian Fainelli
2020-05-19 8:26 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2020-05-02 20:52 UTC (permalink / raw)
To: Kamal Dasu, Brian Norris, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Cc: bcm-kernel-feedback-list, linux-mtd, linux-kernel
On 5/2/2020 1:41 PM, Kamal Dasu wrote:
> This change fixes crash observed on PM resume. This bug
> was introduced in the change made for flash-edu support.
>
> Fixes: a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers")
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] mtd:rawnand: brcmnand: Fix PM resume crash
2020-05-02 20:52 ` Florian Fainelli
@ 2020-05-19 8:26 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2020-05-19 8:26 UTC (permalink / raw)
To: Florian Fainelli
Cc: Vignesh Raghavendra, Kamal Dasu, Richard Weinberger, LKML,
bcm-kernel-feedback-list, Miquel Raynal, linux-mtd, Brian Norris
On Sat, May 2, 2020 at 10:52 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 5/2/2020 1:41 PM, Kamal Dasu wrote:
> > This change fixes crash observed on PM resume. This bug
> > was introduced in the change made for flash-edu support.
> >
> > Fixes: a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers")
> >
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian
Applied for fixes, thanks!
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-19 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-02 20:41 [Patch] mtd:rawnand: brcmnand: Fix PM resume crash Kamal Dasu
2020-05-02 20:52 ` Florian Fainelli
2020-05-19 8:26 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).