From: Sudip Mukherjee <sudip.mukherjee@sifive.com>
To: Tudor Ambarus <Tudor.Ambarus@microchip.com>
Cc: Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Greentime Hu <greentime.hu@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>,
William Salmon <william.salmon@sifive.com>,
Adnan Chowdhury <adnan.chowdhury@sifive.com>,
Ben Dooks <ben.dooks@sifive.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags
Date: Mon, 18 Jul 2022 19:49:29 +0100 [thread overview]
Message-ID: <CAHyZL-fK-d+dPWG63dcFUz17uP-sG4bnSFVW_gt16snnOVTzpQ@mail.gmail.com> (raw)
In-Reply-To: <3a9877d0-3cc5-6452-764b-d07b38c72b00@microchip.com>
On Mon, Jul 18, 2022 at 6:02 PM <Tudor.Ambarus@microchip.com> wrote:
>
> On 7/12/22 19:38, Sudip Mukherjee wrote:
> > [You don't often get email from sudip.mukherjee@sifive.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Some flash chips which does not have a SFDP table can support Quad
> > Input Page Program. Enable it in hwcaps if defined.
> >
<snip>
> > diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
> > index 58fbedc94080f..dde636bdb1a7c 100644
> > --- a/drivers/mtd/spi-nor/core.h
> > +++ b/drivers/mtd/spi-nor/core.h
> > @@ -462,6 +462,7 @@ struct spi_nor_fixups {
> > * SPI_NOR_OCTAL_READ: flash supports Octal Read.
> > * SPI_NOR_OCTAL_DTR_READ: flash supports octal DTR Read.
> > * SPI_NOR_OCTAL_DTR_PP: flash supports Octal DTR Page Program.
> > + * SPI_NOR_QUAD_PP: flash supports Quad Input Page Program.
>
> You don't need this flag if your flash supports the 4-byte Address
> Instruction Table. Does you flash support it? Can you dump all the
> SFDP tables, please?
Not sure what the correct way to dump sfdp is. I did this from sysfs.
# cat sfdp | xxd
00000000: 5346 4450 0601 01ff 0006 0110 3000 00ff SFDP........0...
00000010: 9d05 0103 8000 0002 ffff ffff ffff ffff ................
00000020: ffff ffff ffff ffff ffff ffff ffff ffff ................
00000030: e520 f9ff ffff ff0f 44eb 086b 083b 80bb . ......D..k.;..
00000040: feff ffff ffff 00ff ffff 44eb 0c20 0f52 ..........D.. .R
00000050: 10d8 00ff 234a c900 82d8 11ce cccd 6846 ....#J........hF
00000060: 7a75 7a75 f7ae d55c 4a42 2cff f030 faa9 zuzu...\JB,..0..
00000070: ffff ffff ffff ffff ffff ffff ffff ffff ................
00000080: 5019 5016 9ff9 c064 8fef ffff P.P....d....
--
Regards
Sudip
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-18 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 16:38 [PATCH 0/3] Add Quad Input Page Program to chips with no SFDP table Sudip Mukherjee
2022-07-12 16:38 ` [PATCH 1/3] mtd: spi-nor: extend no_sfdp_flags to use u16 Sudip Mukherjee
2022-07-18 16:58 ` Tudor.Ambarus
2022-07-12 16:38 ` [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags Sudip Mukherjee
2022-07-18 17:02 ` Tudor.Ambarus
2022-07-18 18:49 ` Sudip Mukherjee [this message]
2022-07-22 10:24 ` Sudip Mukherjee
2022-07-29 7:48 ` Tudor.Ambarus
2022-07-29 8:10 ` Ben Dooks
2022-07-29 10:07 ` Tudor.Ambarus
2022-07-29 7:35 ` Tudor.Ambarus
2022-07-12 16:38 ` [PATCH 3/3] mtd: spi-nor: issi: is25wp256: Enable Quad Input Page Program Sudip Mukherjee
2022-07-18 7:39 ` Michael Walle
2022-07-18 14:56 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHyZL-fK-d+dPWG63dcFUz17uP-sG4bnSFVW_gt16snnOVTzpQ@mail.gmail.com \
--to=sudip.mukherjee@sifive.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=adnan.chowdhury@sifive.com \
--cc=ben.dooks@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).