* [PATCH] ubifs: default to zstd compression @ 2021-04-05 15:29 Rui Salvaterra 2021-04-08 11:00 ` Richard Weinberger 0 siblings, 1 reply; 3+ messages in thread From: Rui Salvaterra @ 2021-04-05 15:29 UTC (permalink / raw) To: richard; +Cc: linux-mtd, linux-kernel, Rui Salvaterra Compared to lzo and zlib, zstd is the best all-around performer, both in terms of speed and compression ratio. Set it as the default, if available. Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- fs/ubifs/sb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index c160f718c288..e7693b94e5b5 100644 --- a/fs/ubifs/sb.c +++ b/fs/ubifs/sb.c @@ -53,6 +53,9 @@ static int get_default_compressor(struct ubifs_info *c) { + if (ubifs_compr_present(c, UBIFS_COMPR_ZSTD)) + return UBIFS_COMPR_ZSTD; + if (ubifs_compr_present(c, UBIFS_COMPR_LZO)) return UBIFS_COMPR_LZO; -- 2.31.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ubifs: default to zstd compression 2021-04-05 15:29 [PATCH] ubifs: default to zstd compression Rui Salvaterra @ 2021-04-08 11:00 ` Richard Weinberger 2021-04-08 14:22 ` Rui Salvaterra 0 siblings, 1 reply; 3+ messages in thread From: Richard Weinberger @ 2021-04-08 11:00 UTC (permalink / raw) To: Rui Salvaterra; +Cc: Richard Weinberger, linux-mtd, LKML On Mon, Apr 5, 2021 at 5:36 PM Rui Salvaterra <rsalvaterra@gmail.com> wrote: > > Compared to lzo and zlib, zstd is the best all-around performer, both in terms > of speed and compression ratio. Set it as the default, if available. I was about to NACK this patch but by looking at the diff I realized that you change the default compressor only for the default filesystem as created by UBIFS itself. Queued for the merge window. :-) -- Thanks, //richard ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ubifs: default to zstd compression 2021-04-08 11:00 ` Richard Weinberger @ 2021-04-08 14:22 ` Rui Salvaterra 0 siblings, 0 replies; 3+ messages in thread From: Rui Salvaterra @ 2021-04-08 14:22 UTC (permalink / raw) To: Richard Weinberger; +Cc: Richard Weinberger, linux-mtd, LKML Hi, Richard, On Thu, 8 Apr 2021 at 12:00, Richard Weinberger <richard.weinberger@gmail.com> wrote: > > I was about to NACK this patch but by looking at the diff I realized > that you change > the default compressor only for the default filesystem as created by > UBIFS itself. Yes, that was the idea. :) > Queued for the merge window. :-) Thanks a lot! Rui ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-08 14:24 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-05 15:29 [PATCH] ubifs: default to zstd compression Rui Salvaterra 2021-04-08 11:00 ` Richard Weinberger 2021-04-08 14:22 ` Rui Salvaterra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).