From: zhengxunli@mxic.com.tw
To: "Pratyush Yadav" <p.yadav@ti.com>
Cc: broonie@kernel.org, jaimeliao@mxic.com.tw,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
miquel.raynal@bootlin.com, tudor.ambarus@microchip.com
Subject: Re: [PATCH v3 2/3] mtd: spi-nor: macronix: add support for Macronix octaflash series
Date: Tue, 4 May 2021 13:38:34 +0800 [thread overview]
Message-ID: <OFB742AAB3.BE2A05EA-ON482586CB.001E84DF-482586CB.001EFF57@mxic.com.tw> (raw)
In-Reply-To: <20210427024707.hrr5r74apwghwsaj@ti.com>
Hi,
>
> On 20/04/21 02:29PM, Zhengxun Li wrote:
> > Add 1.8V and 3V Octal NOR Flash IDs.
> > MX25 series : Serial NOR Flash.
> > MX66 series : Serial NOR Flash with stacked die.
>
> I only looked briefly at the datasheet, but I don't see any mention of
> stacked dies. I assume the stacked die part is transparent from software
> point of view, and is only a hardware implementation detail. Correct?
>
> > LM/UM series : Up to 250MHz clock frequency with both DTR/STR
operation.
> > LW/UW series : Support simultaneous Read-while-Write operation in
multiple
> > bank architecture. Read-while-write feature which means read
> > data one bank while another bank is programing or erasing.
>
> AFAIK, this feature is not currently supported in SPI NOR.
>
> >
> > MX25LM : 3.0V Octal I/O
> > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/
> MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf
> >
> > MX25UM : 1.8V Octal I/O
> > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/
> MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf
> >
> > MX66LM : 3.0V Octal I/O with stacked die
> > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/
> MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf
> >
> > MX66UM : 1.8V Octal I/O with stacked die
> > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/
> MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf
> >
> > MX25LW : 3.0V Octal I/O with Read-while-Write
> > MX25UW : 1.8V Octal I/O with Read-while-Write
> > MX66LW : 3.0V Octal I/O with Read-while-Write and stack die
> > MX66UW : 1.8V Octal I/O with Read-while-Write and stack die
> >
> > About LW/UW series, please contact us freely if you have any
> > questions. For adding Octal NOR Flash IDs, we have validated
> > each Flash on plateform zynq-picozed.
> >
> > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw>
> > ---
> > drivers/mtd/spi-nor/macronix.c | 100 ++++++++++++++++++++++++++++
> +++++++++++++
> > 1 file changed, 100 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c
b/drivers/mtd/spi-nor/macronix.c
> > index 881eaf8..8c1cf1b 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -203,6 +203,106 @@ static void octaflash_post_sfdp_fixup(struct
> spi_nor *nor)
> > { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096,
> > SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> > + { "mx66lm2g45g", INFO(0xc2853c, 0, 64 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66lw1g45g", INFO(0xc2863b, 0, 32 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25lm51245g", INFO(0xc2853a, 0, 16 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25lw51245g", INFO(0xc2863a, 0, 16 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25lm25645g", INFO(0xc28539, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25lw25645g", INFO(0xc28639, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66um2g45g", INFO(0xc2803c, 0, 64 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66uw2g345g", INFO(0xc2843c, 0, 64 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66uw2g345gx0", INFO(0xc2943c, 0, 64 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66um1g45g", INFO(0xc2803b, 0, 32 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66um1g45g40", INFO(0xc2808b, 0, 32 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx66uw1g45g", INFO(0xc2813b, 0, 32 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25um51245g", INFO(0xc2803a, 0, 16 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw51245g", INFO(0xc2813a, 0, 16 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw51345g", INFO(0xc2843a, 0, 16 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25um25645g", INFO(0xc28039, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw25645g", INFO(0xc28139, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25um25345g", INFO(0xc28339, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw25345g", INFO(0xc28439, 0, 8 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw12845g", INFO(0xc28138, 0, 4 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw12a45g", INFO(0xc28938, 0, 4 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw12345g", INFO(0xc28438, 0, 4 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw6445g", INFO(0xc28137, 0, 2 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
> > + { "mx25uw6345g", INFO(0xc28437, 0, 2 * 1024, 4096,
> > + SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES)
> > + .fixups = &octaflash_fixups },
>
> Reminder to self: Check if there are any ID collisions here. I have seen
> a couple of them show up recently on Macronix flashes.
Yes, we have checked for ID conflicts before sending the patch.
> Anyway, not much to see here. I suggest you merge this with patch 1.
I will merge this to patch 1 in the next version.
> > };
> >
> > static void macronix_default_init(struct spi_nor *nor)
>
Thanks,
Zhengxun
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-04 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 6:29 [PATCH v3 0/3] Add octal DTR support for Macronix flash Zhengxun Li
2021-04-20 6:29 ` [PATCH v3 1/3] mtd: spi-nor: macronix: add support for Macronix octal dtr operation Zhengxun Li
2021-04-27 2:36 ` Pratyush Yadav
2021-05-04 5:31 ` zhengxunli
2021-05-04 7:42 ` Pratyush Yadav
2021-05-05 8:29 ` zhengxunli
2021-04-20 6:29 ` [PATCH v3 2/3] mtd: spi-nor: macronix: add support for Macronix octaflash series Zhengxun Li
2021-04-27 2:47 ` Pratyush Yadav
2021-05-04 5:38 ` zhengxunli [this message]
2021-04-20 6:29 ` [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support Zhengxun Li
2021-04-26 16:53 ` Mark Brown
2021-04-27 1:48 ` zhengxunli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFB742AAB3.BE2A05EA-ON482586CB.001E84DF-482586CB.001EFF57@mxic.com.tw \
--to=zhengxunli@mxic.com.tw \
--cc=broonie@kernel.org \
--cc=jaimeliao@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).