From: Biju Das <biju.das.jz@bp.renesas.com>
To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>,
"p.yadav@ti.com" <p.yadav@ti.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"richard@nod.at" <richard@nod.at>,
"vigneshr@ti.com" <vigneshr@ti.com>
Cc: "michael@walle.cc" <michael@walle.cc>,
"Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"Claudiu.Beznea@microchip.com" <Claudiu.Beznea@microchip.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
"biju.das@bp.renesas.com" <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash
Date: Thu, 21 Jul 2022 08:48:27 +0000 [thread overview]
Message-ID: <TYCPR01MB59333483DDEB9BBB724C69AE86919@TYCPR01MB5933.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <7aa7de93-23f0-c94a-bfc3-e79321cdc1f9@microchip.com>
Hi Tudor.Ambarus,
> Subject: Re: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor
> flash
>
> On 7/15/22 13:57, Biju Das wrote:
>
> Hi, Biju!
>
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> >
> > Add support for Renesas AT25QL128A serial nor flash.
> > Details of flash chip can be found here [1]
> >
> > [1]
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > $ xxd -p sfdp
> > 53464450060101ff00060110300000ff1f00010280000001ffffffffffff
> > ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b
> > 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429
> > 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff
> > ffffffffffffffff501650190000ffff
> >
> > $ md5sum
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/sfdp 23e3ec56b5b8f986d0488ba4727239dd
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/sfdp $ cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/jedec_id
> > 1f4218
> > $ cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/partname
> > at25ql128a
> > $ cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/manufacturer
> > atmel
> > v2->v1:
> > * Added flash definitions into Atmel table.
> > RFC->v1:
> > * Moved the flash definitions to atmel.c
> > * Remove macro related to locking as it is untested.
> > * Replaced INFO macro with SNOR_ID3
> >
> > RFC:
> > *
> > ---
> > drivers/mtd/spi-nor/atmel.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> > index 656dd80a0be7..80c24d138b27 100644
> > --- a/drivers/mtd/spi-nor/atmel.c
> > +++ b/drivers/mtd/spi-nor/atmel.c
> > @@ -186,6 +186,7 @@ static const struct flash_info atmel_nor_parts[] = {
> > .fixups = &atmel_nor_global_protection_fixups },
> > { "at25sl321", INFO(0x1f4216, 0, 64 * 1024, 64)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ) },
> > + { "at25ql128a", SNOR_ID3(0x1f4218) },
>
> As the flash is defined now, all its characteristics can be discovered by
> parsing SFDP. So instead of adding a new flash_info entry in the already big
> array that we have, I would like us to focus more on a generic flash driver
> which acts as a backup when the flash is not found in the flash_info array.
> We can discover the flash particularities by parsing SFDP and we can probe
> the flash based on that. Michael has already suggested this, would you
> please help review it?
>
Sure, will review and test this patch series.
Cheers,
Biju
>
> > { "at26f004", INFO(0x1f0400, 0, 64 * 1024, 8)
> > NO_SFDP_FLAGS(SECT_4K) },
> > { "at26df081a", INFO(0x1f4501, 0, 64 * 1024, 16)
> > --
> > 2.25.1
> >
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-21 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 10:57 [PATCH v2 0/2] Add Renesas AT25QL128A serial nor flash Biju Das
2022-07-15 10:57 ` [PATCH v2 1/2] mtd: spi-nor: Add support for SNOR_ID3 macro Biju Das
2022-07-15 11:57 ` Michael Walle
2022-07-18 5:53 ` Biju Das
2022-07-15 10:57 ` [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash Biju Das
2022-07-15 11:55 ` Michael Walle
2022-07-19 8:53 ` Pratyush Yadav
2022-07-21 8:28 ` Tudor.Ambarus
2022-07-21 8:48 ` Biju Das [this message]
2022-07-21 9:23 ` Biju Das
2022-07-21 9:39 ` Tudor.Ambarus
2022-07-21 9:43 ` Michael Walle
2022-07-21 9:46 ` Biju Das
2022-07-21 10:00 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB59333483DDEB9BBB724C69AE86919@TYCPR01MB5933.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).