From: Michael Walle <michael@walle.cc>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Tudor.Ambarus@microchip.com, p.yadav@ti.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Claudiu.Beznea@microchip.com, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, geert+renesas@glider.be,
Chris Paterson <Chris.Paterson2@renesas.com>,
biju.das@bp.renesas.com,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash
Date: Thu, 21 Jul 2022 12:00:25 +0200 [thread overview]
Message-ID: <dbf2931656904b9b5e18702f27a11b1a@walle.cc> (raw)
In-Reply-To: <OS0PR01MB59221FE257A0E06F225AB6B686919@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Am 2022-07-21 11:46, schrieb Biju Das:
>> > root@smarc-rzg2ul:~#
nice a smarc board :)
>> >
>> > root@smarc-rzg2ul:~# cat
>> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
>> > .0/spi-nor/manufacturer
>> > cat:
>> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
>> > .0/spi-nor/manufacturer: No such file or directory
>> >
>> > This result is not matching atmel-> cat:
>> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
>> > .0/spi-nor/manufacturer: No such file or directory
>>
>> here we could introduce a generic name as well.
>
> OK.
>
> Michael: Do you have any plan to add generic name for manufacturer
> as completeness?
Why would we need that one? There is no manufacturer. So I don't
see why we should add a fake one. The partname is debatable, too.
IMHO if we really want to get rid of the "dummy" tables in the kernel,
the userspace (mtdutils for example) could parse the jedec id and
sfdp and find the manufacturer and partnumer. But TBH, I don't know
if that is really an important information.
Implementation wise, right now, it's quite a hack how the
manufacturer is set. It gets already set early in
spi_nor_match_name(), while the actual flash info will get set
later in the call chain.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-07-21 10:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 10:57 [PATCH v2 0/2] Add Renesas AT25QL128A serial nor flash Biju Das
2022-07-15 10:57 ` [PATCH v2 1/2] mtd: spi-nor: Add support for SNOR_ID3 macro Biju Das
2022-07-15 11:57 ` Michael Walle
2022-07-18 5:53 ` Biju Das
2022-07-15 10:57 ` [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash Biju Das
2022-07-15 11:55 ` Michael Walle
2022-07-19 8:53 ` Pratyush Yadav
2022-07-21 8:28 ` Tudor.Ambarus
2022-07-21 8:48 ` Biju Das
2022-07-21 9:23 ` Biju Das
2022-07-21 9:39 ` Tudor.Ambarus
2022-07-21 9:43 ` Michael Walle
2022-07-21 9:46 ` Biju Das
2022-07-21 10:00 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf2931656904b9b5e18702f27a11b1a@walle.cc \
--to=michael@walle.cc \
--cc=Chris.Paterson2@renesas.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).