* [PATCH RESEND v8 0/5] fix the meson NFC clock
@ 2022-09-05 7:50 Liang Yang
2022-09-05 7:50 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-09-05 12:37 ` [PATCH RESEND v8 0/5] fix the meson NFC clock Neil Armstrong
0 siblings, 2 replies; 6+ messages in thread
From: Liang Yang @ 2022-09-05 7:50 UTC (permalink / raw)
To: Miquel Raynal, linux-mtd
Cc: Liang Yang, Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Jianxin Pan, Victor Wan, XianWei Zhao, Kelvin Zhang,
BiChao Zheng, YongHui Yu, linux-arm-kernel, linux-amlogic,
linux-kernel, devicetree
EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
a common MMC and NAND sub-clock was discussed and planed to be implemented
as NFC clock provider, but now this series of patches of a common MMC and
NAND sub-clock are never being accepted and the current binding was never
valid. the reasons are:
1. EMMC and NAND, which are mutually exclusive anyway
2. coupling the EMMC and NAND.
3. it seems that a common MMC and NAND sub-clock is over engineered.
and let us see the link for more information:
https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
so The meson nfc can't work now, let us rework the clock.
Changes since v7 [8]
- use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of
ARCH_MESON || COMPILE_TEST || COMMON_CLK.
- collect the review and ack
Changes since v6 [7]
- use COMMON_CLK instead of !HAVE_LEGACY_CLK
Changes since v5 [6]
- add change log for patch 3/5
- add patch 5/5 to fix the reporting error of test robot
Changes since v4 [5]
- split the dt binding patch into two patches, one for fixing,
clock, the other for coverting to yaml
- split the nfc driver patch into two patches, one for fixing
clock, the other for refining the get nfc resource.
Changes since v3 [4]
- use devm_platform_ioremap_resource_byname
- dt_binding_check for mtd/amlogic,meson-nand.yaml
Changes since v2 [3]
- use fw_name from dts, instead the wrong way using __clk_get_name
- reg resource size change to 0x800
- use reg-names
Changes since v1 [2]
- use clk_parent_data instead of parent_names
- define a reg resource instead of sd_emmc_c_clkc
[1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com
https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com
[2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com
[3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com
[4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/
[5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/
[6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/
[7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/
Liang Yang (5):
dt-bindings: nand: meson: fix meson nfc clock
mtd: rawnand: meson: fix the clock
mtd: rawnand: meson: refine resource getting in probe
dt-bindings: nand: meson: convert txt to yaml
mtd: rawnand: meson: not support legacy clock
.../bindings/mtd/amlogic,meson-nand.txt | 60 -------------
.../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
drivers/mtd/nand/raw/Kconfig | 2 +-
drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++---------
4 files changed, 131 insertions(+), 105 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml
2022-09-05 7:50 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
@ 2022-09-05 7:50 ` Liang Yang
2022-09-05 12:37 ` [PATCH RESEND v8 0/5] fix the meson NFC clock Neil Armstrong
1 sibling, 0 replies; 6+ messages in thread
From: Liang Yang @ 2022-09-05 7:50 UTC (permalink / raw)
To: Miquel Raynal, linux-mtd
Cc: Liang Yang, Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Jianxin Pan, Victor Wan, XianWei Zhao, Kelvin Zhang,
BiChao Zheng, YongHui Yu, linux-arm-kernel, linux-amlogic,
linux-kernel, devicetree
convert the amlogic,meson-name.txt to amlogic,meson-nand.yaml
Signed-off-by: Liang Yang <liang.yang@amlogic.com>
---
.../bindings/mtd/amlogic,meson-nand.txt | 55 ------------
.../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
2 files changed, 88 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
deleted file mode 100644
index 5d5cdfef417f..000000000000
--- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs
-
-This file documents the properties in addition to those available in
-the MTD NAND bindings.
-
-Required properties:
-- compatible : contains one of:
- - "amlogic,meson-gxl-nfc"
- - "amlogic,meson-axg-nfc"
-
-- reg : Offset and length of the register set
-
-- reg-names : "nfc" is the register set for NFC controller and "emmc"
- is the register set for MCI controller.
-
-- clocks :
- A list of phandle + clock-specifier pairs for the clocks listed
- in clock-names.
-
-- clock-names: Should contain the following:
- "core" - NFC module gate clock
- "device" - parent clock for internal NFC
-
-Optional children nodes:
-Children nodes represent the available nand chips.
-
-Other properties:
-see Documentation/devicetree/bindings/mtd/nand-controller.yaml for generic bindings.
-
-Example demonstrate on AXG SoC:
-
- nand-controller@7800 {
- compatible = "amlogic,meson-axg-nfc";
- reg = <0x0 0x7800 0x0 0x100>,
- <0x0 0x7000 0x0 0x800>;
- reg-names = "nfc", "emmc";
- #address-cells = <1>;
- #size-cells = <0>;
- interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
-
- clocks = <&clkc CLKID_SD_EMMC_C>,
- <&clkc CLKID_FCLK_DIV2>;
- clock-names = "core", "device";
-
- pinctrl-names = "default";
- pinctrl-0 = <&nand_pins>;
-
- nand@0 {
- reg = <0>;
- #address-cells = <1>;
- #size-cells = <1>;
-
- nand-on-flash-bbt;
- };
- };
diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
new file mode 100644
index 000000000000..42634e9c0d3c
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
@@ -0,0 +1,88 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/amlogic,meson-nand.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs
+
+allOf:
+ - $ref: "nand-controller.yaml"
+
+maintainers:
+ - liang.yang@amlogic.com
+
+properties:
+ compatible:
+ enum:
+ - "amlogic,meson-gxl-nfc"
+ - "amlogic,meson-axg-nfc"
+
+ reg:
+ maxItems: 2
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 2
+
+ clock-names:
+ items:
+ - const: core
+ - const: device
+
+patternProperties:
+ "^nand@[0-7]$":
+ type: object
+ properties:
+ reg:
+ minimum: 0
+ maximum: 1
+
+ nand-ecc-mode:
+ const: hw
+
+ nand-ecc-step-size:
+ const: 1024
+
+ nand-ecc-strength:
+ enum: [8, 16, 24, 30, 40, 50, 60]
+ description: |
+ The ECC configurations that can be supported are as follows.
+ meson-gxl-nfc 8, 16, 24, 30, 40, 50, 60
+ meson-axg-nfc 8
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/axg-clkc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ nand-controller@ffe07800 {
+ compatible = "amlogic,meson-axg-nfc";
+ reg = <0xffe07800 0x100>, <0xffe07000 0x800>;
+ reg-names = "nfc", "emmc";
+ interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&clkc CLKID_SD_EMMC_C>, <&clkc CLKID_FCLK_DIV2>;
+ clock-names = "core", "device";
+
+ pinctrl-0 = <&nand_pins>;
+ pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ nand@0 {
+ reg = <0>;
+ };
+ };
+
+...
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v8 0/5] fix the meson NFC clock
2022-09-05 7:50 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
2022-09-05 7:50 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
@ 2022-09-05 12:37 ` Neil Armstrong
2022-09-06 2:20 ` Liang Yang
1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2022-09-05 12:37 UTC (permalink / raw)
To: Liang Yang, Miquel Raynal, linux-mtd
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Jianxin Pan, Victor Wan, XianWei Zhao, Kelvin Zhang,
BiChao Zheng, YongHui Yu, linux-arm-kernel, linux-amlogic,
linux-kernel, devicetree
Hi,
On 05/09/2022 09:50, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
>
> Changes since v7 [8]
> - use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of
> ARCH_MESON || COMPILE_TEST || COMMON_CLK.
> - collect the review and ack
>
> Changes since v6 [7]
> - use COMMON_CLK instead of !HAVE_LEGACY_CLK
>
> Changes since v5 [6]
> - add change log for patch 3/5
> - add patch 5/5 to fix the reporting error of test robot
>
> Changes since v4 [5]
> - split the dt binding patch into two patches, one for fixing,
> clock, the other for coverting to yaml
> - split the nfc driver patch into two patches, one for fixing
> clock, the other for refining the get nfc resource.
>
> Changes since v3 [4]
> - use devm_platform_ioremap_resource_byname
> - dt_binding_check for mtd/amlogic,meson-nand.yaml
>
> Changes since v2 [3]
> - use fw_name from dts, instead the wrong way using __clk_get_name
> - reg resource size change to 0x800
> - use reg-names
>
> Changes since v1 [2]
> - use clk_parent_data instead of parent_names
> - define a reg resource instead of sd_emmc_c_clkc
>
> [1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com
> https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com
> [2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com
> [3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com
> [4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/
> [5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/
> [6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/
> [7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/
>
> Liang Yang (5):
> dt-bindings: nand: meson: fix meson nfc clock
> mtd: rawnand: meson: fix the clock
> mtd: rawnand: meson: refine resource getting in probe
> dt-bindings: nand: meson: convert txt to yaml
> mtd: rawnand: meson: not support legacy clock
>
> .../bindings/mtd/amlogic,meson-nand.txt | 60 -------------
> .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
> drivers/mtd/nand/raw/Kconfig | 2 +-
> drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++---------
> 4 files changed, 131 insertions(+), 105 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>
It seems you sent only patch 4
Neil
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v8 0/5] fix the meson NFC clock
2022-09-05 12:37 ` [PATCH RESEND v8 0/5] fix the meson NFC clock Neil Armstrong
@ 2022-09-06 2:20 ` Liang Yang
0 siblings, 0 replies; 6+ messages in thread
From: Liang Yang @ 2022-09-06 2:20 UTC (permalink / raw)
To: Neil Armstrong, Miquel Raynal, linux-mtd
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Martin Blumenstingl, Kevin Hilman, Jianxin Pan,
Victor Wan, XianWei Zhao, Kelvin Zhang, BiChao Zheng, YongHui Yu,
linux-arm-kernel, linux-amlogic, linux-kernel, devicetree
Hi Neil,
On 2022/9/5 20:37, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> Hi,
>
> On 05/09/2022 09:50, Liang Yang wrote:
>> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
>> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
>> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
>> a common MMC and NAND sub-clock was discussed and planed to be
>> implemented
>> as NFC clock provider, but now this series of patches of a common MMC and
>> NAND sub-clock are never being accepted and the current binding was never
>> valid. the reasons are:
>> 1. EMMC and NAND, which are mutually exclusive anyway
>> 2. coupling the EMMC and NAND.
>> 3. it seems that a common MMC and NAND sub-clock is over engineered.
>> and let us see the link for more information:
>> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
>> so The meson nfc can't work now, let us rework the clock.
>>
>> Changes since v7 [8]
>> - use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of
>> ARCH_MESON || COMPILE_TEST || COMMON_CLK.
>> - collect the review and ack
>>
>> Changes since v6 [7]
>> - use COMMON_CLK instead of !HAVE_LEGACY_CLK
>>
>> Changes since v5 [6]
>> - add change log for patch 3/5
>> - add patch 5/5 to fix the reporting error of test robot
>>
>> Changes since v4 [5]
>> - split the dt binding patch into two patches, one for fixing,
>> clock, the other for coverting to yaml
>> - split the nfc driver patch into two patches, one for fixing
>> clock, the other for refining the get nfc resource.
>>
>> Changes since v3 [4]
>> - use devm_platform_ioremap_resource_byname
>> - dt_binding_check for mtd/amlogic,meson-nand.yaml
>>
>> Changes since v2 [3]
>> - use fw_name from dts, instead the wrong way using __clk_get_name
>> - reg resource size change to 0x800
>> - use reg-names
>>
>> Changes since v1 [2]
>> - use clk_parent_data instead of parent_names
>> - define a reg resource instead of sd_emmc_c_clkc
>>
>> [1]
>> https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com
>>
>> https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com
>> [2]
>> https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com
>> [3]
>> https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com
>> [4]
>> https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/
>>
>> [5]
>> https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/
>>
>> [6]
>> https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/
>>
>> [7]
>> https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/
>>
>>
>> Liang Yang (5):
>> dt-bindings: nand: meson: fix meson nfc clock
>> mtd: rawnand: meson: fix the clock
>> mtd: rawnand: meson: refine resource getting in probe
>> dt-bindings: nand: meson: convert txt to yaml
>> mtd: rawnand: meson: not support legacy clock
>>
>> .../bindings/mtd/amlogic,meson-nand.txt | 60 -------------
>> .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
>> drivers/mtd/nand/raw/Kconfig | 2 +-
>> drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++---------
>> 4 files changed, 131 insertions(+), 105 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
>> create mode 100644
>> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>>
> It seems you sent only patch 4
yes, i only sent patch 4 and this cover letter.
i will send this series of patches again.
thanks.
>
> Neil
>
> .
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v8 0/5] fix the meson NFC clock
@ 2022-09-06 6:00 Liang Yang
0 siblings, 0 replies; 6+ messages in thread
From: Liang Yang @ 2022-09-06 6:00 UTC (permalink / raw)
To: Miquel Raynal, linux-mtd
Cc: Liang Yang, Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Jianxin Pan, Victor Wan, XianWei Zhao, Kelvin Zhang,
BiChao Zheng, YongHui Yu, linux-arm-kernel, linux-amlogic,
linux-kernel, devicetree
EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
a common MMC and NAND sub-clock was discussed and planed to be implemented
as NFC clock provider, but now this series of patches of a common MMC and
NAND sub-clock are never being accepted and the current binding was never
valid. the reasons are:
1. EMMC and NAND, which are mutually exclusive anyway
2. coupling the EMMC and NAND.
3. it seems that a common MMC and NAND sub-clock is over engineered.
and let us see the link for more information:
https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
so The meson nfc can't work now, let us rework the clock.
Changes since v7 [8]
- use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of
ARCH_MESON || COMPILE_TEST || COMMON_CLK.
- collect the review and ack
Changes since v6 [7]
- use COMMON_CLK instead of !HAVE_LEGACY_CLK
Changes since v5 [6]
- add change log for patch 3/5
- add patch 5/5 to fix the reporting error of test robot
Changes since v4 [5]
- split the dt binding patch into two patches, one for fixing,
clock, the other for coverting to yaml
- split the nfc driver patch into two patches, one for fixing
clock, the other for refining the get nfc resource.
Changes since v3 [4]
- use devm_platform_ioremap_resource_byname
- dt_binding_check for mtd/amlogic,meson-nand.yaml
Changes since v2 [3]
- use fw_name from dts, instead the wrong way using __clk_get_name
- reg resource size change to 0x800
- use reg-names
Changes since v1 [2]
- use clk_parent_data instead of parent_names
- define a reg resource instead of sd_emmc_c_clkc
[1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com
https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com
[2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com
[3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com
[4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/
[5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/
[6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/
[7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/
Liang Yang (5):
dt-bindings: nand: meson: fix meson nfc clock
mtd: rawnand: meson: fix the clock
mtd: rawnand: meson: refine resource getting in probe
dt-bindings: nand: meson: convert txt to yaml
mtd: rawnand: meson: not support legacy clock
.../bindings/mtd/amlogic,meson-nand.txt | 60 -------------
.../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
drivers/mtd/nand/raw/Kconfig | 2 +-
drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++---------
4 files changed, 131 insertions(+), 105 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v8 0/5] fix the meson NFC clock
@ 2022-08-22 9:18 Liang Yang
0 siblings, 0 replies; 6+ messages in thread
From: Liang Yang @ 2022-08-22 9:18 UTC (permalink / raw)
To: Miquel Raynal, linux-mtd
Cc: Liang Yang, Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Jerome Brunet, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Jianxin Pan, Victor Wan, XianWei Zhao, Kelvin Zhang,
BiChao Zheng, YongHui Yu, linux-arm-kernel, linux-amlogic,
linux-kernel, devicetree
EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
a common MMC and NAND sub-clock was discussed and planed to be implemented
as NFC clock provider, but now this series of patches of a common MMC and
NAND sub-clock are never being accepted and the current binding was never
valid. the reasons are:
1. EMMC and NAND, which are mutually exclusive anyway
2. coupling the EMMC and NAND.
3. it seems that a common MMC and NAND sub-clock is over engineered.
and let us see the link for more information:
https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
so The meson nfc can't work now, let us rework the clock.
Changes since v7 [8]
- use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of
ARCH_MESON || COMPILE_TEST || COMMON_CLK.
- collect the review and ack
Changes since v6 [7]
- use COMMON_CLK instead of !HAVE_LEGACY_CLK
Changes since v5 [6]
- add change log for patch 3/5
- add patch 5/5 to fix the reporting error of test robot
Changes since v4 [5]
- split the dt binding patch into two patches, one for fixing,
clock, the other for coverting to yaml
- split the nfc driver patch into two patches, one for fixing
clock, the other for refining the get nfc resource.
Changes since v3 [4]
- use devm_platform_ioremap_resource_byname
- dt_binding_check for mtd/amlogic,meson-nand.yaml
Changes since v2 [3]
- use fw_name from dts, instead the wrong way using __clk_get_name
- reg resource size change to 0x800
- use reg-names
Changes since v1 [2]
- use clk_parent_data instead of parent_names
- define a reg resource instead of sd_emmc_c_clkc
[1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com
https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com
[2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com
[3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com
[4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/
[5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/
[6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/
[7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/
Liang Yang (5):
dt-bindings: nand: meson: fix meson nfc clock
mtd: rawnand: meson: fix the clock
mtd: rawnand: meson: refine resource getting in probe
dt-bindings: nand: meson: convert txt to yaml
mtd: rawnand: meson: not support legacy clock
.../bindings/mtd/amlogic,meson-nand.txt | 60 -------------
.../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
drivers/mtd/nand/raw/Kconfig | 2 +-
drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++---------
4 files changed, 131 insertions(+), 105 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-06 6:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 7:50 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
2022-09-05 7:50 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-09-05 12:37 ` [PATCH RESEND v8 0/5] fix the meson NFC clock Neil Armstrong
2022-09-06 2:20 ` Liang Yang
-- strict thread matches above, loose matches on Subject: below --
2022-09-06 6:00 Liang Yang
2022-08-22 9:18 Liang Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).