[PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[Florian Fainelli]

Hi all,

This patch series allows for a finer control over the BRCMNAND driver
glue driver selection such that it defaults to the various platforms
enabled in the configuration file.

Florian Fainelli (2):
  mtd: rawnand: brcmnand: Move Kconfig to driver folder
  mtd: rawnand: brcmnand: Add individual glue driver selection

 drivers/mtd/nand/raw/Kconfig           | 22 +-----------
 drivers/mtd/nand/raw/brcmnand/Kconfig  | 49 ++++++++++++++++++++++++++
 drivers/mtd/nand/raw/brcmnand/Makefile |  8 ++---
 3 files changed, 54 insertions(+), 25 deletions(-)
 create mode 100644 drivers/mtd/nand/raw/brcmnand/Kconfig

-- 
2.25.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

[PATCH 1/2] mtd: rawnand: brcmnand: Move Kconfig to driver folder

[Florian Fainelli]

In preparation for allowing each of the brcmnand stub to be built
separately, move the Kconfig entry to the driver folder.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/mtd/nand/raw/Kconfig          | 22 +---------------------
 drivers/mtd/nand/raw/brcmnand/Kconfig | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+), 21 deletions(-)
 create mode 100644 drivers/mtd/nand/raw/brcmnand/Kconfig

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 8b6d7a515445..43a151b4c8fc 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -200,27 +200,7 @@ config MTD_NAND_TMIO
 	  Support for NAND flash connected to a Toshiba Mobile IO
 	  Controller in some PDAs, including the Sharp SL6000x.
 
-config MTD_NAND_BRCMNAND
-	tristate "Broadcom STB NAND controller"
-	depends on ARM || ARM64 || MIPS || COMPILE_TEST
-	depends on HAS_IOMEM
-	help
-	  Enables the Broadcom NAND controller driver. The controller was
-	  originally designed for Set-Top Box but is used on various BCM7xxx,
-	  BCM3xxx, BCM63xxx, iProc/Cygnus and more.
-
-if MTD_NAND_BRCMNAND
-
-config MTD_NAND_BRCMNAND_BCMA
-	tristate "Broadcom BCMA NAND controller"
-	depends on BCMA_NFLASH
-	depends on BCMA
-	help
-	  Enables the BRCMNAND controller over BCMA on BCM47186/BCM5358 SoCs.
-	  The glue driver will take care of performing the low-level I/O
-	  operations to interface the BRCMNAND controller over the BCMA bus.
-
-endif # MTD_NAND_BRCMNAND
+source "drivers/mtd/nand/raw/brcmnand/Kconfig"
 
 config MTD_NAND_BCM47XXNFLASH
 	tristate "BCM4706 BCMA NAND controller"
diff --git a/drivers/mtd/nand/raw/brcmnand/Kconfig b/drivers/mtd/nand/raw/brcmnand/Kconfig
new file mode 100644
index 000000000000..d5a0265525ca
--- /dev/null
+++ b/drivers/mtd/nand/raw/brcmnand/Kconfig
@@ -0,0 +1,21 @@
+config MTD_NAND_BRCMNAND
+	tristate "Broadcom STB NAND controller"
+	depends on ARM || ARM64 || MIPS || COMPILE_TEST
+	depends on HAS_IOMEM
+	help
+	  Enables the Broadcom NAND controller driver. The controller was
+	  originally designed for Set-Top Box but is used on various BCM7xxx,
+	  BCM3xxx, BCM63xxx, iProc/Cygnus and more.
+
+if MTD_NAND_BRCMNAND
+
+config MTD_NAND_BRCMNAND_BCMA
+	tristate "Broadcom BCMA NAND controller"
+	depends on BCMA_NFLASH
+	depends on BCMA
+	help
+	  Enables the BRCMNAND controller over BCMA on BCM47186/BCM5358 SoCs.
+	  The glue driver will take care of performing the low-level I/O
+	  operations to interface the BRCMNAND controller over the BCMA bus.
+
+endif # MTD_NAND_BRCMNAND
-- 
2.25.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 1/2] mtd: rawnand: brcmnand: Move Kconfig to driver folder

[Miquel Raynal]

On Mon, 2022-07-11 at 22:23:22 UTC, Florian Fainelli wrote:
> In preparation for allowing each of the brcmnand stub to be built
> separately, move the Kconfig entry to the driver folder.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

[PATCH 2/2] mtd: rawnand: brcmnand: Add individual glue driver selection

[Florian Fainelli]

Allow each platform to define a dedicated Kconfig entry for its glue
driver such that we can decide on a per-platfomr basis whether to build
it or not. This allows for a finer grained control over the resulting
kernel image or set of modules.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/mtd/nand/raw/brcmnand/Kconfig  | 28 ++++++++++++++++++++++++++
 drivers/mtd/nand/raw/brcmnand/Makefile |  8 ++++----
 2 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/raw/brcmnand/Kconfig b/drivers/mtd/nand/raw/brcmnand/Kconfig
index d5a0265525ca..4bc51bf60aca 100644
--- a/drivers/mtd/nand/raw/brcmnand/Kconfig
+++ b/drivers/mtd/nand/raw/brcmnand/Kconfig
@@ -9,6 +9,13 @@ config MTD_NAND_BRCMNAND
 
 if MTD_NAND_BRCMNAND
 
+config MTD_NAND_BRCMNAND_BCM63XX
+	tristate "Broadcom BCM63xx NAND controller glue"
+	default BCM63XX
+	help
+	  Enables the BRCMNAND glue driver to register the NAND controller
+	  on Broadcom BCM63xx MIPS-based DSL platforms.
+
 config MTD_NAND_BRCMNAND_BCMA
 	tristate "Broadcom BCMA NAND controller"
 	depends on BCMA_NFLASH
@@ -18,4 +25,25 @@ config MTD_NAND_BRCMNAND_BCMA
 	  The glue driver will take care of performing the low-level I/O
 	  operations to interface the BRCMNAND controller over the BCMA bus.
 
+config MTD_NAND_BRCMNAND_BCMBCA
+	tristate "Broadcom BCMBCA NAND controller glue"
+	default ARCH_BCMBCA
+	help
+	  Enables the BRCMNAND glue driver to register the NAND controller
+	  on Broadcom BCA platforms.
+
+config MTD_NAND_BRCMNAND_BRCMSTB
+	tristate "Broadcom STB Nand controller glue"
+	default ARCH_BRCMSTB
+	help
+	  Enables the BRCMNAND glue driver to register the NAND controller
+	  on Broadcom STB platforms.
+
+config MTD_NAND_BRCMNAND_IPROC
+	tristate "Broadcom iProc NAND controller glue"
+	default ARCH_BCM_IPROC
+	help
+	  Enables the BRCMNAND controller glue driver to register the NAND
+	  controller on Broadcom iProc platforms.
+
 endif # MTD_NAND_BRCMNAND
diff --git a/drivers/mtd/nand/raw/brcmnand/Makefile b/drivers/mtd/nand/raw/brcmnand/Makefile
index 16dc7254200e..9907e3ec4bb2 100644
--- a/drivers/mtd/nand/raw/brcmnand/Makefile
+++ b/drivers/mtd/nand/raw/brcmnand/Makefile
@@ -1,10 +1,10 @@
 # SPDX-License-Identifier: GPL-2.0
 # link order matters; don't link the more generic brcmstb_nand.o before the
 # more specific iproc_nand.o, for instance
-obj-$(CONFIG_MTD_NAND_BRCMNAND)		+= iproc_nand.o
-obj-$(CONFIG_MTD_NAND_BRCMNAND)		+= bcm63138_nand.o
-obj-$(CONFIG_MTD_NAND_BRCMNAND)		+= bcm6368_nand.o
-obj-$(CONFIG_MTD_NAND_BRCMNAND)		+= brcmstb_nand.o
+obj-$(CONFIG_MTD_NAND_BRCMNAND_IPROC)	+= iproc_nand.o
+obj-$(CONFIG_MTD_NAND_BRCMNAND_BCMBCA)	+= bcm63138_nand.o
+obj-$(CONFIG_MTD_NAND_BRCMNAND_BCM63XX)	+= bcm6368_nand.o
+obj-$(CONFIG_MTD_NAND_BRCMNAND_BRCMSTB)	+= brcmstb_nand.o
 obj-$(CONFIG_MTD_NAND_BRCMNAND)		+= brcmnand.o
 
 obj-$(CONFIG_MTD_NAND_BRCMNAND_BCMA)	+= bcma_nand.o
-- 
2.25.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 2/2] mtd: rawnand: brcmnand: Add individual glue driver selection

[Miquel Raynal]

On Mon, 2022-07-11 at 22:23:23 UTC, Florian Fainelli wrote:
> Allow each platform to define a dedicated Kconfig entry for its glue
> driver such that we can decide on a per-platfomr basis whether to build
> it or not. This allows for a finer grained control over the resulting
> kernel image or set of modules.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[Florian Fainelli]

On 7/11/22 15:23, Florian Fainelli wrote:
> Hi all,
> 
> This patch series allows for a finer control over the BRCMNAND driver
> glue driver selection such that it defaults to the various platforms
> enabled in the configuration file.

Miquel are you able to review and apply those patches if satisfactory? Thanks!

> 
> Florian Fainelli (2):
>   mtd: rawnand: brcmnand: Move Kconfig to driver folder
>   mtd: rawnand: brcmnand: Add individual glue driver selection
> 
>  drivers/mtd/nand/raw/Kconfig           | 22 +-----------
>  drivers/mtd/nand/raw/brcmnand/Kconfig  | 49 ++++++++++++++++++++++++++
>  drivers/mtd/nand/raw/brcmnand/Makefile |  8 ++---
>  3 files changed, 54 insertions(+), 25 deletions(-)
>  create mode 100644 drivers/mtd/nand/raw/brcmnand/Kconfig
> 


-- 
Florian

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[Florian Fainelli]

On 8/4/2022 10:55 AM, Florian Fainelli wrote:
> On 7/11/22 15:23, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series allows for a finer control over the BRCMNAND driver
>> glue driver selection such that it defaults to the various platforms
>> enabled in the configuration file.
> 
> Miquel are you able to review and apply those patches if satisfactory? Thanks!

Ping?
-- 
Florian

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[Miquel Raynal]

Hello Florian,

f.fainelli@gmail.com wrote on Sat, 3 Sep 2022 11:42:07 -0700:

> On 8/4/2022 10:55 AM, Florian Fainelli wrote:
> > On 7/11/22 15:23, Florian Fainelli wrote:  
> >> Hi all,
> >>
> >> This patch series allows for a finer control over the BRCMNAND driver
> >> glue driver selection such that it defaults to the various platforms
> >> enabled in the configuration file.  
> > 
> > Miquel are you able to review and apply those patches if satisfactory? Thanks!  
> 
> Ping?

Sorry for the delay, I was off for almost all July/August, I need to
sync with Richard and start catching up. I'll do my best but with
LPC/ELC-E approaching, I'm far from close to have enough spare time! At
the latest, I will settle the situation right after those conferences. 

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH 0/2] mtd: rawnand: brcmnand: Glue driver Kconfig entries

[Miquel Raynal]

Hi Florian,

f.fainelli@gmail.com wrote on Thu, 4 Aug 2022 10:55:21 -0700:

> On 7/11/22 15:23, Florian Fainelli wrote:
> > Hi all,
> > 
> > This patch series allows for a finer control over the BRCMNAND driver
> > glue driver selection such that it defaults to the various platforms
> > enabled in the configuration file.  
> 
> Miquel are you able to review and apply those patches if satisfactory? Thanks!

Sorry for the huge delay, I'm now trying to catch up on all my work
left since end of June, the series looks ok at a first glance and
received no comments so I'll apply it soon.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/