* [PATCH mmotm] slub: zero page to fix boot crashes
@ 2012-09-09 3:42 Hugh Dickins
2012-09-09 6:21 ` Christoph
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2012-09-09 3:42 UTC (permalink / raw)
To: Pekka Enberg
Cc: Christoph Lameter, Glauber Costa, Andrew Morton, mm-commits,
linux-kernel, linux-mm, linux-fsdevel, linux-next
Latest mmotm rarely boots if SLUB is enabled: earlyprintk=vga shows
it crashing with various backtraces. The memset has now been removed
from kmem_cache_open(), so kmem_cache_init() needs to zero its page.
This gets SLUB booting reliably again.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm/mm/slub.c 2012-09-07 12:39:38.136019730 -0700
+++ fixed/mm/slub.c 2012-09-08 19:37:38.608993123 -0700
@@ -3712,7 +3712,7 @@ void __init kmem_cache_init(void)
/* Allocate two kmem_caches from the page allocator */
kmalloc_size = ALIGN(kmem_size, cache_line_size());
order = get_order(2 * kmalloc_size);
- kmem_cache = (void *)__get_free_pages(GFP_NOWAIT, order);
+ kmem_cache = (void *)__get_free_pages(GFP_NOWAIT | __GFP_ZERO, order);
/*
* Must first have the slab cache available for the allocations of the
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mmotm] slub: zero page to fix boot crashes
2012-09-09 3:42 [PATCH mmotm] slub: zero page to fix boot crashes Hugh Dickins
@ 2012-09-09 6:21 ` Christoph
0 siblings, 0 replies; 2+ messages in thread
From: Christoph @ 2012-09-09 6:21 UTC (permalink / raw)
To: Hugh Dickins
Cc: Pekka Enberg, Glauber Costa, Andrew Morton, mm-commits,
linux-kernel, linux-mm, linux-fsdevel, linux-next
Yes that fix was already sent by me.
On Sep 8, 2012, at 22:42, Hugh Dickins <hughd@google.com> wrote:
> Latest mmotm rarely boots if SLUB is enabled: earlyprintk=vga shows
> it crashing with various backtraces. The memset has now been removed
> from kmem_cache_open(), so kmem_cache_init() needs to zero its page.
> This gets SLUB booting reliably again.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm/mm/slub.c 2012-09-07 12:39:38.136019730 -0700
> +++ fixed/mm/slub.c 2012-09-08 19:37:38.608993123 -0700
> @@ -3712,7 +3712,7 @@ void __init kmem_cache_init(void)
> /* Allocate two kmem_caches from the page allocator */
> kmalloc_size = ALIGN(kmem_size, cache_line_size());
> order = get_order(2 * kmalloc_size);
> - kmem_cache = (void *)__get_free_pages(GFP_NOWAIT, order);
> + kmem_cache = (void *)__get_free_pages(GFP_NOWAIT | __GFP_ZERO, order);
>
> /*
> * Must first have the slab cache available for the allocations of the
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-09 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-09 3:42 [PATCH mmotm] slub: zero page to fix boot crashes Hugh Dickins
2012-09-09 6:21 ` Christoph
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).