* linux-next: build warning after merge of the final tree (slab tree related)
@ 2012-09-11 6:19 Stephen Rothwell
2012-09-11 19:49 ` Christoph Lameter
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2012-09-11 6:19 UTC (permalink / raw)
To: Pekka Enberg, Christoph Lameter; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
Hi all,
After merging the final tree, today's linux-next build (sparc64 defconfig)
produced this warning:
mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common function for kmem_cache_destroy"). All uses of slab_error() are now guarded by DEBUG.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the final tree (slab tree related)
2012-09-11 6:19 linux-next: build warning after merge of the final tree (slab tree related) Stephen Rothwell
@ 2012-09-11 19:49 ` Christoph Lameter
2012-09-19 6:57 ` Pekka Enberg
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Lameter @ 2012-09-11 19:49 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Pekka Enberg, linux-next, linux-kernel
On Tue, 11 Sep 2012, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
>
> mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
>
> Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common function for kmem_cache_destroy"). All uses of slab_error() are now guarded by DEBUG.
Subject: Slab: Only define slab_error for DEBUG
There is no use case left for slab builds without DEBUG.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/mm/slab.c
===================================================================
--- linux.orig/mm/slab.c 2012-09-11 14:44:56.304015235 -0500
+++ linux/mm/slab.c 2012-09-11 14:48:46.988948440 -0500
@@ -803,6 +803,7 @@ static void cache_estimate(unsigned long
*left_over = slab_size - nr_objs*buffer_size - mgmt_size;
}
+#if DEBUG
#define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)
static void __slab_error(const char *function, struct kmem_cache *cachep,
@@ -812,6 +813,7 @@ static void __slab_error(const char *fun
function, cachep->name, msg);
dump_stack();
}
+#endif
/*
* By default on NUMA we use alien caches to stage the freeing of
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the final tree (slab tree related)
2012-09-11 19:49 ` Christoph Lameter
@ 2012-09-19 6:57 ` Pekka Enberg
2012-09-19 7:22 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Pekka Enberg @ 2012-09-19 6:57 UTC (permalink / raw)
To: Christoph Lameter
Cc: Stephen Rothwell, Pekka Enberg, linux-next, linux-kernel
On Tue, 11 Sep 2012, Christoph Lameter wrote:
> On Tue, 11 Sep 2012, Stephen Rothwell wrote:
>
> > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > produced this warning:
> >
> > mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
> >
> > Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common function for kmem_cache_destroy"). All uses of slab_error() are now guarded by DEBUG.
>
>
> Subject: Slab: Only define slab_error for DEBUG
>
> There is no use case left for slab builds without DEBUG.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
>
> Index: linux/mm/slab.c
> ===================================================================
> --- linux.orig/mm/slab.c 2012-09-11 14:44:56.304015235 -0500
> +++ linux/mm/slab.c 2012-09-11 14:48:46.988948440 -0500
> @@ -803,6 +803,7 @@ static void cache_estimate(unsigned long
> *left_over = slab_size - nr_objs*buffer_size - mgmt_size;
> }
>
> +#if DEBUG
> #define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)
>
> static void __slab_error(const char *function, struct kmem_cache *cachep,
> @@ -812,6 +813,7 @@ static void __slab_error(const char *fun
> function, cachep->name, msg);
> dump_stack();
> }
> +#endif
>
> /*
> * By default on NUMA we use alien caches to stage the freeing of
>
Applied, thanks.
P.S. Guys, please use penberg@kernel.org email address. I missed this
patch because I don't read this mailbox.
Pekka
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the final tree (slab tree related)
2012-09-19 6:57 ` Pekka Enberg
@ 2012-09-19 7:22 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2012-09-19 7:22 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Christoph Lameter, Pekka Enberg, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Hi Pekka,
On Wed, 19 Sep 2012 09:57:58 +0300 (EEST) Pekka Enberg <penberg@kernel.org> wrote:
>
> P.S. Guys, please use penberg@kernel.org email address. I missed this
> patch because I don't read this mailbox.
I have now changed the contact address I have listed for you.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-19 7:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-11 6:19 linux-next: build warning after merge of the final tree (slab tree related) Stephen Rothwell
2012-09-11 19:49 ` Christoph Lameter
2012-09-19 6:57 ` Pekka Enberg
2012-09-19 7:22 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).