linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the akpm-current tree with the kunit-next tree
@ 2020-10-12  8:56 Stephen Rothwell
  2020-10-15  5:38 ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2020-10-12  8:56 UTC (permalink / raw)
  To: Andrew Morton, Shuah Khan, Brendan Higgins
  Cc: David Gow, Linux Kernel Mailing List, Linux Next Mailing List,
	Patricia Alfonso

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Hi all,

Today's linux-next merge of the akpm-current tree got a conflict in:

  lib/kunit/test.c

between commit:

  45dcbb6f5ef7 ("kunit: test: add test plan to KUnit TAP format")

from the kunit-next tree and commit:

  e685acc91080 ("KUnit: KASAN Integration")

from the akpm-current tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc lib/kunit/test.c
index de07876b6601,dcc35fd30d95..000000000000
--- a/lib/kunit/test.c
+++ b/lib/kunit/test.c
@@@ -15,11 -16,16 +16,6 @@@
  #include "string-stream.h"
  #include "try-catch-impl.h"
  
- static void kunit_set_failure(struct kunit *test)
 -static void kunit_print_tap_version(void)
--{
- 	WRITE_ONCE(test->success, false);
 -	static bool kunit_has_printed_tap_version;
 -
 -	if (!kunit_has_printed_tap_version) {
 -		pr_info("TAP version 14\n");
 -		kunit_has_printed_tap_version = true;
 -	}
--}
--
  /*
   * Append formatted message to log, size of which is limited to
   * KUNIT_LOG_SIZE bytes (including null terminating byte).

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: manual merge of the akpm-current tree with the kunit-next tree
  2020-10-12  8:56 linux-next: manual merge of the akpm-current tree with the kunit-next tree Stephen Rothwell
@ 2020-10-15  5:38 ` Stephen Rothwell
  2020-10-15 17:56   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2020-10-15  5:38 UTC (permalink / raw)
  To: Shuah Khan, Brendan Higgins
  Cc: Andrew Morton, David Gow, Linux Kernel Mailing List,
	Linux Next Mailing List, Patricia Alfonso

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Hi all,

On Mon, 12 Oct 2020 19:56:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the akpm-current tree got a conflict in:
> 
>   lib/kunit/test.c
> 
> between commit:
> 
>   45dcbb6f5ef7 ("kunit: test: add test plan to KUnit TAP format")
> 
> from the kunit-next tree and commit:
> 
>   e685acc91080 ("KUnit: KASAN Integration")
> 
> from the akpm-current tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> diff --cc lib/kunit/test.c
> index de07876b6601,dcc35fd30d95..000000000000
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@@ -15,11 -16,16 +16,6 @@@
>   #include "string-stream.h"
>   #include "try-catch-impl.h"
>   
> - static void kunit_set_failure(struct kunit *test)
>  -static void kunit_print_tap_version(void)
> --{
> - 	WRITE_ONCE(test->success, false);
>  -	static bool kunit_has_printed_tap_version;
>  -
>  -	if (!kunit_has_printed_tap_version) {
>  -		pr_info("TAP version 14\n");
>  -		kunit_has_printed_tap_version = true;
>  -	}
> --}
> --
>   /*
>    * Append formatted message to log, size of which is limited to
>    * KUNIT_LOG_SIZE bytes (including null terminating byte).

This is now a conflict between the kunit-next tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: manual merge of the akpm-current tree with the kunit-next tree
  2020-10-15  5:38 ` Stephen Rothwell
@ 2020-10-15 17:56   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2020-10-15 17:56 UTC (permalink / raw)
  To: Stephen Rothwell, Brendan Higgins
  Cc: Andrew Morton, David Gow, Linux Kernel Mailing List,
	Linux Next Mailing List, Patricia Alfonso, Shuah Khan

On 10/14/20 11:38 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 12 Oct 2020 19:56:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Today's linux-next merge of the akpm-current tree got a conflict in:
>>
>>    lib/kunit/test.c
>>
>> between commit:
>>
>>    45dcbb6f5ef7 ("kunit: test: add test plan to KUnit TAP format")
>>
>> from the kunit-next tree and commit:
>>
>>    e685acc91080 ("KUnit: KASAN Integration")
>>
>> from the akpm-current tree.
>>
>> I fixed it up (see below) and can carry the fix as necessary. This
>> is now fixed as far as linux-next is concerned, but any non trivial
>> conflicts should be mentioned to your upstream maintainer when your tree
>> is submitted for merging.  You may also want to consider cooperating
>> with the maintainer of the conflicting tree to minimise any particularly
>> complex conflicts.
>>
>> diff --cc lib/kunit/test.c
>> index de07876b6601,dcc35fd30d95..000000000000
>> --- a/lib/kunit/test.c
>> +++ b/lib/kunit/test.c
>> @@@ -15,11 -16,16 +16,6 @@@
>>    #include "string-stream.h"
>>    #include "try-catch-impl.h"
>>    
>> - static void kunit_set_failure(struct kunit *test)
>>   -static void kunit_print_tap_version(void)
>> --{
>> - 	WRITE_ONCE(test->success, false);
>>   -	static bool kunit_has_printed_tap_version;
>>   -
>>   -	if (!kunit_has_printed_tap_version) {
>>   -		pr_info("TAP version 14\n");
>>   -		kunit_has_printed_tap_version = true;
>>   -	}
>> --}
>> --
>>    /*
>>     * Append formatted message to log, size of which is limited to
>>     * KUNIT_LOG_SIZE bytes (including null terminating byte).
> 
> This is now a conflict between the kunit-next tree and Linus' tree.
> 

Thanks Stephen. I will mention this conflict in my pull request to
Linus.

Thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-15 17:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12  8:56 linux-next: manual merge of the akpm-current tree with the kunit-next tree Stephen Rothwell
2020-10-15  5:38 ` Stephen Rothwell
2020-10-15 17:56   ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).