From: Yanteng Si <siyanteng01@gmail.com>
To: tsbogend@alpha.franken.de, sergio.paracuellos@gmail.com,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com
Cc: Yanteng Si <siyanteng@loongson.cn>,
sfr@canb.auug.org.au, lorenzo.pieralisi@arm.com, robh@kernel.org,
kw@linux.com, bhelgaas@google.com, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
chenhuacai@kernel.org, sterlingteng@gmail.com,
linux-next@vger.kernel.org
Subject: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code
Date: Thu, 28 Oct 2021 12:04:53 +0800 [thread overview]
Message-ID: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> (raw)
In-Reply-To: <cover.1635390750.git.siyanteng@loongson.cn>
Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
the MT7621 PCIe host controller driver is built as a module but modpost complains once these
drivers become modules.
ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
Let's just export them.
Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
---
arch/mips/kernel/mips-cm.c | 5 +++++
arch/mips/kernel/mips-cpc.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c
index 90f1c3df1f0e..892258760bf3 100644
--- a/arch/mips/kernel/mips-cm.c
+++ b/arch/mips/kernel/mips-cm.c
@@ -12,8 +12,11 @@
#include <asm/mipsregs.h>
void __iomem *mips_gcr_base;
+EXPORT_SYMBOL_GPL(mips_gcr_base);
+
void __iomem *mips_cm_l2sync_base;
int mips_cm_is64;
+EXPORT_SYMBOL_GPL(mips_cm_is64);
static char *cm2_tr[8] = {
"mem", "gcr", "gic", "mmio",
@@ -353,6 +356,7 @@ void mips_cm_lock_other(unsigned int cluster, unsigned int core,
*/
mb();
}
+EXPORT_SYMBOL_GPL(mips_cm_lock_other);
void mips_cm_unlock_other(void)
{
@@ -369,6 +373,7 @@ void mips_cm_unlock_other(void)
preempt_enable();
}
+EXPORT_SYMBOL_GPL(mips_cm_unlock_other);
void mips_cm_error_report(void)
{
diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
index 8d2535123f11..26392d18729c 100644
--- a/arch/mips/kernel/mips-cpc.c
+++ b/arch/mips/kernel/mips-cpc.c
@@ -13,6 +13,7 @@
#include <asm/mips-cps.h>
void __iomem *mips_cpc_base;
+EXPORT_SYMBOL_GPL(mips_cpc_base);
static DEFINE_PER_CPU_ALIGNED(spinlock_t, cpc_core_lock);
--
2.27.0
next prev parent reply other threads:[~2021-10-28 4:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 4:04 [PATCH v2 0/3] MIPS: Fix build error ERROR: modpost: Yanteng Si
2021-10-28 4:04 ` [PATCH v2 1/3] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver Yanteng Si
2021-10-28 4:04 ` Yanteng Si [this message]
2021-10-28 4:11 ` [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Sergio Paracuellos
2021-10-28 9:23 ` Thomas Bogendoerfer
2021-10-28 9:34 ` Sergio Paracuellos
2021-10-28 9:59 ` Sergio Paracuellos
2021-10-28 20:47 ` Bjorn Helgaas
2021-10-29 5:28 ` Sergio Paracuellos
2021-10-29 18:49 ` Bjorn Helgaas
2021-10-29 19:37 ` Sergio Paracuellos
2021-10-29 19:47 ` Bjorn Helgaas
2021-10-29 20:27 ` Sergio Paracuellos
2021-10-30 5:21 ` Sergio Paracuellos
2021-10-30 5:38 ` Sergio Paracuellos
2021-11-07 7:00 ` Sergio Paracuellos
2021-11-09 22:41 ` Bjorn Helgaas
2021-11-10 6:00 ` Sergio Paracuellos
2021-11-15 8:17 ` Sergio Paracuellos
2021-10-28 4:04 ` [PATCH v2 3/3] MIPS: traps: export a missing symbols to be able to use it " Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn \
--to=siyanteng01@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=siyanteng@loongson.cn \
--cc=sterlingteng@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).