From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Yanteng Si <siyanteng01@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Yanteng Si <siyanteng@loongson.cn>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
kw@linux.com, Bjorn Helgaas <bhelgaas@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-pci <linux-pci@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
chenhuacai@kernel.org, sterlingteng@gmail.com,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code
Date: Thu, 28 Oct 2021 11:23:18 +0200 [thread overview]
Message-ID: <20211028092318.GA6574@alpha.franken.de> (raw)
In-Reply-To: <CAMhs-H9LUQ6Km=sA992LH=+E0MbGuMf9YhM6w2HoyeqE0QbzJQ@mail.gmail.com>
On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote:
> On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si <siyanteng01@gmail.com> wrote:
> >
> > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
> > the MT7621 PCIe host controller driver is built as a module but modpost complains once these
> > drivers become modules.
> >
> > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> >
> > Let's just export them.
> >
> > Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> > ---
> > arch/mips/kernel/mips-cm.c | 5 +++++
> > arch/mips/kernel/mips-cpc.c | 1 +
> > 2 files changed, 6 insertions(+)
> >
>
> Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
could we instead make the pcie-mt761 driver non modular ? Exporting
all MIPS specific stuff for just making an essential driver modular
doesn't IMHO make much sense.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-10-28 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 4:04 [PATCH v2 0/3] MIPS: Fix build error ERROR: modpost: Yanteng Si
2021-10-28 4:04 ` [PATCH v2 1/3] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver Yanteng Si
2021-10-28 4:04 ` [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Yanteng Si
2021-10-28 4:11 ` Sergio Paracuellos
2021-10-28 9:23 ` Thomas Bogendoerfer [this message]
2021-10-28 9:34 ` Sergio Paracuellos
2021-10-28 9:59 ` Sergio Paracuellos
2021-10-28 20:47 ` Bjorn Helgaas
2021-10-29 5:28 ` Sergio Paracuellos
2021-10-29 18:49 ` Bjorn Helgaas
2021-10-29 19:37 ` Sergio Paracuellos
2021-10-29 19:47 ` Bjorn Helgaas
2021-10-29 20:27 ` Sergio Paracuellos
2021-10-30 5:21 ` Sergio Paracuellos
2021-10-30 5:38 ` Sergio Paracuellos
2021-11-07 7:00 ` Sergio Paracuellos
2021-11-09 22:41 ` Bjorn Helgaas
2021-11-10 6:00 ` Sergio Paracuellos
2021-11-15 8:17 ` Sergio Paracuellos
2021-10-28 4:04 ` [PATCH v2 3/3] MIPS: traps: export a missing symbols to be able to use it " Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028092318.GA6574@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=siyanteng01@gmail.com \
--cc=siyanteng@loongson.cn \
--cc=sterlingteng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).