From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: linux-next: s390 build failure
Date: Fri, 20 Jun 2008 13:51:47 +0200 [thread overview]
Message-ID: <1213962707.32462.9.camel@localhost> (raw)
In-Reply-To: <20080620124235.24fbe33e.sfr@canb.auug.org.au>
On Fri, 2008-06-20 at 12:42 +1000, Stephen Rothwell wrote:
> In file included from /scratch/michael/kisskb-build/src/include/linux/spinlock.h:87,
> from /scratch/michael/kisskb-build/src/include/linux/smp.h:11,
> from /scratch/michael/kisskb-build/src/include/linux/kernel_stat.h:4,
> from /scratch/michael/kisskb-build/src/mm/memory.c:41:
> include2/asm/spinlock.h: In function '__raw_spin_lock':
> include2/asm/spinlock.h:69: error: implicit declaration of function 'smp_processor_id'
>
> There are others as well, but I was concentrating on this. Bisecting
> leads to commit 2448ad3d8e64a9b58acca34a3d010cfa0be88cc1 which is the
> merge of the block tree. The block tree contains a commit
> (37e81b98dba08cce1d8eedb2bdaa58022bf31ee0 "Add generic helpers for arch
> IPI function calls") that adds an include of linux/spinlock.h to
> linux/smp.h. (asm-s390/spinlock.h includes linux/smp.h ...)
>
> But the block tree itself is OK. So something in the s390 tree is
> interacting with the above commit to cause the failure. It is not
> immediately obvious to me what that is. (Or I may have screwed up the
> bisect :-))
Hmm, the minimal test case for this is:
#include <linux/smp.h>
* linux/smp.h defines __LINUX_SMP_H then includes linux/spinlock.h
* linux/spinlock.h includes some more headers, then asm/spinlock.h
* asm/spinlock.h includes linux/smp.h with no effect because linux/smp.h
has already defined __LINUX_SMP_H, then uses smp_processor_id() which is
not defined yet
* on return from the linux/spinlock.h include linux/smp.h defines
smp_processor_id()
Relavant commits that cause this problem:
1)
commit 3888f22c9cc8b4eca034f11b13d7f7957627fcfb
Author: Jens Axboe <jens.axboe@oracle.com>
Date: Fri Jun 6 10:58:32 2008 +0200
Add generic helpers for arch IPI function calls
This commit introduces the #include <linux/spinlock.h> to linux/smp.h
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-06-20 11:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 2:42 linux-next: s390 build failure Stephen Rothwell
2008-06-20 11:42 ` Jens Axboe
2008-06-21 8:07 ` Heiko Carstens
2008-06-26 9:14 ` Jens Axboe
2008-06-20 11:51 ` Martin Schwidefsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-19 23:53 Stephen Rothwell
2009-03-19 23:42 Stephen Rothwell
2009-03-20 8:24 ` Heiko Carstens
2009-03-20 10:00 ` Ingo Molnar
2009-03-20 10:33 ` Heiko Carstens
2008-06-20 3:52 Stephen Rothwell
2008-06-20 7:58 ` Cornelia Huck
2008-06-23 15:22 ` Cornelia Huck
2008-06-23 22:13 ` Greg KH
2008-05-12 8:03 Stephen Rothwell
2008-05-12 16:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213962707.32462.9.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).