linux-next: nfs tree build warning

linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Hi Trond,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

fs/nfs/write.c: In function 'nfs_migrate_page':
fs/nfs/write.c:1601: warning: unused variable 'inode'

Introduced by commit 1ec000f4f76ea914aa4ac57f8cec53fa958bd477 ("NFS: Add
a ->migratepage() aop for NFS").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfs tree build warning

[Trond Myklebust]

On Mon, 2009-08-10 at 10:58 +1000, Stephen Rothwell wrote:
> Hi Trond,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> fs/nfs/write.c: In function 'nfs_migrate_page':
> fs/nfs/write.c:1601: warning: unused variable 'inode'
> 
> Introduced by commit 1ec000f4f76ea914aa4ac57f8cec53fa958bd477 ("NFS: Add
> a ->migratepage() aop for NFS").

Oops, you're right. I'll fix that...

Trond

linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi Trond,

Today's linux-next build (i386 defconfig) produced this warning:

net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall':
net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t

Introduced by commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a ("sunrpc:
on successful gss error pipe write, don't return error").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi Trond,

On Thu, 18 Jun 2009 18:09:12 -0700 Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> That's my fault: it was due to inattention during the merge of the
> nfsv41 tree with the mainline NFS changes. I'll fix...

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfs tree build warning

[Trond Myklebust]

On Fri, 2009-06-19 at 10:50 +1000, Stephen Rothwell wrote:
> Hi Trond,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> fs/nfs/super.c: In function 'nfs_parse_mount_options':
> fs/nfs/super.c:1253: warning: passing argument 2 of 'match_int' from incompatible pointer type
> include/linux/parser.h:29: note: expected 'int *' but argument is of type 'long unsigned int *'
> 
> Introduced by commit 3fd5be9e19921a89d9ed78d6a708a379a6c3c76a ("nfs41:
> add mount command option minorversion").
> 

That's my fault: it was due to inattention during the merge of the
nfsv41 tree with the mainline NFS changes. I'll fix...

Trond

linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Trond,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

fs/nfs/super.c: In function 'nfs_parse_mount_options':
fs/nfs/super.c:1253: warning: passing argument 2 of 'match_int' from incompatible pointer type
include/linux/parser.h:29: note: expected 'int *' but argument is of type 'long unsigned int *'

Introduced by commit 3fd5be9e19921a89d9ed78d6a708a379a6c3c76a ("nfs41:
add mount command option minorversion").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Hi Trond,

On Fri, 1 May 2009 13:15:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes

I am still getting this warning.  What happened to Benny's patch?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfs tree build warning

[William A. (Andy) Adamson]

On Fri, May 1, 2009 at 8:19 AM, Benny Halevy <bhalevy@panasas.com> wrote:
> On May. 01, 2009, 6:22 +0300, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>> On Fri, 2009-05-01 at 13:15 +1000, Stephen Rothwell wrote:
>>> Hi Trond,
>>>
>>> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>>>
>>> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
>>> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes
>>>
>>> Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
>>> exchange_id operation").  This commit has been around for a while.
>>
>> Benny, Andy,
>>
>> Why are we preallocating 1k buffers on the stack for these things?
>> That's an insane amount of free space...
>>
>> If this is truly a realistic value (which I sincerely doubt), then the
>> right thing to do is to preallocate a page in which to store them.
>> Putting 1k arrays on the stack is just _wrong_.
>>
>> Trond
>>
>
> Ouch, struct nfs41_exchange_id_res contains
>        struct server_owner             server_owner;
>        struct server_scope             server_scope;
> each embedding a char [NFS4_OPAQUE_LIMIT] array
> which is 1K in length.
> Not only we should have preallocated these arrays dynamically,
> we actually throw them away.
> Therefore I suggest that until they are put to use
> we should just skip their xdr decoding, like we do
> for the implementation ID.

Yes, I agree. That is just wrong....

-->Andy
>
> Benny
>

Re: linux-next: nfs tree build warning

[Benny Halevy]

On May. 01, 2009, 6:22 +0300, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> On Fri, 2009-05-01 at 13:15 +1000, Stephen Rothwell wrote:
>> Hi Trond,
>>
>> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>>
>> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
>> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes
>>
>> Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
>> exchange_id operation").  This commit has been around for a while.
> 
> Benny, Andy,
> 
> Why are we preallocating 1k buffers on the stack for these things?
> That's an insane amount of free space...
> 
> If this is truly a realistic value (which I sincerely doubt), then the
> right thing to do is to preallocate a page in which to store them.
> Putting 1k arrays on the stack is just _wrong_.
> 
> Trond
> 

Ouch, struct nfs41_exchange_id_res contains
	struct server_owner		server_owner;
	struct server_scope		server_scope;
each embedding a char [NFS4_OPAQUE_LIMIT] array
which is 1K in length.
Not only we should have preallocated these arrays dynamically,
we actually throw them away.
Therefore I suggest that until they are put to use
we should just skip their xdr decoding, like we do
for the implementation ID.

Benny

Re: linux-next: nfs tree build warning

[Trond Myklebust]

On Fri, 2009-05-01 at 13:15 +1000, Stephen Rothwell wrote:
> Hi Trond,
> 
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
> fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes
> 
> Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
> exchange_id operation").  This commit has been around for a while.

Benny, Andy,

Why are we preallocating 1k buffers on the stack for these things?
That's an insane amount of free space...

If this is truly a realistic value (which I sincerely doubt), then the
right thing to do is to preallocate a page in which to store them.
Putting 1k arrays on the stack is just _wrong_.

Trond

linux-next: nfs tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi Trond,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/nfs/nfs4proc.c: In function 'nfs4_proc_exchange_id':
fs/nfs/nfs4proc.c:4279: warning: the frame size of 2288 bytes is larger than 2048 bytes

Introduced by commit 63a93b4af49220c74757beb17b5617b72d912b6b ("nfs41:
exchange_id operation").  This commit has been around for a while.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]