* linux-next: build warning after merge of the block tree
@ 2010-09-16 3:30 Stephen Rothwell
2010-09-16 3:55 ` [PATCH] block: fix an warning of calling blk_rq_aligned() Namhyung Kim
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2010-09-16 3:30 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-next, linux-kernel, Namhyung Kim
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
Hi Jens,
After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/scsi/sg.c: In function 'sg_start_req':
drivers/scsi/sg.c:1660: warning: passing argument 2 of 'blk_rq_aligned' makes integer from pointer without a cast
include/linux/blkdev.h:1045: note: expected 'long unsigned int' but argument is of type 'void *'
Introduced by commit 144177991ca624841ddbd1e7edff958fc0f6d1fe ("block:
fix an address space warning in blk-map.c").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] block: fix an warning of calling blk_rq_aligned()
2010-09-16 3:30 linux-next: build warning after merge of the block tree Stephen Rothwell
@ 2010-09-16 3:55 ` Namhyung Kim
2010-09-16 6:23 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Namhyung Kim @ 2010-09-16 3:55 UTC (permalink / raw)
To: Stephen Rothwell, Jens Axboe; +Cc: linux-next, linux-kernel
2nd argument of blk_rq_aligned() has changed to 'unsigned long' by
previous commit 'block: fix an address space warning in blk-map.c'.
According to that change, its caller has to be modified. This also
removes address space warnings from sparse.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
drivers/scsi/sg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 78d6163..655ab92 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1657,7 +1657,7 @@ static int sg_start_req(Sg_request *srp, unsigned char *cmd)
if (sg_allow_dio && hp->flags & SG_FLAG_DIRECT_IO &&
dxfer_dir != SG_DXFER_UNKNOWN && !iov_count &&
!sfp->parentdp->device->host->unchecked_isa_dma &&
- blk_rq_aligned(q, hp->dxferp, dxfer_len))
+ blk_rq_aligned(q, (unsigned long)hp->dxferp, dxfer_len))
md = NULL;
else
md = &map_data;
--
1.7.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-16 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-16 3:30 linux-next: build warning after merge of the block tree Stephen Rothwell
2010-09-16 3:55 ` [PATCH] block: fix an warning of calling blk_rq_aligned() Namhyung Kim
2010-09-16 6:23 ` Jens Axboe
2010-09-16 14:03 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).